It had been a directory authority since 0.2.1.20.

Issues noted by cypherpunks on #18162

This closes bug 18162; bugfix on a45b1315, which fixed a related
issue long ago.

In addition to the #18162 issues, this fixes a signed integer overflow
in smarltist_add_all(), which is probably not so great either.

teor (Tim Wilson-Brown) authored Dec 21, 2015 and Nick Mathewson committed Jan 07, 2016

This new identity key was changed on 18 November 2015.

There was a dead check when we made sure that an array member of a
struct was non-NULL.  Tor has been doing this check since at least
0.2.3, maybe earlier.

Fixes bug 17781.

Yawning Angel authored Apr 02, 2015 and Nick Mathewson committed Apr 06, 2015

In theory these should never the triggered as the only caller now
validates the parameters before this routine gets called.

Yawning Angel authored Apr 02, 2015 and Nick Mathewson committed Apr 06, 2015

Found by DonnchaC.

Yawning Angel authored Mar 30, 2015 and Nick Mathewson committed Apr 06, 2015

Fixes bug 15600; reported by skruffy

George Kadianakis authored Apr 02, 2015 and Nick Mathewson committed Apr 03, 2015

(Sending a nak would be pointless.)

See ticket 15515 for discussion.