1. 22 May, 2019 1 commit
    • David Goulet's avatar
      sendme: Record cell digest on both client and exit · 59b9eecc
      David Goulet authored and Nick Mathewson's avatar Nick Mathewson committed
      
      
      It turns out that only the exit side is validating the authenticated SENDME v1
      logic and never the client side. Which means that if a client ever uploaded
      data towards an exit, the authenticated SENDME logic wouldn't apply.
      
      For this to work, we have to record the cell digest client side as well which
      introduced a new function that supports both type of edges.
      
      This also removes a test that is not valid anymore which was that we didn't
      allow cell recording on an origin circuit (client).
      
      Part of #30428
      
      Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
      59b9eecc
  2. 15 May, 2019 25 commits
  3. 14 May, 2019 2 commits
  4. 13 May, 2019 10 commits
  5. 10 May, 2019 2 commits
    • Nick Mathewson's avatar
      Don't pass a NULL into a %s when logging client auth file load failure · ff558403
      Nick Mathewson authored
      Fortunately, in 0.3.5.1-alpha we improved logging for various
      failure cases involved with onion service client auth.
      
      Unfortunately, for this one, we freed the file right before logging
      its name.
      
      Fortunately, tor_free() sets its pointer to NULL, so we didn't have
      a use-after-free bug.
      
      Unfortunately, passing NULL to %s is not defined.
      
      Fortunately, GCC 9.1.1 caught the issue!
      
      Unfortunately, nobody has actually tried building Tor with GCC 9.1.1
      before. Or if they had, they didn't report the warning.
      
      Fixes bug 30475; bugfix on 0.3.5.1-alpha.
      ff558403
    • George Kadianakis's avatar
      Merge branch 'tor-github/pr/973' · 501d1ae0
      George Kadianakis authored
      501d1ae0