1. 06 Jun, 2011 1 commit
    • Nick Mathewson's avatar
      Check maximum properly in crypto_rand_int() · 5afab5ca
      Nick Mathewson authored
      George Kadianakis notes that if you give crypto_rand_int() a value
      above INT_MAX, it can return a negative number, which is not what
      the documentation would imply.
      
      The simple solution is to assert that the input is in [1,INT_MAX+1].
      If in the future we need a random-value function that can return
      values up to UINT_MAX, we can add one.
      
      Fixes bug 3306; bugfix on 0.2.2pre14.
      5afab5ca
  2. 03 Jun, 2011 3 commits
  3. 02 Jun, 2011 10 commits
  4. 01 Jun, 2011 3 commits
    • Gisle's avatar
      Fix compile error in procmon.c · 1d8bcba0
      Gisle authored and Nick Mathewson's avatar Nick Mathewson committed
      An elusive compile-error (MingW-gcc v4.50 on Win_XP); a missing
      comma (!) and a typo ('err_msg' at line 277 changed to 'errmsg').
      Aso changed the format for 'err_code' at line 293 into a "%ld" to suppress
      a warning. How did this go unnoticed for ~1 month? Btw. This is my 1st ever
      'git commit', so it better work.
      1d8bcba0
    • Nick Mathewson's avatar
      Report wrong key sizes correctly · 0fd3ad75
      Nick Mathewson authored
      When we introduced NEED_KEY_1024 in routerparse.c back in
      0.2.0.1-alpha, I forgot to add a *8 when logging the length of a
      bad-length key.
      
      Bugfix for 3318 on 0.2.0.1-alpha.
      0fd3ad75
    • Roger Dingledine's avatar
      fix a bridge edge case similar to 2511 · 7039c345
      Roger Dingledine authored
      If you had configured a bridge but then switched to a different bridge
      via the controller, you would still be willing to use the old one.
      7039c345
  5. 31 May, 2011 1 commit
    • Roger Dingledine's avatar
      stop asserting at boot · 56771f39
      Roger Dingledine authored
      The patch for 3228 made us try to run init_keys() before we had loaded
      our state file, resulting in an assert inside init_keys. We had moved
      it too early in the function.
      
      Now it's later in the function, but still above the accounting calls.
      56771f39
  6. 30 May, 2011 13 commits
  7. 29 May, 2011 1 commit
  8. 28 May, 2011 4 commits
  9. 24 May, 2011 2 commits
  10. 23 May, 2011 2 commits
    • Nick Mathewson's avatar
      Work correctly if your nameserver is ::1 · be768509
      Nick Mathewson authored
      We had all the code in place to handle this right... except that we
      were unconditionally opening a PF_INET socket instead of looking at
      sa_family.  Ow.
      
      Fixes bug 2574; not a bugfix on any particular version, since this
      never worked before.
      be768509
    • Nick Mathewson's avatar
      Fix GCC 4.6's new -Wunused-but-set-variable warnings. · a5232e0c
      Nick Mathewson authored
      Most instances were dead code; for those, I removed the assignments.
      Some were pieces of info we don't currently plan to use, but which
      we might in the future.  For those, I added an explicit cast-to-void
      to indicate that we know that the thing's unused.  Finally, one was
      a case where we were testing the wrong variable in a unit test.
      That one I fixed.
      
      This resolves bug 3208.
      a5232e0c