And consistently talk about extra-info document publishing.

Obviously correct documentation changes.

Obviously correct changes to already-reviewed code.

This controls the previous feature added that makes dirauth send back a 503
error code on non relay connections if under bandwidth pressure.
Signed-off-by: David Goulet <dgoulet@torproject.org>

Fix a client port list that's missing HTTPTunnelPort.

Wrap a long line.

Explain that:
* most flags default to off
* flags that default to on are specified

Document PreferIPv6Automap in its "No" form, because it's on by
default.

Cleanup after 32637.

Make Tor clients tell dual-stack exits that they prefer IPv6
connections.

This change is equivalent to setting the PreferIPv6 flag on
SOCKSPorts (and most other listener ports). Tor Browser has
been setting this flag for some time, and we want to remove a
client distinguisher at exits.

Also update the man page, putting all the IP flags in their
non-default forms.

Closes ticket 32637.

Taylor Yu authored Jan 09, 2020 and Nick Mathewson committed Jan 13, 2020

Move some SafeSocks-related options near each other.  Part of ticket
32846.

Taylor Yu authored Jan 09, 2020 and Nick Mathewson committed Jan 13, 2020

Move ReducedCircuitPadding and ReducedConnectionPadding immediately
after the corresponding non-Reduced options.  Part of ticket 32846.

Taylor Yu authored Jan 09, 2020 and Nick Mathewson committed Jan 13, 2020

Only directory authorities use the GuardfractionFile option, so move
it to that section.  Part of ticket 32846.

Swati Thacker authored Dec 27, 2019 and Nick Mathewson committed Jan 13, 2020

Alphabetize client options in tor.1.txt.  Closes ticket32846.

We stopped looking at this option in 85cf6dcb, back when we
implemented the minimal pieces of prop275.  Since then, we've had
code to validate and adjust this option, and to give it a different
value in testing networks, but the option hasn't actually done
anything.

We can safely mark it as OBSOLETE, since doing so does not make any
old configuration get rejected.

Closes ticket 32807.

Fix some quoting, especially of constructs like "[address:]port", that
were proving tricky for Asciidoctor tooling to parse correctly.

Also fix formatting of some configuration variable names that
contained double underscores.  Neither asciidoc nor asciidoctor was
rendering some of those correctly.

Part of ticket 32708.

Change the section title formatting to use the one-line format.  This
allows Asciidoctor-based tooling to parse it more easily.

Part of ticket 32708.

Indent the asciidoc markup for lone linebreaks to match the preceding
paragraph line, so that Asciidoctor tools can format them correctly.

Part of ticket 32708.

These are unrelated changes done by Swati while doing the alphabetizing.

Part of ticket 32708.

Swati Thacker authored Nov 26, 2019 and Taylor Yu committed Dec 12, 2019

Part of ticket 32708.

If ExtendedErrors is set for the SocksPort, an invalid .onion address now
returns the 0xF6 error code per prop304.

Closes #30022
Signed-off-by: David Goulet <dgoulet@torproject.org>

In #26913 we solved a bug where CacheDirectoryGroupReadable would
override DataDirectoryGroupReadable when the two directories are the
same.  We never did the same for KeyDirectory, though, because
that's a rare setting.

Now that I'm testing this code, though, fixing this issue seems
fine.  Fixes bug #27992; bugfix on 0.3.3.1-alpha.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Closes ticket 32467.

Closes ticket 32406.

Reformat command line options in tor.1.txt to display as fixed-width
in the HTML version.  Based on a patch by Swati Thacker.  Part of
ticket 32277.

Reword the COMMAND-LINE OPTIONS section of tor.1.txt.  Based on a
patch by Swati Thacker.  Part of ticket 32277.

Reword the DESCRIPTION section of tor.1.txt.

Based on a patch by Swati Thacker.  Part of ticket 32277.

In tor.1.txt, move the paragraphs at the end of the COMMAND-LINE
OPTIONS section earlier.  This text describes how the user can specify
configuration options on the command line.

Also clarify some wording and formatting.

Based on a patch by Swati Thacker.  Part of ticket 32277.