1. 05 Sep, 2019 2 commits
  2. 23 Jul, 2019 1 commit
  3. 28 Jun, 2019 1 commit
    • teor's avatar
      changes: file for 28795 · fb977f8c
      teor authored
      Replace the 157 fallbacks originally introduced in Tor 0.3.5.6-rc
      in December 2018 (of which ~122 were still functional), with a
      list of 148 fallbacks (70 new, 78 existing, 79 removed) generated
      in June 2019.
      
      Closes ticket 28795.
      
      Note that we created extra lists from DE and US, but they didn't add
      any more fallbacks when we tried to merge them.
      fb977f8c
  4. 11 Jun, 2019 1 commit
  5. 10 Jun, 2019 2 commits
    • teor's avatar
      Travis: Skip test_rebind on macOS builds · be0a4be2
      teor authored
      Skip test_rebind when the TOR_SKIP_TEST_REBIND environmental variable
      is set.
      
      Skip test_rebind on macOS in Travis builds, because it is unreliable
      on macOS on Travis.
      
      Fixes bug 30713; bugfix on 0.3.5.1-alpha.
      be0a4be2
    • teor's avatar
      Travis: allow the test-stem job to fail · d761c3ca
      teor authored
      Allow the test-stem job to fail in Travis, because it sometimes hangs.
      
      Fixes bug 30744; bugfix on 0.3.5.4-alpha.
      d761c3ca
  6. 20 May, 2019 1 commit
  7. 17 May, 2019 1 commit
  8. 14 May, 2019 1 commit
  9. 10 May, 2019 1 commit
    • Nick Mathewson's avatar
      Don't pass a NULL into a %s when logging client auth file load failure · ff558403
      Nick Mathewson authored
      Fortunately, in 0.3.5.1-alpha we improved logging for various
      failure cases involved with onion service client auth.
      
      Unfortunately, for this one, we freed the file right before logging
      its name.
      
      Fortunately, tor_free() sets its pointer to NULL, so we didn't have
      a use-after-free bug.
      
      Unfortunately, passing NULL to %s is not defined.
      
      Fortunately, GCC 9.1.1 caught the issue!
      
      Unfortunately, nobody has actually tried building Tor with GCC 9.1.1
      before. Or if they had, they didn't report the warning.
      
      Fixes bug 30475; bugfix on 0.3.5.1-alpha.
      ff558403
  10. 30 Apr, 2019 2 commits
  11. 29 Apr, 2019 1 commit
  12. 24 Apr, 2019 1 commit
    • Alexander Færøy's avatar
      Lower log level of unlink() errors in networkstatus_set_current_consensus(). · 04290724
      Alexander Færøy authored
      In this patch we lower the log level of the failures for the three calls
      to unlink() in networkstatus_set_current_consensus(). These errors might
      trigger on Windows because the memory mapped consensus file keeps the
      file in open state even after we have close()'d it. Windows will then
      error on the unlink() call with a "Permission denied" error.
      
      The consequences of ignoring these errors is that we leave an unused
      file around on the file-system, which is an easier way to fix this
      problem right now than refactoring networkstatus_set_current_consensus().
      
      See: https://bugs.torproject.org/29930
      04290724
  13. 23 Apr, 2019 1 commit
  14. 22 Apr, 2019 1 commit
  15. 17 Apr, 2019 1 commit
  16. 15 Apr, 2019 1 commit
    • Nick Mathewson's avatar
      Use a tor_abort_() wrapper in our util_bug.h macros · 802ac8ad
      Nick Mathewson authored
      Previously, our use of abort() would break anywhere that we didn't
      include stdlib.h.  This was especially troublesome in case where
      tor_assert_nonfatal() was used with ALL_BUGS_ARE_FATAL, since that
      one seldom gets tested.
      
      As an alternative, we could have just made this header include
      stdlib.h.  But that seems bloaty.
      
      Fixes bug 30189; bugfix on 0.3.4.1-alpha.
      802ac8ad
  17. 12 Apr, 2019 1 commit
  18. 10 Apr, 2019 3 commits
  19. 09 Apr, 2019 2 commits
  20. 08 Apr, 2019 1 commit
    • Nick Mathewson's avatar
      Detect and suppress an additional gmtime() warning in test_util.c · a63bd877
      Nick Mathewson authored
      Fixes bug 29922; bugfix on 0.2.9.3-alpha when we tried to capture
      all these warnings.  No need to backport any farther than 0.3.5,
      though -- these warnings don't cause test failures before then.
      
      This one was tricky to find because apparently it only happened on
      _some_ windows builds.
      a63bd877
  21. 06 Apr, 2019 3 commits
  22. 05 Apr, 2019 2 commits
  23. 04 Apr, 2019 3 commits
  24. 03 Apr, 2019 4 commits
    • Nick Mathewson's avatar
      Improve logging for 28614. · 5613968d
      Nick Mathewson authored
      When we fixed 28614, our answer was "if we failed to load the
      consensus on windows and it had a CRLF, retry it."  But we logged
      the failure at "warn", and we only logged the retry at "info".
      
      Now we log the retry at "notice", with more useful information.
      
      Fixes bug 30004.
      5613968d
    • Nick Mathewson's avatar
      Even more diagnostic messages for bug 28223. · 99b87d7c
      Nick Mathewson authored
      Try to figure out _where exactly_ we are first encountering NULs in
      microdescriptors, and what we are doing when that happens.
      99b87d7c
    • Nick Mathewson's avatar
      30001: Fix a race condition in test_dir_handle_get.c · 367dd9cf
      Nick Mathewson authored
      Previously we used time(NULL) to set the Expires: header in our HTTP
      responses.  This made the actual contents of that header untestable,
      since the unit tests have no good way to override time(), or to see
      what time() was at the exact moment of the call to time() in
      dircache.c.
      
      This gave us a race in dir_handle_get/status_vote_next_bandwidth,
      where the time() call in dircache.c got one value, and the call in
      the tests got another value.
      
      I'm applying our regular solution here: using approx_time() so that
      the value stays the same between the code and the test.  Since
      approx_time() is updated on every event callback, we shouldn't be
      losing any accuracy here.
      
      Fixes bug 30001. Bug introduced in fb4a40c3; not in any
      released Tor.
      367dd9cf
    • Karsten Loesing's avatar
      54e249e2
  25. 01 Apr, 2019 2 commits