George Kadianakis authored Feb 11, 2020 and Nick Mathewson committed Mar 17, 2020

This unittest currently fails on purpose (to demonstrate the bug) but it will
stop failing after the next commit (the bugfix).

George Kadianakis authored Feb 11, 2020 and Nick Mathewson committed Mar 17, 2020

Given that ed25519 public key validity checks are usually not needed
and (so far) they are only necessary for onion addesses in the Tor
protocol, we decided to fix this specific bug instance without
modifying the rest of the codebase (see below for other fix
approaches).

In our minimal fix we check that the pubkey in
hs_service_add_ephemeral() is valid and error out otherwise.

In the openssl that I have, it should be safe to only check the size
of n.  But if I'm wrong, or if other openssls work differently, we
should check whether any of the fields are too large.

Issue spotted by Teor.

We've successfully resolved a bunch of technical debt over the last
few months. Let's remove the allowances for that debt from the
practracker exceptions.

rl1987 authored Mar 14, 2020 and teor committed Mar 17, 2020

This makes it not fail when ALL_BUGS_ARE_FATAL is enabled. Fixes bug 33546.

rl1987 authored Mar 13, 2020 and teor committed Mar 17, 2020

This option enables the ALL_BUGS_ARE_FATAL macro.

And use --enable-all-bugs-are-fatal in the Travis configuration.