1. 15 Oct, 2020 1 commit
  2. 13 Oct, 2020 2 commits
  3. 07 Oct, 2020 4 commits
  4. 06 Oct, 2020 5 commits
    • Alexander Færøy's avatar
      Expose TOR_PT_OUTBOUND_BIND_ADDRESS_{V4,V6} to Pluggable Transports. · 5f61e19d
      Alexander Færøy authored and David Goulet's avatar David Goulet committed
      This patch adds support for exposing the environment variables
      `TOR_PT_OUTBOUND_BIND_ADDRESS_V4` and `TOR_PT_OUTBOUND_BIND_ADDRESS_V6` to
      Pluggable Transport proccesses. These two values will contain the IPv4
      and IPv6 address that the user have specified in torrc that they wish
      the PT to use for all outgoing IP packets.
      
      It is important to note here that it is up to the indvidual Pluggable
      Transport if they are willing to honor these values or ignore them
      completely.
      
      One can test this feature using the following dummy PT written in POSIX
      shell script:
      
          #!/bin/sh
      
          echo "LOG SEVERITY=warning MESSAGE=\"Value for IPv4: ${TOR_PT_OUTBOUND_BIND_ADDRESS_V4}\""
          echo "LOG SEVERITY=warning MESSAGE=\"Value for IPv6: ${TOR_PT_OUTBOUND_BIND_ADDRESS_V6}\""
      
          while true ; do
              sleep 1
          done
      
      with the following entries in your torrc:
      
          OutboundBindAddressPT 203.0.113.4
          OutboundBindAddress 203.0.113.5
          OutboundBindAddressPT 2001:db8::4
          OutboundBindAddress 2001:db8::5
      
      See: https://bugs.torproject.org/5304
      5f61e19d
    • Alexander Færøy's avatar
      Move parse logic for outbound addresses to before we handle PT's. · 69c1a4eb
      Alexander Færøy authored and David Goulet's avatar David Goulet committed
      This patch moves the logic for handling outbound addresses in torrc to
      before we handle pluggable transports. Since we need access to the
      values in OutboundBindAddress and friends for #5304 we have to parse
      these values before we spawn any PT's.
      
      This commit is code movement only.
      
      See: https://bugs.torproject.org/5304
      69c1a4eb
    • Alexander Færøy's avatar
      Rename `OUTBOUND_ADDR_EXIT_AND_OR` to `OUTBOUND_ADDR_ANY`. · ad087432
      Alexander Færøy authored and David Goulet's avatar David Goulet committed
      This patch renames the enumeration value in `outbound_addr_t` from
      `OUTBOUND_ADDR_EXIT_AND_OR` to `OUTBOUND_ADDR_ANY` since with the
      arrival of `OUTBOUND_ADDR_PT` it no longer makes sense to call the
      fallback value for "Exit and OR". Instead we rename it to "any".
      
      See: https://bugs.torproject.org/5304
      ad087432
    • Alexander Færøy's avatar
      Add `OutboundBindAddressPT` to torrc. · db0aaf42
      Alexander Færøy authored and David Goulet's avatar David Goulet committed
      This patch adds a new option to torrc: `OutboundBindAddressPT`. This
      option works in the same way as `OutboundBindAddressOR` and
      `OutboundBindAddressExit` in that it allows the user to specify which
      outbound IP address the user wants the PT to make its connections from.
      
      There is one difference though in that OutboundBindAddressPT will only
      be a suggestion for the PT to use since Tor cannot enforce whether or
      not the PT actually uses this option for anything.
      
      See: https://bugs.torproject.org/5304
      db0aaf42
    • Alexander Færøy's avatar
      Document enumeration values for `outbound_addr_t`. · 25bffccd
      Alexander Færøy authored and David Goulet's avatar David Goulet committed
      This patch adds doxygen documentation strings for each of the values in
      `outbound_addr_t`.
      
      See: https://bugs.torproject.org/5304
      25bffccd
  5. 03 Oct, 2020 1 commit
  6. 01 Oct, 2020 1 commit
  7. 28 Sep, 2020 1 commit
  8. 23 Sep, 2020 12 commits
  9. 22 Sep, 2020 2 commits
  10. 17 Sep, 2020 6 commits
    • Nick Mathewson's avatar
      Fix underflow in rend_cache/free_all test. · 7945e075
      Nick Mathewson authored
      We already fixed these in #40099 and #40125.
      
      This patch fixes #40126.  Bugfix on 0.2.8.1-alpha.
      7945e075
    • David Goulet's avatar
      test: Increment rend cache allocation before freeing · 47f1d19f
      David Goulet authored
      The rend_cache/entry_free was missing the rend cache allocation increment
      before freeing the object.
      
      Without it, it had an underflow bug:
      
        Sep 17 08:40:13.845 [warn] rend_cache_decrement_allocation(): Bug: Underflow
        in rend_cache_decrement_allocation (on Tor 0.4.5.0-alpha-dev
        7eef9ced
      
      )
      
      Fixes #40125
      
      Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
      47f1d19f
    • Nick Mathewson's avatar
      Resolve some coverity complaints in test_util_glob(). · 4e8cb410
      Nick Mathewson authored and David Goulet's avatar David Goulet committed
      Coverity's first complaint was that we didn't check the return
      values from chmod.  That's easily fixed.
      
      Coverity's second complaint was that there were code paths where we pass
      NULL to chmod.  For example, if this line failed, we'd "goto done",
      and then pass NULL to chmod.
        tt_ptr_op(dirname, OP_NE, NULL);
      
      Closes #40103.  Bug not in any released Tor.
      4e8cb410
    • Nick Mathewson's avatar
      Use the correct SIGNED_KEY_TYPE value for signing->link certs · 5d1d7afc
      Nick Mathewson authored
      Our code was using [01] as for the key type of signed->link certs,
      which was incorrect.  The value should be [03], to indicate that the
      value as the SHA256 of an x.509 cert.
      
      Fortunately, nothing cares about this value, so there shouldn't be
      compatibility issues.
      
      Fixes bug 40124; bugfix on 0.2.7.2-alpha.
      5d1d7afc
    • Nick Mathewson's avatar
      Fix wide lines · 22643272
      Nick Mathewson authored
      22643272
    • Nick Mathewson's avatar
      Rename tor_cert_create to tor_cert_create_ed25519 · c92e1926
      Nick Mathewson authored
      This is an automated commit, generated by this command:
      
      ./scripts/maint/rename_c_identifier.py \
              tor_cert_create tor_cert_create_ed25519
      
      It was generated with --no-verify, so it probably breaks some commit hooks.
      The commiter should be sure to fix them up in a subsequent commit.
      c92e1926
  11. 15 Sep, 2020 1 commit
  12. 14 Sep, 2020 3 commits
  13. 10 Sep, 2020 1 commit