1. 16 Mar, 2021 3 commits
  2. 15 Mar, 2021 11 commits
  3. 12 Mar, 2021 6 commits
  4. 01 Mar, 2021 1 commit
  5. 23 Feb, 2021 2 commits
  6. 19 Feb, 2021 1 commit
    • Nick Mathewson's avatar
      Disable the dump_desc() function. · ede88c37
      Nick Mathewson authored
      It can be called with strings that should have been
      length-delimited, but which in fact are not.  This can cause a
      CPU-DoS bug or, in a worse case, a crash.
      Since this function isn't essential, the best solution for older
      Tors is to just turn it off.
      Fixes bug 40286; bugfix on when dump_desc() was
  7. 05 Feb, 2021 6 commits
    • Alexander Færøy's avatar
      Delete changes/40241_v2 as it breaks CI. · 49c61c1b
      Alexander Færøy authored
      Unreviewed build fix. Discussed the cnage on IRC with Nick.
    • Alexander Færøy's avatar
      Fix CI build: practracker error in connection_edge.c, take two. · aa1a053d
      Alexander Færøy authored
      This was a bad copy and paste error from the previous commit which
      generated a duplicated entry error from practracker.
      Unreviewed build fix.
      See: tor#40275.
    • Alexander Færøy's avatar
      Fix CI build: practracker error in connection_edge.c. · 62b98716
      Alexander Færøy authored
      We solve this error by allowing the connection_exit_connect() function
      to be 130 lines long.
      Unreviewed build fix commit.
      See: tor#40275.
    • Alexander Færøy's avatar
      Fix Windows build. · af9107af
      Alexander Færøy authored
      While trying to resolve our CI issues, the Windows build broke with an
      unused function error:
         src/test/test_switch_id.c:37:1: error: ‘unprivileged_port_range_start’
         defined but not used [-Werror=unused-function]
      We solve this by moving the `#if !defined(_WIN32)` test above the
      `unprivileged_port_range_start()` function defintion such that it is
      included in its body.
      This is an unreviewed commit.
      See: tor#40275
    • Alexander Færøy's avatar
    • Alexander Færøy's avatar
      Only check for bindable ports if we are unsure if it will fail. · 67aefd55
      Alexander Færøy authored
      We currently assume that the only way for Tor to listen on ports in the
      privileged port range (1 to 1023), on Linux, is if we are granted the
      NET_BIND_SERVICE capability. Today on Linux, it's possible to specify
      the beginning of the unprivileged port range using a sysctl
      configuration option. Docker (and thus the CI service Tor uses) recently
      changed this sysctl value to 0, which causes our tests to fail as they
      assume that we should NOT be able to bind to a privileged port *without*
      the NET_BIND_SERVICE capability.
      In this patch, we read the value of the sysctl value via the /proc/sys/
      filesystem iff it's present, otherwise we assume the default
      unprivileged port range begins at port 1024.
      See: tor#40275
  8. 03 Feb, 2021 10 commits