David Goulet authored Apr 07, 2020 and teor committed Apr 09, 2020

This change broke torsocks that by default is expecting an IPv4 for hostname
resolution because it can't ask tor for a specific IP version with the SOCKS5
extension.

PreferIPv6 made it that sometimes the IPv6 could be returned to torsocks that
was expecting an IPv4.

Torsocks is probably a very unique case because the runtime flow is that it
hijacks DNS resolution (ex: getaddrinfo()), gets an IP and then sends it back
for the connect() to happen.

The libc has DNS resolution functions that allows the caller to request a
specific INET family but torsocks can't tell tor to resolve the hostname only
to an IPv4 or IPv6 and thus by default fallsback to IPv4.

Reverting this change into 0.4.3.x series but we'll keep it in the 0.4.4.x
series in the hope that we add this SOCKS5 extension to tor for DNS resolution
and then change torsocks to use that.

Fixes #33804
Signed-off-by: David Goulet <dgoulet@torproject.org>

The default value of the option is "auto", not "default".

"proceeding" means starting an action.
"preceding" means the thing before this thing.

In this context, it's a bit ambiguous.

Avoid conflicts between the fake sockets in tor's unit tests, and real
file descriptors. Resolves issues running unit tests with GitHub
Actions, where the process that embeds or launches the tests has
already opened a large number of file descriptors.

Fixes bug 33782; bugfix on 0.2.8.1-alpha.

Found and fixed by Putta Khunchalee.

Obviously correct documentation changes.

David Goulet authored Mar 31, 2020 and teor committed Apr 01, 2020

Fixes #33646
Signed-off-by: David Goulet <dgoulet@torproject.org>

George Kadianakis authored Mar 11, 2020 and David Goulet committed Mar 30, 2020

Make it LOG_PROTOCOL_WARN and also add the expiration timestamp in there to
ease debugging in the future.

teor authored Mar 20, 2020 and Nick Mathewson committed Mar 20, 2020

And document how some functions set their output arguments.

Fixes bug 33674; bugfix on 0.4.3.1-alpha.

Previously we just ignored this option, which would leave it unset,
and cause an assertion failure later on when running with the User
option.

Fixes bug 33668; bugfix on 0.4.3.1-alpha.

Disable our coding standards best practices tracker in our git hooks.

0.4.3 branches only.

Closes ticket 33678.

Obviously correct changes to already-reviewed code.

Merge duplicate DLL copies from maint-0.4.1 with bug33673_035.

Copy required DLLs to test and app, before running tor's tests.

This ensures that tor.exe and test*.exe use the correct version of each
DLL. This fix is not required, but we hope it will avoid DLL search
issues in future.

Closes bug 33673; bugfix on 0.3.4.2-alpha.

For example, "TOR_SKIP_TESTCASES=crypto/.. ./src/test/test" will run
the tests and suppress all the "crypto/" tests.  You could get the
same effect by running "./src/test/test :crypto/..", but that can be
harder to arrange from CI.

Part of a fix/workaround for 33643.

And consistently talk about extra-info document publishing.

Obviously correct documentation changes.

Obviously correct changes to already-reviewed code.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.