This commit adds a pretty advanced test for the client-side making sure that
picking intro is done properly.

This unittest also reveals a memleak on the client_pick_intro() function which
is fixed by the subsequent commit.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Alexander Færøy authored Jun 05, 2017 and Nick Mathewson committed Aug 24, 2017

This patch fixes the operator usage in src/test/*.c to use the symbolic
operators instead of the normal C comparison operators.

This patch was generated using:

    ./scripts/coccinelle/test-operator-cleanup src/test/*.[ch]

George Kadianakis authored Jul 06, 2017 and Nick Mathewson committed Jul 07, 2017

Had to also edit hs_ntor_circuit_key_expansion() to make it happen.