Avoid nop call to control_event_or_authdir_new_descriptor that makes coverity think we are dereferencing a null pointer.  It is safe, I think, but entirely too clever for our own good.

svn:r17668

svn:r17667

Fix memory leak in rend_cache_store_v2_desc_as_client(), and refactor the function to use the "goto err" idiom.

svn:r17665

svn:r17664

svn:r17663

svn:r17662

(Many users have no idea what a resolv.conf is, and shouldn't be forced to learn.  The old option will keep working for now.)
Also, document it.

svn:r17661

svn:r17659

seconds. Warn the user if lower values are given in the
configuration. Bugfix on 0.1.0.1-rc. Patch by Sebastian.
Clip the CircuitBuildTimeout to a minimum of 30 seconds. Warn the
user if lower values are given in the configuration. Bugfix on
0.1.1.17-rc. Patch by Sebastian.


svn:r17657

Make return code from router_add_to_routerlist a nice sensible enum.  Based on patch from Sebastian.

svn:r17656

manpage: stop mentioning the possibility that Tor has been built without eventdns.  That hasn't been possible since 0.2.0.1-alpha

svn:r17655

svn:r17654

svn:r17652

Use ctags and a python script to find identifiers that are never used anywhere, and remove the ones that we really want gone.

svn:r17651

svn:r17650

svn:r17649

svn:r17648

svn:r17647

svn:r17646

svn:r17644

svn:r17643

svn:r17642

svn:r17630

Also, refactor the logic to check whether we will use a connection or
launch a new one into a new function.

svn:r17628

svn:r17627

"connecting" and it receives an "end" relay cell, the exit relay
would silently ignore the end cell and not close the stream. If
the client never closes the circuit, then the exit relay never
closes the TCP connection. Bug introduced in Tor 0.1.2.1-alpha;
reported by "wood".


svn:r17625

svn:r17624

svn:r17619

svn:r17614

svn:r17613

This patch makes every RELAY_COMMAND_END cell that we send pass through one of two functions: connection_edge_end and relay_send_end_cell_from_edge.  Both of these functions check the circuit purpose, and change the reason to MISC if the circuit purpose means that it's for client use.

svn:r17612

svn:r17611

svn:r17610

svn:r17609

svn:r17608

svn:r17604

svn:r17603

I'm hoping not to have to litter the rest of our codebase with Coverity ignores, but I think these are the only one we need right now.

svn:r17602

This makes sure that a) optional code gets analyzed too, and b) it doesn't
look like dead code to Coverity.

svn:r17601

Lower sprintf buffer max to ~SSIZE_T_MAX from SIZE_T_CEILING, since we need to compare it to a signed int.

svn:r17600