1. 06 Jan, 2020 1 commit
  2. 05 Jan, 2020 1 commit
  3. 15 Dec, 2019 1 commit
  4. 06 Dec, 2019 3 commits
  5. 03 Dec, 2019 1 commit
    • teor's avatar
      Travis: use -std=gnu99 in some jobs · 792c15fd
      teor authored
      Require C99 standards-conforming code in Travis CI, but allow GNU gcc
      extensions. Also activates clang's -Wtypedef-redefinition warnings.
      
      Builds some jobs with -std=gnu99, and some jobs without.
      
      Closes ticket 32500.
      792c15fd
  6. 28 Nov, 2019 1 commit
  7. 11 Nov, 2019 1 commit
    • teor's avatar
      Appveyor: Install OpenSSL to resolve a header/library mismatch · 2abff832
      teor authored
      Install the mingw OpenSSL package in Appveyor. This makes sure that
      the OpenSSL headers and libraries match in Tor's Appveyor builds.
      
      (This bug was triggered by an Appveyor image update.)
      
      Fixes bug 32449; bugfix on 0.3.5.6-rc.
      2abff832
  8. 09 Nov, 2019 1 commit
  9. 24 Oct, 2019 3 commits
  10. 23 Oct, 2019 1 commit
  11. 22 Oct, 2019 2 commits
  12. 21 Oct, 2019 1 commit
    • Roger Dingledine's avatar
      respect accountingmax during soft hibernation · a7ccd9a9
      Roger Dingledine authored
      Relays now respect their AccountingMax bandwidth again. When relays
      entered "soft" hibernation (which typically starts when we've hit
      90% of our AccountingMax), we had stopped checking whether we should
      enter hard hibernation. Soft hibernation refuses new connections and
      new circuits, but the existing circuits can continue, meaning that
      relays could have exceeded their configured AccountingMax.
      
      This commit rolls back some of the cpu-saving fixes, where we tried
      to avoid calling so many of our events while we're off the network.
      
      That's because PERIODIC_EVENT_FLAG_NEED_NET checks net_is_disabled(),
      which returns true even if we're only in soft hibernation.
      
      Fixes bug 32108; bugfix on 0.4.0.1-alpha.
      a7ccd9a9
  13. 20 Oct, 2019 2 commits
    • teor's avatar
      Appveyor: Use Windows Server 2019 · f420b60c
      teor authored
      Instead of Windows Server 2016.
      
      Closes ticket 32086.
      f420b60c
    • teor's avatar
      test/rebind: Make control formatting and log parsing more robust · cf2b00d3
      teor authored
      * actually sleep when tor has not logged anything
      * log at debug level when waiting for tor to log something
      * backslash-replace bad UTF-8 characters in logs
      * format control messages as ASCII: tor does not accept UTF-8 control commands
      
      Fixes bug 31837; bugfix on 0.3.5.1-alpha.
      cf2b00d3
  14. 17 Oct, 2019 3 commits
  15. 09 Oct, 2019 1 commit
  16. 07 Oct, 2019 1 commit
    • David Goulet's avatar
      hs-v3: Make service pick the exact amount of intro points · 984a28f3
      David Goulet authored and Nick Mathewson's avatar Nick Mathewson committed
      
      
      When encoding introduction points, we were not checking if that intro points
      had an established circuit.
      
      When botting up, the service will pick, by default, 3 + 2 intro points and the
      first 3 that establish, we use them and upload the descriptor.
      
      However, the intro point is removed from the service descriptor list only when
      the circuit has opened and we see that we have already enough intro points, it
      is then removed.
      
      But it is possible that the service establishes 3 intro points successfully
      before the other(s) have even opened yet.
      
      This lead to the service encoding extra intro points in the descriptor even
      though the circuit is not opened or might never establish (#31561).
      
      Fixes #31548
      
      Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
      984a28f3
  17. 04 Oct, 2019 1 commit
  18. 02 Oct, 2019 1 commit
  19. 01 Oct, 2019 1 commit
    • Nick Mathewson's avatar
      Fix a crash bug in max_u16_in_sl() · 2b825a1a
      Nick Mathewson authored
      The documentation for this function says that the smartlist can
      contain NULLs, but the code only handled NULLs if they were at the
      start of the list.
      
      We didn't notice this for a long time, because when Tor is run
      normally, the sequence of msg_id_t is densely packed, and so this
      list (mapping msg_id_t to channel_id_t) contains no NULL elements.
      We could only run into this bug:
        * when Tor was running in embedded mode, and starting more than once.
        * when Tor ran first with more pubsub messages enabled, and then
          later with fewer.
        * When the second run (the one with fewer enabled pubsub messages)
          had at least some messages enabled, and those messages were not
          the ones with numerically highest msg_id_t values.
      
      Fixes bug 31898; bugfix on 47de9c7b
      in 0.4.1.1-alpha.
      2b825a1a
  20. 30 Sep, 2019 4 commits
    • teor's avatar
      Travis: Add a macOS chutney job, but don't wait for it to finish · 1e0e23c1
      teor authored
      Since Travis macOS has IPv6 support (and Travis Linux does not), chutney
      will now run its IPv6 networks as part of Travis CI.
      
      But since chutney is slow, don't wait for the macOS chutney to finish.
      (Travis have fixed the duplicate notification bug in fast_finish. So we
      can use fast_finish and allow_failure to finish early. Unfortunately,
      allow_failure also means we ignore failures in macOS chutney.)
      
      Also make sure that we have:
      * a compile on each platform, with each compiler,
      * a check on each platform, and
      * a check on each compiler.
      
      Finally, sort builds: allow fail last, macOS first, slowest first.
      
      Closes ticket 30860.
      Closes ticket 31859 for 0.2.9.
      1e0e23c1
    • teor's avatar
      Travis: Remove a redundant clang Linux job · 4e429783
      teor authored
      Part of 31859.
      4e429783
    • teor's avatar
      Appveyor: Avoid spurious errors in Appveyor CI builds · b1864187
      teor authored
      When Appveyor fails before the install step, some of the finish step's
      functions were not defined.
      
      Fixes bug 31884; bugfix on 0.3.4.2-alpha.
      b1864187
    • teor's avatar
      test: Avoid a map_anon_nofork test failure on SunOS · 2420c8c9
      teor authored
      This test failure happened due to a signed/unsigned integer
      comparison.
      
      This bug occurred on SunOS, it may also occur on other systems that
      use signed char as the default. (And cast 1-byte integer constants
      to an unsigned integer.)
      
      Fixes bug 31897; bugfix on 0.4.1.1-alpha.
      2420c8c9
  21. 26 Sep, 2019 2 commits
  22. 24 Sep, 2019 1 commit
  23. 23 Sep, 2019 3 commits
    • Nick Mathewson's avatar
      Try using make -k in the Appveyor configuration · 49a11f8a
      Nick Mathewson authored
      Frequently, when a patch fails, it has failures in several files.
      Using the "-k" flag will let us learn all the compilation errors,
      not just the first one that the compiler hits.
      
      Based on a patch by rl1987.
      
      Closes ticket 31372.
      49a11f8a
    • Nick Mathewson's avatar
      Try using make -k in Travis configuration · 6ed3d8db
      Nick Mathewson authored
      Frequently, when a patch fails, it has failures in several files.
      Using the "-k" flag will let us learn all the compilation errors,
      not just the first one that the compiler hits.
      
      Based on a patch by rl1987.
      6ed3d8db
    • Jigsaw52's avatar
      Fix bug when %including folder with comment only files. #31408 · 15490816
      Jigsaw52 authored and teor's avatar teor committed
      When processing a %included folder, a bug caused the pointer to
      the last element of the options list to be set to NULL when
      processing a file with only comments or whitepace. This could
      cause options from other files on the same folder to be
      discarded depending on the lines after the affected %include.
      15490816
  24. 18 Sep, 2019 2 commits
    • Nick Mathewson's avatar
      Add a rate-limit to our warning about the disabled .exit notation · f0e41209
      Nick Mathewson authored
      This warning would previously be given every time we tried to open a
      connection to a foo.exit address, which could potentially be used to
      flood the logs.  Now, we don't allow this warning to appear more
      than once every 15 minutes.
      
      Fixes bug 31466; bugfix on 0.2.2.1-alpha, when .exit was first
      deprecated.
      f0e41209
    • Nick Mathewson's avatar
      Avoid a crash if our "current" and "old" ntor onion keys are equal · 2da4d64a
      Nick Mathewson authored
      Our dimap code asserts if you try to add the same key twice; this
      can't happen if everything is running smoothly, but it's possible if
      you try to start a relay where secret_onion_key_ntor is the same as
      secret_onion_key_ntor.old.
      
      Fixes bug 30916; bugfix on 0.2.4.8-alpha when ntor keys were
      introduced.
      2da4d64a
  25. 17 Sep, 2019 1 commit