GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

config: Really ignore non ORPorts when removing duplicates

The function in charge of removing duplicate ORPorts from our configured ports
was skipping all non ORPorts port but only for the outer loop thus resulting
in comparing an ORPort with a non-ORPort which lead to problems.

For example, tor configured with the following would fail:

  ORPort auto
  DirPort auto

Both end up being the same configuration except that one is a OR listener and
one is a Dir listener. Thus because of the missing check in the inner loop,
they looked exactly the same and thus one is removed.

Fixes #40195

Signed-off-by: David Goulet <dgoulet@torproject.org>
9 jobs for ticket40195_045_01 in 89 minutes and 50 seconds (queued for 2 minutes and 5 seconds)
latest
Status Job ID Name Coverage
  Test
passed #5758
debian-disable-dirauth

00:08:32

passed #5759
debian-disable-relay

00:11:44

passed #5754
debian-distcheck

00:15:43

passed #5755
debian-docs

00:07:32

passed #5753
debian-hardened

00:11:19

passed #5756
debian-integration

00:13:49

passed #5752
debian-minimal

00:06:49

passed #5760
debian-nss

00:06:13

passed #5757
debian-tracing

00:08:04