GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

configure: Revert back the static libevent path

From c618c4f2, we changed the static
libevent.a path to be able to use the git repository or tarball directly but
that broke the "make install" setup that Tor Browser is using with Android.

In other words, the git repository and tarball put the "libevent.a" in
".libs/" where "make install" puts it in "lib/".

Using the --with-libevent-dir=..., which is mandatory for static libevent,
autoconf will take the path and use it for the includes (-I) and library (-L)
for which if it finds a "include/" and a "lib/" in the root, it will use
those.

However, with the git repo or tarball, the "lib/" doesn't exists thus autoconf
sets the library search path to be at the root and thus fails to find the
libevent.a in ".libs/".

This is a whole lot more work to make both cases work in our configure.ac thus
I'm reverting the change here to the Tor Browser case works again and the work
around for others is to either symlink the libevent.a at the root or use a
temporary make install directory.

One long term fix here would likely be to ask libevent to symblink the .a into
the root along the .la files and likely do the same for .so. Or, use the
"lib/" structure to contain the .a + .so files. Would be better than doing
ninji-tsu in our configure.ac

Fixes #40225

Signed-off-by: David Goulet <dgoulet@torproject.org>
9 jobs for ticket40225_045_01 in 62 minutes and 49 seconds (queued for 8 minutes and 45 seconds)
latest
Status Job ID Name Coverage
  Test
passed #7050
debian-disable-dirauth

00:10:16

passed #7051
debian-disable-relay

00:05:23

passed #7046
debian-distcheck

00:07:04

passed #7047
debian-docs

00:08:14

failed #7045
debian-hardened

00:06:02

passed #7048
debian-integration

00:20:13

passed #7044
debian-minimal

00:05:40

passed #7052
debian-nss

00:05:18

passed #7049
debian-tracing

00:07:20

 
Name Stage Failure
failed
debian-hardened Test
make[1]: Leaving directory '/builds/dgoulet/tor/build'
make: *** [Makefile:7343: all] Error 2
ERROR: command 'make -j4 -k all' has failed.
Uploading artifacts for failed job
Uploading artifacts...
artifacts/: found 1 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=7045 responseStatus=201 Created token=kTL7YXPi
Cleaning up file based variables
ERROR: Job failed: exit code 1