GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

relay: Don't look at omit flag when building descriptor

That comes from 685c4866 which added that
check correctly except for when we build a descriptor.

We already omit the IPv6 address, if we need to, when we encode the descriptor
but we need to keep the actual discovered address in the descriptor so we can
notice future IP changes and be able to assess that we are not publishable as
long as we don't specifically set the omit flag.

This lead to also having tor noticing that our IP changed from <nothing> (no
IPv6 in the descriptor) to a discovered one which would trigger every minute.

Fixes #40279, #40288

Signed-off-by: David Goulet <dgoulet@torproject.org>
9 jobs for ticket40279_045_02 in 15 minutes and 53 seconds (queued for 2 seconds)
latest
Status Job ID Name Coverage
  Test
passed #11557
debian-disable-dirauth

00:05:44

passed #11558
debian-disable-relay

00:05:57

passed #11553
debian-distcheck

00:07:53

passed #11554
debian-docs

00:02:53

passed #11552
debian-hardened

00:07:47

passed #11555
debian-integration

00:13:56

passed #11551
debian-minimal

00:06:21

passed #11559
debian-nss

00:05:50

passed #11556
debian-tracing

00:08:27