GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

conn: Remove assert on new listener connection when retrying

Opening a new listener connection can fail in many ways like a bind()
permission denied on a low port for instance.

And thus, we should expect to handle an error when creating a new one instead
of assert() on it.

To hit the removed assert:

  ORPort 80
  KeepBindCapabilities 0

Start tor. Then edit torrc:

  ORPort <some-IP>:80

HUP tor and the assert is hit.

Fixes #40073

Signed-off-by: David Goulet <dgoulet@torproject.org>
5 jobs for ticket40073_035_01 in 18 minutes and 29 seconds (queued for 2 seconds)
latest
Status Job ID Name Coverage
  Test
passed #2052
debian-distcheck

00:06:19

passed #2053
debian-docs

00:03:39

passed #2051
debian-hardened

00:16:30

passed #2054
debian-integration

00:07:08

passed #2050
debian-minimal

00:05:15