Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Gaba
fenix
Commits
447ff44c
Unverified
Commit
447ff44c
authored
Aug 05, 2020
by
Matthew Finkel
Browse files
Bug 40016: Modify Default toolbar menu
parent
04dd3fd1
Changes
6
Hide whitespace changes
Inline
Side-by-side
app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
View file @
447ff44c
...
...
@@ -178,21 +178,18 @@ class DefaultToolbarMenu(
val
shouldDeleteDataOnQuit
=
context
.
components
.
settings
.
shouldDeleteBrowsingDataOnQuit
&&
!
context
.
components
.
settings
.
shouldDisableNormalMode
val
syncedTabsInTabsTray
=
context
.
components
.
settings
.
syncedTabsInTabsTray
val
menuItems
=
listOfNotNull
(
downloadsItem
,
historyItem
,
//
historyItem,
bookmarksItem
,
if
(
syncedTabsInTabsTray
)
null
else
syncedTabs
,
settings
,
if
(
shouldDeleteDataOnQuit
)
deleteDataOnQuit
else
null
,
BrowserMenuDivider
(),
findInPage
,
addToTopSites
,
addToHomescreen
.
apply
{
visible
=
::
canAddToHomescreen
},
installToHomescreen
.
apply
{
visible
=
::
canInstall
},
//
addToHomescreen.apply { visible = ::canAddToHomescreen },
//
installToHomescreen.apply { visible = ::canInstall },
if
(
shouldShowSaveToCollection
)
saveToCollection
else
null
,
desktopMode
,
openInApp
.
apply
{
visible
=
::
shouldShowOpenInApp
},
...
...
app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
View file @
447ff44c
...
...
@@ -104,7 +104,6 @@ import org.mozilla.fenix.home.sessioncontrol.viewholders.CollectionViewHolder
import
org.mozilla.fenix.home.sessioncontrol.viewholders.topsites.DefaultTopSitesView
import
org.mozilla.fenix.onboarding.FenixOnboarding
import
org.mozilla.fenix.settings.SupportUtils
import
org.mozilla.fenix.settings.SupportUtils.SumoTopic.HELP
import
org.mozilla.fenix.settings.deletebrowsingdata.deleteAndQuit
import
org.mozilla.fenix.theme.ThemeManager
import
org.mozilla.fenix.utils.FragmentPreDrawManager
...
...
@@ -802,7 +801,7 @@ class HomeFragment : Fragment() {
HomeMenu
.
Item
.
Help
->
{
hideOnboardingIfNeeded
()
(
activity
as
HomeActivity
).
openToBrowserAndLoad
(
searchTermOrURL
=
SupportUtils
.
get
SumoURLForTopic
(
context
,
HELP
),
searchTermOrURL
=
SupportUtils
.
get
TorHelpPageUrl
(
),
newTab
=
true
,
from
=
BrowserDirection
.
FromHome
)
...
...
app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt
View file @
447ff44c
...
...
@@ -240,10 +240,7 @@ class SettingsFragment : PreferenceFragmentCompat() {
}
resources
.
getString
(
R
.
string
.
pref_key_help
)
->
{
(
activity
as
HomeActivity
).
openToBrowserAndLoad
(
searchTermOrURL
=
SupportUtils
.
getSumoURLForTopic
(
requireContext
(),
SupportUtils
.
SumoTopic
.
HELP
),
searchTermOrURL
=
SupportUtils
.
getTorHelpPageUrl
(),
newTab
=
true
,
from
=
BrowserDirection
.
FromSettings
)
...
...
app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt
View file @
447ff44c
...
...
@@ -18,6 +18,7 @@ import java.io.UnsupportedEncodingException
import
java.net.URLEncoder
import
java.util.Locale
@Suppress
(
"TooManyFunctions"
)
object
SupportUtils
{
const
val
RATE_APP_URL
=
"market://details?id="
+
BuildConfig
.
APPLICATION_ID
const
val
POCKET_TRENDING_URL
=
"https://getpocket.com/fenix-top-articles"
...
...
@@ -26,6 +27,8 @@ object SupportUtils {
const
val
FIREFOX_BETA_PLAY_STORE_URL
=
"market://details?id=org.mozilla.firefox_beta"
const
val
FIREFOX_NIGHTLY_PLAY_STORE_URL
=
"market://details?id=org.mozilla.fenix"
const
val
GOOGLE_URL
=
"https://www.google.com/"
const
val
TB_MANUAL_URL
=
"https://tb-manual.torproject.org/mobile-tor"
const
val
TOR_RELEASES
=
"https://www.torproject.org/releases/"
enum
class
SumoTopic
(
internal
val
topicStr
:
String
)
{
FENIX_MOVING
(
"sync-delist"
),
...
...
@@ -77,13 +80,23 @@ object SupportUtils {
return
"https://support.mozilla.org/kb/access-mozilla-services-firefox-account"
}
fun
getTorHelpPageUrl
():
String
{
return
TB_MANUAL_URL
}
fun
getTorReleasePageUrl
():
String
{
return
TOR_RELEASES
}
fun
getMozillaPageUrl
(
page
:
MozillaPage
,
locale
:
Locale
=
Locale
.
getDefault
()):
String
{
val
path
=
page
.
path
val
langTag
=
getLanguageTag
(
locale
)
return
"https://www.mozilla.org/$langTag/$path"
}
fun
getWhatsNewUrl
(
context
:
Context
)
=
getSumoURLForTopic
(
context
,
SumoTopic
.
WHATS_NEW
)
fun
getWhatsNewUrl
(
@Suppress
(
"UNUSED_PARAMETER"
)
context
:
Context
):
String
{
return
getTorReleasePageUrl
()
}
fun
createCustomTabIntent
(
context
:
Context
,
url
:
String
):
Intent
=
CustomTabsIntent
.
Builder
()
.
setInstantAppsEnabled
(
false
)
...
...
app/src/main/java/org/mozilla/fenix/settings/about/AboutFragment.kt
View file @
447ff44c
...
...
@@ -138,7 +138,7 @@ class AboutFragment : Fragment(), AboutPageListener {
AboutPageItem
(
AboutItem
.
ExternalLink
(
SUPPORT
,
SupportUtils
.
get
SumoURLForTopic
(
context
,
SupportUtils
.
SumoTopic
.
HELP
)
SupportUtils
.
get
TorHelpPageUrl
(
)
),
getString
(
R
.
string
.
about_support
)
),
AboutPageItem
(
...
...
app/src/test/java/org/mozilla/fenix/settings/SupportUtilsTest.kt
View file @
447ff44c
...
...
@@ -55,6 +55,18 @@ class SupportUtilsTest {
)
}
@Test
fun
getTorPageUrl
()
{
assertEquals
(
"https://tb-manual.torproject.org/mobile-tor"
,
SupportUtils
.
getTorHelpPageUrl
()
)
assertEquals
(
"https://www.torproject.org/releases/"
,
SupportUtils
.
getTorReleasePageUrl
()
)
}
private
fun
mockContext
(
versionName
:
String
):
Context
{
val
context
:
Context
=
mockk
()
val
packageManager
:
PackageManager
=
mockk
()
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment