Unverified Commit 553b1ae4 authored by Johan Lorenzo's avatar Johan Lorenzo Committed by GitHub
Browse files

Bug 1627027 - part 2: Do not run perf tasks on Nd-gp graphs (#10681)

parent fee37e4f
...@@ -22,6 +22,7 @@ only-for-abis: ...@@ -22,6 +22,7 @@ only-for-abis:
job-defaults: job-defaults:
attributes: attributes:
artifact_prefix: public/test_info artifact_prefix: public/test_info
nightly: true
dependencies: dependencies:
geckoview-nightly: geckoview-nightly geckoview-nightly: geckoview-nightly
notify: notify:
......
...@@ -19,6 +19,7 @@ only-for-abis: ...@@ -19,6 +19,7 @@ only-for-abis:
job-defaults: job-defaults:
attributes: attributes:
nightly: true
retrigger: true retrigger: true
dependencies: dependencies:
geckoview-nightly: geckoview-nightly geckoview-nightly: geckoview-nightly
......
...@@ -22,6 +22,8 @@ transforms: ...@@ -22,6 +22,8 @@ transforms:
- taskgraph.transforms.task:transforms - taskgraph.transforms.task:transforms
job-template: job-template:
attributes:
nightly: true
description: "Run visual metrics calculations on Raptor" description: "Run visual metrics calculations on Raptor"
run-on-projects: [] run-on-projects: []
run-on-tasks-for: [] run-on-tasks-for: []
......
...@@ -33,8 +33,7 @@ def target_tasks_nightly(full_task_graph, parameters, graph_config): ...@@ -33,8 +33,7 @@ def target_tasks_nightly(full_task_graph, parameters, graph_config):
def filter(task, parameters): def filter(task, parameters):
# We don't want to ship nightly while Google Play is still behind manual review. # We don't want to ship nightly while Google Play is still behind manual review.
# See bug 1628413 for more context. # See bug 1628413 for more context.
return task.attributes.get("nightly", False) and task.kind != "push-apk" or \ return task.attributes.get("nightly", False) and task.kind != "push-apk"
task.kind in ('browsertime', 'visual-metrics', 'raptor')
return [l for l, t in full_task_graph.tasks.iteritems() if filter(t, parameters)] return [l for l, t in full_task_graph.tasks.iteritems() if filter(t, parameters)]
...@@ -44,7 +43,13 @@ def target_tasks_nightly_on_google_play(full_task_graph, parameters, graph_confi ...@@ -44,7 +43,13 @@ def target_tasks_nightly_on_google_play(full_task_graph, parameters, graph_confi
"""Select the set of tasks required for a nightly build that goes on Google Play.""" """Select the set of tasks required for a nightly build that goes on Google Play."""
def filter(task, parameters): def filter(task, parameters):
return task.attributes.get("nightly", False) return (
task.attributes.get("nightly", False) and
# This target_task is temporary while Google Play processes APKs slower than usually
# (bug 1628413). So we want this target task to be only about shipping APKs to GP and
# not doing any other miscellaneous tasks like performance testing
task.kind not in ("browsertime", "visual-metrics", "raptor")
)
return [l for l, t in full_task_graph.tasks.iteritems() if filter(t, parameters)] return [l for l, t in full_task_graph.tasks.iteritems() if filter(t, parameters)]
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment