Commit 66d9a24b authored by ekager's avatar ekager Committed by Mihai Adrian
Browse files

Closes #9928 - Updates private browsing text description

parent 5d51c4f0

app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt

+4 −4
Original line number Diff line number Diff line
@@ -552,10 +552,10 @@ private fun assertPrivateSessionHeader() = 
    onView(allOf(withText("Private tabs")))

        .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))



const val PRIVATE_SESSION_MESSAGE = "Firefox Preview clears your search and browsing history " +

        "when you quit the app or close all private tabs. While this doesn’t make you anonymous to websites or " +

        "your internet service provider, it makes it easier to keep what you do online private from anyone else " +

        "who uses this device."

const val PRIVATE_SESSION_MESSAGE =

    "Firefox Preview clears your search and browsing history from private tabs when you close them or quit the app." +

            " While this doesn't make you anonymous to websites or your internet service provider," +

            " it makes it easier to keep what you do online from anyone else who uses this device."



private fun assertPrivateSessionMessage(visible: Boolean) =

    onView(allOf(withText(PRIVATE_SESSION_MESSAGE)))

app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/PrivateBrowsingDescriptionViewHolder.kt

+1 −1
Original line number Diff line number Diff line
@@ -22,7 +22,7 @@ class PrivateBrowsingDescriptionViewHolder( 
        val resources = view.context.resources

        val appName = resources.getString(R.string.app_name)

        view.private_session_description.text = resources.getString(

            R.string.private_browsing_placeholder_description, appName

            R.string.private_browsing_placeholder_description_2, appName

        )

        val commonMythsText = view.private_session_common_myths.text.toString()

        val textWithLink = SpannableString(commonMythsText).apply {

app/src/main/res/layout/private_browsing_description.xml

+1 −1
Original line number Diff line number Diff line
@@ -19,7 +19,7 @@ 
            android:lineSpacingExtra="6dp"

            android:gravity="center_vertical"

            android:scrollHorizontally="false"

            tools:text="@string/private_browsing_placeholder_description"

            tools:text="@string/private_browsing_placeholder_description_2"

            android:textColor="?primaryText"

            android:textSize="14sp" />

    <TextView

app/src/main/res/values/strings.xml

+2 −3
Original line number Diff line number Diff line
@@ -28,9 +28,8 @@ 
    <string name="private_browsing_title">You’re in a private session</string>

    <!-- Explanation for private browsing displayed to users on home view when they first enable private mode

        The first parameter is the name of the app defined in app_name (for example: Fenix) -->

    <string name="private_browsing_placeholder_description">

         %1$s clears your search and browsing history when you quit the app or close all private tabs. While this doesn’t make you anonymous to websites or your internet service provider, it makes it

        easier to keep what you do online private from anyone else who uses this device.

    <string name="private_browsing_placeholder_description_2">

         %1$s clears your search and browsing history from private tabs when you close them or quit the app. While this doesn\'t make you anonymous to websites or your internet service provider, it makes it easier to keep what you do online from anyone else who uses this device.

    </string>

    <string name="private_browsing_common_myths">

       Common myths about private browsing