Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Gaba
fenix
Commits
f3ed207b
Commit
f3ed207b
authored
Apr 15, 2020
by
Michael Comella
Committed by
Michael Comella
Apr 17, 2020
Browse files
For #8803 - review: Add clarifying comments to onAppInit capture methods.
parent
2888d66c
Changes
2
Hide whitespace changes
Inline
Side-by-side
app/src/main/java/org/mozilla/fenix/FenixApplication.kt
View file @
f3ed207b
...
...
@@ -374,6 +374,8 @@ open class FenixApplication : LocaleAwareApplication() {
protected
fun
recordOnInit
()
{
// This gets called by more than one process. Ideally we'd only run this in the main process
// but the code to check which process we're in crashes because the Context isn't valid yet.
StartupTimeline
.
onApplicationInit
()
//
// This method is not covered by our internal crash reporting: be very careful when modifying it.
StartupTimeline
.
onApplicationInit
()
// DO NOT MOVE ANYTHING ABOVE HERE: the timing is critical.
}
}
app/src/main/java/org/mozilla/fenix/perf/StartupTimeline.kt
View file @
f3ed207b
...
...
@@ -46,6 +46,8 @@ object StartupTimeline {
fun
onApplicationInit
()
{
// This gets called from multiple processes: don't do anything expensive. See call site for details.
//
// This method also gets called multiple times if there are multiple Application implementations.
frameworkStartMeasurement
.
onApplicationInit
()
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment