- 18 Oct, 2019 1 commit
-
-
Johan Lorenzo authored
-
- 17 Oct, 2019 4 commits
-
-
MozLando authored
6038: ExtTest for BookmarkNode r=mcomella a=kglazko Co-authored-by:
Kate Glazko <katglazko@gmail.com>
-
Kate Glazko authored
-
MozLando authored
6021: Expose PR number to ui-test r=mitchhentges a=JohanLorenzo Co-authored-by:
Johan Lorenzo <jlorenzo@mozilla.com>
-
Johan Lorenzo authored
-
- 16 Oct, 2019 2 commits
-
-
MozLando authored
6026: For #5709: Align ETP onboarding popup implementation with original mocks r=ekager a=mcarare Co-authored-by:
mcarare <mihai.carare.dev@gmail.com>
-
MozLando authored
6024: For #5749 - Update string for ETP onboarding popup r=ekager a=BranescuMihai Co-authored-by:
Mihai Branescu <branescu.mihai2@gmail.com>
-
- 15 Oct, 2019 7 commits
-
-
MozLando authored
6025: For #5063: Added parameter customTabSessionId into ContextMenuFeature r=ekager a=ValentinTimisica Added parameter customTabSessionId into ContextMenuFeature in BaseBrowserFragment in order to show the context menu in a custom tab. 6032: For #5990: Revert sessionTokenScope to fix broken QR pairing flow r=ekager a=grigoryk Seems like addition of sessionTokenScope is causing issues with pairing. For now, we can revert that change until the underlying issue is fixed. For #5990. Co-authored-by:
ValentinTimisica <valentin.timisica@softvision.ro> Co-authored-by:
Grisha Kruglov <gkruglov@mozilla.com>
-
MozLando authored
5974: Ext Test For ImageButton r=mcomella a=kglazko Co-authored-by:
Kate Glazko <katglazko@gmail.com>
-
Grisha Kruglov authored
-
mcarare authored
-
ValentinTimisica authored
Added parameter customTabSessionId into ContextMenuFeature in BaseBrowserFragment in order to show the context menu in a custom tab.
-
Mihai Branescu authored
-
MozLando authored
5949: Import strings from android-l10n r=liuche a=mozilla-l10n-automation-bot n/t Co-authored-by:
Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
-
- 14 Oct, 2019 16 commits
-
-
MozLando authored
5775: Closes #5233, don't display private-browsing-shortcut creation items if shortcut already exists r=NotWoods a=bswe Closes issue #5233: Added doesPrivateBrowsingPinnedShortcutExist() method to the PrivateShortcutCreateManager class to check for the existence of the shortcut. Code only works on devices with API 25 or higher, so a check for that condition was also included in the new method. Calls to the new method were added to the SettingsFragment and HomeFragment classes to determine whether the settings menu item and the recommendation dialog should be displayed. **Quality**: The pre-push test failed to start on my windows 10 OS, but this code has been thoroughly tested manually on simulators and physical devices. **Tests**: This code only effects UI appearance so not sure how to test for that and no tests were written. **Screenshots**: This code does not add anything new to the UI, it only controls whether to display existing items. Co-authored-by:
bswe <bbollenbacher@mindspring.com>
-
Kate Glazko authored
-
MozLando authored
6015: For #5991 - Downgrade RecyclerView version to fix a11y crash r=sblatz a=ekager Co-authored-by:
ekager <emilykager@gmail.com>
-
ekager authored
-
MozLando authored
5976: No issue: Update androidx fragment Oct 11 r=boek a=ekager 5999: For #5709: Align ETP Settings Screen implementation with original mocks r=NotWoods a=mcarare Co-authored-by:
ekager <emilykager@gmail.com> Co-authored-by:
mcarare <mihai.carare.dev@gmail.com>
-
MozLando authored
6007: No issue: Remove black flash workaround r=boek a=ekager For #5984 Co-authored-by:
ekager <emilykager@gmail.com>
-
ekager authored
-
bswe authored
-
bswe authored
-
bswe authored
-
bswe authored
Issue #5233: Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "recommend private browing shortcut" dialog is displayed.
-
bswe authored
Issue #5233: Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "add private browing shortcut" item is visible in the settings menu.
-
bswe authored
Issue #5233: Added doesPrivateBrowsingPinnedShortcutExist function to determine whether a shortcut already exists (only available in API >=25).
-
MozLando authored
5908: Closes #5876: Removed @ObsoleteCoroutinesApi in tests r=sblatz a=shldhll ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not - [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features ### After merge - [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture Co-authored-by:
shldhll <iam.shldhll@gmail.com>
-
MozLando authored
5973: For #5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz Co-authored-by:
Sawyer Blatz <sdblatz@gmail.com>
-
mcarare authored
-
- 13 Oct, 2019 1 commit
-
-
Mozilla L10n Automation Bot authored
-
- 12 Oct, 2019 1 commit
-
-
ekager authored
-
- 11 Oct, 2019 8 commits
-
-
Sawyer Blatz authored
-
MozLando authored
5897: No issue: Update androidx dependencies Oct 9 r=sblatz a=ekager Land tomorrow after we cut release but finally out of using alphas (mostly) ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not - [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features ### After merge - [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture Co-authored-by:
Emily Kager <ekager@mozilla.com>
-
MozLando authored
5956: For #5947 - Fix engineView NullPointerException r=csadilek a=ekager Co-authored-by:
ekager <emilykager@gmail.com>
-
MozLando authored
5933: Removes legacy nightly automation r=johanlorenzo a=mitchhentges Co-authored-by:
Mitchell Hentges <mhentges@mozilla.com>
-
MozLando authored
5507: For #1383 Added tab title to close button content description r=ekager a=mcarare ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features ### After merge - [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture 5846: For #3604 Snackbar messages for closing tabs use closed instead of deleted r=sblatz a=mcarare ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features ### After merge - [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture Co-authored-by:
mcarare <mihai.carare.dev@gmail.com>
-
ekager authored
-
MozLando authored
5633: Add fxa/sync integration tests r=csadilek a=isabelrios Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [-] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not - [-] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features This PR tries to add new tests, sync integration tests, to check the sync process Desktop<->Fenix, first for Bookmarks and in the future for more. Co-authored-by:
Isabel Rios <isabelrios@mackbookirios.home> Co-authored-by:
isabelrios <isabelrios@gmail.com>
-
MozLando authored
5882: For #5873 Added on/off indicator for delete browsing data on exit pref r=sblatz a=mcarare ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features ### After merge - [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture Co-authored-by:
mcarare <mihai.carare.dev@gmail.com>
-