The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2023-11-06T23:08:01Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41554New Identity clears history even if history storage is enabled2023-11-06T23:08:01ZMike PerryNew Identity clears history even if history storage is enabledIf Tor Browser 12 is configured to store browsing history, New Identity now clears this history. This is unexpected, as we have always preserved history for people who enable that in the past. Because we do not render visited styles, his...If Tor Browser 12 is configured to store browsing history, New Identity now clears this history. This is unexpected, as we have always preserved history for people who enable that in the past. Because we do not render visited styles, history storage does not leak information to websites, so it does not need to be cleared in this case.
See also: https://gitlab.torproject.org/tpo/applications/team/-/issues/19
I am wondering if this is a side effect of re-implementing New Identity in the browser, as opposed to Torbutton? If we just naively switched to doing what Firefox does on "Clear all browser state", then we may also *not* be clearing some additional linkable state, or emitting events for extensions, and properly closing things like keep-alive connections, SSL state, blob urls, etc.
Torbutton's behavior on New Identity was formerly documented here: https://2019.www.torproject.org/projects/torbrowser/design/#new-identity.ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41676Set privacy.resistFingerprinting.testing.setTZtoUTC as a defense-in-depth2024-03-26T20:22:16ZTom Rittertom@ritter.vgSet privacy.resistFingerprinting.testing.setTZtoUTC as a defense-in-depthSee https://bugzilla.mozilla.org/show_bug.cgi?id=1709867#c21 - we're changing how to spoof the timezone to make way for fine-grained control of that aspect of RFP. On Nightly we _by default_ have changed the behavior of RFP. Tor Browse...See https://bugzilla.mozilla.org/show_bug.cgi?id=1709867#c21 - we're changing how to spoof the timezone to make way for fine-grained control of that aspect of RFP. On Nightly we _by default_ have changed the behavior of RFP. Tor Browser should flip this pref to true to keep the old behavior until we are certain their are no leaks. This will be landing on Nightly soon, so eventually it will ride to Release and affect Android.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/core/tor/-/issues/40840Prevent outbound cell command flipping2024-02-13T17:00:47ZMike PerryPrevent outbound cell command flippingAs per https://gitlab.torproject.org/tpo/core/torspec/-/blob/main/proposals/344-protocol-info-leaks.txt#L197, the RELAY_EARLY fix did not address the outbound direction.
We can fix this by checking at relays that the cell command field ...As per https://gitlab.torproject.org/tpo/core/torspec/-/blob/main/proposals/344-protocol-info-leaks.txt#L197, the RELAY_EARLY fix did not address the outbound direction.
We can fix this by checking at relays that the cell command field does not switch back and forth between RELAY and RELAY_EARLY. Then, so long as the middle relay is honest, this vector cannot be used as a covert channel between the Guard and the Exit.
This fix should be relatively simple and can be backported, though we should of course test it in shadow.Mike PerryMike Perryhttps://gitlab.torproject.org/tpo/core/tor/-/issues/40860Sort introduction points before encoding?2023-09-18T13:31:13ZNick MathewsonSort introduction points before encoding?It might be a good idea to make sure that when we encode introduction points, we do so in a standard order so that we don't leak any information. Right now, introduction points are selected in `pick_needed_intro_points()` and encoded in...It might be a good idea to make sure that when we encode introduction points, we do so in a standard order so that we don't leak any information. Right now, introduction points are selected in `pick_needed_intro_points()` and encoded in `get_inner_encrypted_layer_plaintext()`.
This probably needs a specification change too. See also arti#1039.Tor: 0.4.7.x-post-stablehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40964Create new Tor Browser gpg subkey2023-10-16T21:20:23ZboklmCreate new Tor Browser gpg subkeyAfter being extended by 5 months in #40957, the current Tor Browser gpg subkey will be expiring in some months. We should generate a new subkey and switch to it while the old one is still valid for a few months.After being extended by 5 months in #40957, the current Tor Browser gpg subkey will be expiring in some months. We should generate a new subkey and switch to it while the old one is still valid for a few months.boklmboklm2023-11-13https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/issues/242skipTRR-when-parental-control-enabled2023-10-11T21:19:40ZThorinskipTRR-when-parental-control-enabled`network.dns.skipTRR-when-parental-control-enabled` - will be deprecated by the time we move to ESR128
something for MB to consider. close if not worth it
from the almighty arkenfox
```
/* 0711: disable skipping DoH when parental contr...`network.dns.skipTRR-when-parental-control-enabled` - will be deprecated by the time we move to ESR128
something for MB to consider. close if not worth it
from the almighty arkenfox
```
/* 0711: disable skipping DoH when parental controls are enabled [FF70+] ***/
user_pref("network.dns.skipTRR-when-parental-control-enabled", false);
```https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/issues/245Add correct Appstream metadata2024-03-27T12:58:01ZruihildtAdd correct Appstream metadataThis is used by downstream packages and also by flathub to show the changelog for the latest flatpak version.
See: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.htmlThis is used by downstream packages and also by flathub to show the changelog for the latest flatpak version.
See: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.htmlhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42168Crash on Debian Sid2023-11-08T20:06:01ZrichardCrash on Debian SidFrom IRC:
```
<peace_peace> How would you stop version 12.5.6 of TOR Browser from failing with...
<peace_peace> Bail out! Gtk:ERROR:../../../gtk/gtkiconhelper.c:495:ensure_surface_for_gicon:
assertion failed (error == NULL): Failed to
l...From IRC:
```
<peace_peace> How would you stop version 12.5.6 of TOR Browser from failing with...
<peace_peace> Bail out! Gtk:ERROR:../../../gtk/gtkiconhelper.c:495:ensure_surface_for_gicon:
assertion failed (error == NULL): Failed to
load /usr/share/icons/Adwaita/scalable/status/image-missing.svg: Unable to load image-loading
module: /usr/lib/i386-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-svg.so: ./TorBrowser/Tor/libstdc++/libstdc++.so.6:
version `GLIBCXX_3.4.30' not found (required by /usr/lib/i386-linux-gnu/libicuuc.so.72)
<peace_peace> (gdk-pixbuf-error-quark, 5)
<peace_peace> ... when you ...
<peace_peace> 1.) right click on an image and
<peace_peace> 2.) scroll down the pop up menu to "Save Image As"
<peace_peace> ?
<richard> weird
<richard> looks like you need to update your glibcxx
<peace_peace> Yes, but, which Linux package contains glibcxx?
<peace_peace> Should the directory...
<peace_peace> .local/share/torbrowser/tbb/i686/tor-browser_en-US/Browser/
<peace_peace> have TWO copies of libstdc++.so.6 ?
<peace_peace> One in...
<peace_peace>
~/.local/share/torbrowser/tbb/i686/tor-browser_en-US/Browser/TorBrowser/Tor/libstdc++/libstdc++.so.6
<peace_peace> and a newer one in...
<richard> why do you have a .local/share/torbrowser folder?
<peace_peace> ~.local/share/torbrowser/tbb/i686/tor-browser_en-US/Browser/libstdc++/libstdc++.so.6
<peace_peace> richard, I'll check...
<peace_peace> richard, The folder ".local/share/torbrowser" is referred to by a package
named "torbrowser-launcher".
<richard> ah geez
<peace_peace> Please expound on "geez".
<richard> torbrowser-launcher
<richard> what version of debian are you on
<richard> fwiw the issue doesn't repro for me
<richard> in 12.5.6
<richard> so it sounds like your system libraries need to be update
<peace_peace> Franken-SID.
<peace_peace> A newer version of "torbrowser-launcher" is available.
<richard> that wouldn' matter
<richard> it's just a wrapper around downloading/deploying the browesr bundle
<richard> franken sid?
<richard> oh interesting
<richard> i think i get what's happening
<richard> well maybe
<richard> so we build+ship our own libstdc++ to handle running on older platforms
<richard> but it seems since your own sid (testing/unstable right?) gtk is pulling in libicuuc which
requires a *newer* version of libstdc++ than what we ship
<richard> which is def a weird one
<peace_peace> Thanks.
<richard> looks like we're building 3.4.28
<peace_peace> The computer has version 72.1-3 of the package named "libicu72".
<richard> can you open a bug on our gitlab
<richard> gitlab.torproject.org/tpo/applications/tor-browser
<richard> or something like that
<peace_peace> I searched /usr/lib/i386-linux-gnu/libicuuc.so.72* for version strings.
<peace_peace> I found...
<peace_peace> GLIBCXX_3.4, GLIBCXX_3.4.11 and GLIBCXX_3.4.30.
<richard> yeah that makes sense
<peace_peace> But no 3.4.28.
<richard> right our shipped libstdc++ has a max version string of 3.4.28
<richard> and libicuuc seems to require 3.4.30
<richard> so the browser loads our libraries and gtk, gtk uses our libstdc++, it loads libicuuc and
it tries to use functionality for a newer version of libstdc++
<peace_peace> Here's how I found the version strings...
<peace_peace> $ strings /usr/lib/i386-linux-gnu/libicuuc.so.72* | egrep GLIBCXX
<peace_peace> richard, Thank you for your thoughts.
<peace_peace> I need to go.
<richard> peace_peace: https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html
<richard> looks like we would need to upgrade to at least gcc 12.1.0
```
So from what I can surmise, GTK is loading a library that depends on a newer version of libstdc++ than we ship, resulting in a crash.
Can we upgrade the version of gcc we use since we ship libstdc++ with the browser?https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/issues/247fixup New (Private) Window2024-01-10T07:30:30ZThorinfixup New (Private) Windowsee https://github.com/mullvad/mullvad-browser/issues/162#issuecomment-1759281972
> - MB shouldn't have `New Identity` (menubar or hamburger)
> - MB at least on mac has `New Private Window` (menubar) instead of `New Window`
> - MB on ...see https://github.com/mullvad/mullvad-browser/issues/162#issuecomment-1759281972
> - MB shouldn't have `New Identity` (menubar or hamburger)
> - MB at least on mac has `New Private Window` (menubar) instead of `New Window`
> - MB on windows has neither (menubar is default off on windows anyway)
> - can we check mac's hamburger menu
We should check TB is correct as wellma1ma1https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/issues/248After an update, Github changelog should not open automatically2023-11-07T09:22:45ZruihildtAfter an update, Github changelog should not open automaticallyWe want to give the user a way of looking at the chnagelog if they so desire.
Right now a github page opens, which is not ideal.
What would be the best solution to this? Open an internal page containing all the changelogs or only the cu...We want to give the user a way of looking at the chnagelog if they so desire.
Right now a github page opens, which is not ideal.
What would be the best solution to this? Open an internal page containing all the changelogs or only the current one?https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42172browser.startup.homepage and TOR_DEFAULT_HOMEPAGE are ignored for the new win...2023-11-27T08:34:38ZRusty Birdbrowser.startup.homepage and TOR_DEFAULT_HOMEPAGE are ignored for the new window opened by New Identity### Summary
In 13.0, the `browser.startup.homepage` pref (and hence also the `TOR_DEFAULT_HOMEPAGE` environment variable, which populates the pref) is no longer used for the initial new window that is opened by `New Identity`. This new ...### Summary
In 13.0, the `browser.startup.homepage` pref (and hence also the `TOR_DEFAULT_HOMEPAGE` environment variable, which populates the pref) is no longer used for the initial new window that is opened by `New Identity`. This new window uses `about:tor` instead.
### Steps to reproduce:
1. Run `TOR_DEFAULT_HOMEPAGE='https://example.com/' ./start-tor-browser`
2. Connect
3. Trigger `New Identity`
### Environment
Linux (x86_64)https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42195Fix "What's new" URL to direct to latest version2024-03-27T23:39:53ZclairehurstFix "What's new" URL to direct to latest version<!--
* Use this issue template for reporting a new bug.
-->
### Summary
**Summarize the bug encountered concisely.**
Currently the "What's new" URL goes to https://www.torproject.org/releases/ which doesn't have the 13.0 release on it. ...<!--
* Use this issue template for reporting a new bug.
-->
### Summary
**Summarize the bug encountered concisely.**
Currently the "What's new" URL goes to https://www.torproject.org/releases/ which doesn't have the 13.0 release on it. It should instead go to https://blog.torproject.org/new-release-tor-browser-130/ for the 13.0 release, and programitcally go to the {current version} blog post.
### Steps to reproduce:
**How one can reproduce the issue - this is very important.**
1. Make a new tab
2. Go to quick settings
3. Tap on "What's new", notice that you go to https://www.torproject.org/releases/ which only goes up to 12.0
### Environment
**Which operating system are you using? For example: Debian GNU/Linux 10.1, Windows 10, Ubuntu Xenial, FreeBSD 12.2, etc.**
**Which installation method did you use? Distribution package (apt, pkg, homebrew), from source tarball, from Git, etc.**
### Relevant logs and/or screenshots
![Screenshot_2023-10-23_at_14.57.48](/uploads/a1b9bcd84a80ae08606faac9edefe19a/Screenshot_2023-10-23_at_14.57.48.png){width=25%}clairehurstclairehursthttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40992Updated torbrowser_version number is not enough to change firefox-android ver...2024-03-05T16:18:43ZboklmUpdated torbrowser_version number is not enough to change firefox-android versionCode numberWhen a new Tor Browser version doesn't include any new firefox-android
commit, its versionCode number will not change, although
`MOZ_BUILD_DATE` is changing.
The reason is that the function `generateFennecVersionCode` in
`fenix/buildSrc...When a new Tor Browser version doesn't include any new firefox-android
commit, its versionCode number will not change, although
`MOZ_BUILD_DATE` is changing.
The reason is that the function `generateFennecVersionCode` in
`fenix/buildSrc/src/main/java/Config.kt` is taking the date from
`MOZ_BUILD_DATE` and using the number of hours from December 28, 2014,
to generate a versionCode. However, `MOZ_BUILD_DATE` is based on the
commit date, on which we add the Tor Browser version as seconds, so
when a new version doesn't change the `firefox-android`,
`MOZ_BUILD_DATE` will only be change by a few seconds, which is not
enough to make `generateFennecVersionCode` update the versionCode.
To fix this we can add an empty firefox-android commit as a quick
workaround for this release, before finding a better way to handle
changing `MOZ_BUILD_DATE` for new releases.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40994Add support in do-all-signing to sign release for some archs only2023-12-07T13:28:57ZboklmAdd support in do-all-signing to sign release for some archs onlyCurrently when we want to sign a release for some of the platforms only,
we need to comment some steps in `do-all-signing`. We should add some
options to make it easier to disable/enable signing of some of the
platforms.Currently when we want to sign a release for some of the platforms only,
we need to comment some steps in `do-all-signing`. We should add some
options to make it easier to disable/enable signing of some of the
platforms.https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40996Do not version the .nobackup files2023-11-01T18:02:15ZPier Angelo VendrameDo not version the .nobackup filesThe patch to add `.nobackup` files messes up some configurations that were possibile before when some directories were completely ignored by git.
We should revert it and create the various `.nobackup` files with RBM instead (or have the...The patch to add `.nobackup` files messes up some configurations that were possibile before when some directories were completely ignored by git.
We should revert it and create the various `.nobackup` files with RBM instead (or have the people create a `.nobackup` files manually in the root of their clones).boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40997Document how to verify reproducibility of build of a mullvad/tor browser release2023-11-30T11:45:24ZboklmDocument how to verify reproducibility of build of a mullvad/tor browser releaseI think many users don't know that our builds are reproducible, or how
they can rebuild to verify that they get a matching build.
We could generate a `reproducible-build.txt` file in the release
directory containing the following inform...I think many users don't know that our builds are reproducible, or how
they can rebuild to verify that they get a matching build.
We could generate a `reproducible-build.txt` file in the release
directory containing the following informations:
- which git repository to clone
- which commit to checkout
- which command to use to start the build
- which sha256sums to expect after the build finished
- how to remove embedded signatures from exe and mar files we publish
to check that they match the unsigned buildboklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42236Let users decide whether to load their home page on new identity.2024-03-26T20:24:43Zmicahmicah@torproject.orgLet users decide whether to load their home page on new identity.In https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41765 the custom home page was disabled due to a very low-security issue. However, this has created a number of complaints from users.
Thus this issue to implement a...In https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41765 the custom home page was disabled due to a very low-security issue. However, this has created a number of complaints from users.
Thus this issue to implement a way to deal with both cases.
Options on the table are adding a setting/pref to restore old behavior, display a chrome banner with a string explaining why its not loaded, with a button to load it anyways; finally a combination of the two: add a setting/pref to restore the old behavior and display a chrome banner with a short explanation about why it is not loaded, as well as instructions for how to turn that behavior back onma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42243backport 1664278 Expose an "always underline links" checkbox in settings2023-11-07T00:16:08ZThorinbackport 1664278 Expose an "always underline links" checkbox in settings[1664278](https://bugzilla.mozilla.org/show_bug.cgi?id=1664278) - _seems_ like a simple patch, otherwise we wait a year til ESR128 - maybe someone could ask emilio if they could backport it to ESR115
![tada](/uploads/4da1397bafcf493159b...[1664278](https://bugzilla.mozilla.org/show_bug.cgi?id=1664278) - _seems_ like a simple patch, otherwise we wait a year til ESR128 - maybe someone could ask emilio if they could backport it to ESR115
![tada](/uploads/4da1397bafcf493159ba5b54680b3d63/tada.png)richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42373Backport Moz 18748012024-01-18T15:08:20ZPier Angelo VendrameBackport Moz 1874801Thorin found [Bug 1874801](https://bugzilla.mozilla.org/show_bug.cgi?id=1874801), and I think it might be a candidate for backport.
@richard how could we proceed? Alpha first and then 13.0.10?
@tjr do you think this could be uplifted t...Thorin found [Bug 1874801](https://bugzilla.mozilla.org/show_bug.cgi?id=1874801), and I think it might be a candidate for backport.
@richard how could we proceed? Alpha first and then 13.0.10?
@tjr do you think this could be uplifted to 115 at Moz?
/cc @ma1 for additional opinions :smile:.https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/issues/271After update, don't open the release page on Github. Instead link it in the s...2024-03-26T20:57:03ZruihildtAfter update, don't open the release page on Github. Instead link it in the startpage, like in Tor BrowserUsers are complaining a Github page is opening automatically after update (which I entirely agree is unnecessary and unwelcome).
Could we adopt the same flow as in Tor Browser.
See screenshot:
![image](/uploads/e19a1ed79ffdf358bf738ff...Users are complaining a Github page is opening automatically after update (which I entirely agree is unnecessary and unwelcome).
Could we adopt the same flow as in Tor Browser.
See screenshot:
![image](/uploads/e19a1ed79ffdf358bf738ffb8be9b953/image.png)richardrichard