The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2023-10-03T16:42:04Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40899Fix all of our usage of `app.support.baseURL`2023-10-03T16:42:04ZrichardFix all of our usage of `app.support.baseURL`So we cannot just point app.support.baseURL to our own manual and call it a day because mozilla uses this URL to point to various Firefox-specific support pages.
We need to audit these, and identify which ones need to point to tor-brows...So we cannot just point app.support.baseURL to our own manual and call it a day because mozilla uses this URL to point to various Firefox-specific support pages.
We need to audit these, and identify which ones need to point to tor-browser manual entries and which should go to Mozilla support pages.Sponsor 131 - Phase 3 - Major ESR 102 MigrationPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/anti-censorship/team/-/issues/20goptlib doesn't allow optimistic SOCKS data2022-03-01T17:19:09ZDavid Fifielddcf@torproject.orggoptlib doesn't allow optimistic SOCKS datagoptlib [wraps its socket](https://gitweb.torproject.org/pluggable-transports/goptlib.git/tree/socks.go?id=a3ad5df6c9e7dc8117f55958b4ce99bf1e0fe291#n203) in a [bufio.ReadWriter](https://golang.org/pkg/bufio/#ReadWriter) while processing ...goptlib [wraps its socket](https://gitweb.torproject.org/pluggable-transports/goptlib.git/tree/socks.go?id=a3ad5df6c9e7dc8117f55958b4ce99bf1e0fe291#n203) in a [bufio.ReadWriter](https://golang.org/pkg/bufio/#ReadWriter) while processing the SOCKS handshake. Before returning the socket back to the application, [it makes sure](https://gitweb.torproject.org/pluggable-transports/goptlib.git/tree/socks.go?id=a3ad5df6c9e7dc8117f55958b4ce99bf1e0fe291#n437) there is no unread data sitting in the buffer (which would otherwise be lost).
In legacy/trac#24432, we're trying to have Tor Browser use meek-client as a proxy directly, not going through Tor. The problem (comment:19:ticket:24432) is that Tor Browser has a special optimistic data SOCKS patch that causes it to send data exactly where goptlib checks to make sure there isn't any.
A mild rewrite of goptlib's SOCKS code could eliminate the internal buffer and enable Tor Browser's optimistic data.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.org