The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2021-07-22T16:20:36Zhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26829torspec: bandwidth file generators should write the file atomically2021-07-22T16:20:36Zteortorspec: bandwidth file generators should write the file atomicallyGenerators should either:
* write the file to a temporary location, then rename it to the final path, or
* write the file to an archival location, then symlink it to the final pathGenerators should either:
* write the file to a temporary location, then rename it to the final path, or
* write the file to an archival location, then symlink it to the final pathTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26827torspec: DirAuths should only read the V3BandwidthsFile once per vote2021-07-22T16:20:36Zteortorspec: DirAuths should only read the V3BandwidthsFile once per voteOnce legacy/trac#26797 is implemented, we should document it in the spec.Once legacy/trac#26797 is implemented, we should document it in the spec.Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26702Remind authority operators that bandwidth files should be written atomcally2021-07-22T16:20:51ZteorRemind authority operators that bandwidth files should be written atomcallyTor reads bandwidth files when it's voting, around 50 minutes past every hour, and 20 minutes past hours when the consensus has failed.
We should recommend that authority operators generate and transfer bandwidth files ~~between 5-15 or...Tor reads bandwidth files when it's voting, around 50 minutes past every hour, and 20 minutes past hours when the consensus has failed.
We should recommend that authority operators generate and transfer bandwidth files ~~between 5-15 or 35-45 minutes~~ outside of 15-25 and 45-55 minutes past the hour. ~~The best place for this might be in dir-spec or the bandwidth file spec.~~Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26638add tor's code of conduct to the tor.git repo?2021-07-22T16:20:51ZIsis Lovecruftadd tor's code of conduct to the tor.git repo?It [looks like](https://github.com/torproject/tor/community) if we create a `CODE_OF_CONDUCT` or `CODE_OF_CONDUCT.md` file in the top-most directory of our repo, Github will do some nice things to let new contributors know about it (alon...It [looks like](https://github.com/torproject/tor/community) if we create a `CODE_OF_CONDUCT` or `CODE_OF_CONDUCT.md` file in the top-most directory of our repo, Github will do some nice things to let new contributors know about it (along with asking them to read the `CONTRIBUTING` guidelines). Should we add [our code of conduct](https://gitweb.torproject.org/community/policies.git/tree/code_of_conduct.txt)? Or add a link to where it can be found?Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26591doc/ missing in build directory for out-of-tree builds2023-09-15T11:42:09ZTracdoc/ missing in build directory for out-of-tree builds**autoconf** allows building tor outside the source directory using `--srcdir=DIR`.
In that case, _doc/_ is not copied or symlinked from source to build directory, causing pages to be unnesseccarily regenerated using **rst2man**.
Would ...**autoconf** allows building tor outside the source directory using `--srcdir=DIR`.
In that case, _doc/_ is not copied or symlinked from source to build directory, causing pages to be unnesseccarily regenerated using **rst2man**.
Would it be possible to adjust the _configure_ stage to account for this?
Specifically, this would allow complete out-of-tree builds at least on OpenBSD, where where the following quirk is required after _configure_ and before _build_ stage to enable separation without **py-docutils** as additional build dependency:
```
pre-build:
ln -sf ${WRKSRC}/doc/ ${WRKBUILD}/
```
**Trac**:
**Username**: knhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26587--verify-config accepts RelayBandwidthRate with no value?2021-06-18T18:05:27Zcypherpunks--verify-config accepts RelayBandwidthRate with no value?is this a valid config line?
```
RelayBandwidthRate
```
(no value)
--verify-config does not complain - something I expectedis this a valid config line?
```
RelayBandwidthRate
```
(no value)
--verify-config does not complain - something I expectedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26333Write trac templates for bug reports / other tickets, and link them from some...2021-07-22T16:20:51ZNick MathewsonWrite trac templates for bug reports / other tickets, and link them from somewhere usefulIt would be awesome if we could have templates for opening better trac tickets, in a way to actually help people include all the necessary info and not have a hard time figure out what they're supposed to say.
This might be an "internal...It would be awesome if we could have templates for opening better trac tickets, in a way to actually help people include all the necessary info and not have a hard time figure out what they're supposed to say.
This might be an "internal services" ticket, but before we can get it there, we need to figure out what we actually want.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26217add info that fingerprints in MyFamily are not case-sensitive2021-07-22T16:20:51Zcypherpunksadd info that fingerprints in MyFamily are not case-sensitiveThe man page does currently not say that MyFamily fingerprint values are not case sensitive.The man page does currently not say that MyFamily fingerprint values are not case sensitive.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26170Core Tor releases typo2021-07-22T16:20:51ZTracCore Tor releases typoIt says 0.3.3 end of life is on `On or after Mar 22, 2018` but that is the day that it should be released.
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases?version=40
**Trac**:
**Username**: Dbryrtfb...It says 0.3.3 end of life is on `On or after Mar 22, 2018` but that is the day that it should be released.
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases?version=40
**Trac**:
**Username**: DbryrtfbcbhgfTor: 0.3.3.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/25998FetchUselessDescriptors also stops Tor from going idle2021-07-22T16:20:51ZteorFetchUselessDescriptors also stops Tor from going idleTor: 0.3.3.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/25991module: Write documentation in doc/ on how to write a module2021-09-16T14:30:52ZDavid Gouletdgoulet@torproject.orgmodule: Write documentation in doc/ on how to write a moduleWrite a small file in `doc/HACKING/` on how to proceed with a module. The current template is the freshly merged dirauth module.
This would be for now mostly related to the build system and the code standards.Write a small file in `doc/HACKING/` on how to proceed with a module. The current template is the freshly merged dirauth module.
This would be for now mostly related to the build system and the code standards.Tor: 0.3.4.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/25978UseEntryGuards 0 disables EntryNodes2021-07-22T16:20:51ZTracUseEntryGuards 0 disables EntryNodesUseEntryNodes {se} should allow UseEntryGuards 0
But UseEntryGuards 0 breaks UseEntryNodes unless it can find a GuardNode which is against the purpose of UseEntryNodes in TORRC.
**Trac**:
**Username**: tortracUseEntryNodes {se} should allow UseEntryGuards 0
But UseEntryGuards 0 breaks UseEntryNodes unless it can find a GuardNode which is against the purpose of UseEntryNodes in TORRC.
**Trac**:
**Username**: tortracTor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/25965Document default value of Nickname parameter [patch]2021-07-22T16:20:51ZTracDocument default value of Nickname parameter [patch]While responding to an inquiry on IRC regarding [[Plinth issue #1294: tor: let the user verify if the relay is connected](https://salsa.debian.org/freedombox-team/plinth/issues/1294|Freedombox)] I was wondering what happens if the `Nickn...While responding to an inquiry on IRC regarding [[Plinth issue #1294: tor: let the user verify if the relay is connected](https://salsa.debian.org/freedombox-team/plinth/issues/1294|Freedombox)] I was wondering what happens if the `Nickname` is not set.
I had to refer to the source code to find out.
I have published a change that fixes this:
http://repo.or.cz/tor/appveyor.git/shortlog/refs/heads/default_nickname
("default_nickname" branch on http://repo.or.cz/tor/appveyor.git)
**Trac**:
**Username**: saperTor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/25963Clarify the bandwidth part of dir-spec2021-09-16T14:30:52ZteorClarify the bandwidth part of dir-specPeople keep asking about the precise meaning of relay bandwidths. We should make the spec clearer:
https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n424
In particular:
* there is a separate limit on inbound and outbound traf...People keep asking about the precise meaning of relay bandwidths. We should make the spec clearer:
https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n424
In particular:
* there is a separate limit on inbound and outbound traffic
* traffic includes origin circuits and BEGINDIR requests
* let's check if traffic includes DirPort, I think it would have to
There may also be more feedback in legacy/trac#25854.
I'm tagging this fast-fix, because I can fix it fast, and it will save me time when I next explain it.https://gitlab.torproject.org/tpo/core/tor/-/issues/25897manual: document that ControlSocket is disabled by default2021-07-22T16:20:51Zcypherpunksmanual: document that ControlSocket is disabled by defaulthttps://www.torproject.org/docs/tor-manual.html.en#ControlSocket
"
Like ControlPort, but listens on a Unix domain socket, rather than a TCP socket. 0 disables ControlSocket (Unix and Unix-like systems only.)
"
Please add:
"(Default: ...https://www.torproject.org/docs/tor-manual.html.en#ControlSocket
"
Like ControlPort, but listens on a Unix domain socket, rather than a TCP socket. 0 disables ControlSocket (Unix and Unix-like systems only.)
"
Please add:
"(Default: 0)" add the end (as you do with most other entries).Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/25857::/128 is not the IPv6 equivalent of 0.0.0.0/02021-07-22T16:20:51ZTrac::/128 is not the IPv6 equivalent of 0.0.0.0/0The [man page of tor](https://gitweb.torproject.org/tor.git/tree/doc/tor.1.txt#n1837) states that "::/128" is the IPv6 equivalent of IPv4's "0.0.0.0/0" and that is not correct.
The equivalent of "0.0.0.0/0" in IPv6 is "::/0"
The IPv4 e...The [man page of tor](https://gitweb.torproject.org/tor.git/tree/doc/tor.1.txt#n1837) states that "::/128" is the IPv6 equivalent of IPv4's "0.0.0.0/0" and that is not correct.
The equivalent of "0.0.0.0/0" in IPv6 is "::/0"
The IPv4 equivalent of "::/128" would be "0.0.0.0/32".
https://en.wikipedia.org/wiki/IPv6_address#Unicast_addresses
**Trac**:
**Username**: CTassisFTor: 0.3.3.x-finalDamian JohnsonDamian Johnsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/25720man: RephistTrackTime is not a dirauth only option2021-07-22T16:20:51ZDavid Gouletdgoulet@torproject.orgman: RephistTrackTime is not a dirauth only optionWe should move the `RephistTrackTime` man page entry to the server side options because every node use it when dumping stats on a SIGUSR1.We should move the `RephistTrackTime` man page entry to the server side options because every node use it when dumping stats on a SIGUSR1.Tor: 0.3.4.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/25664Update libc version requirement in GettingStartedRust.md and configure.ac2021-07-22T16:20:51ZGeorg KoppenUpdate libc version requirement in GettingStartedRust.md and configure.acWhen merging the patches for legacy/trac#25310 the libc version requirement in `GettingStartedRust.md` and `configure.ac` did not get updated.When merging the patches for legacy/trac#25310 the libc version requirement in `GettingStartedRust.md` and `configure.ac` did not get updated.Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/25661RendPostPeriod and HiddenServiceAuthorizeClient are v2 only2021-09-30T13:46:29ZteorRendPostPeriod and HiddenServiceAuthorizeClient are v2 onlyRendPostPeriod and HiddenServiceAuthorizeClient only apply to v2 onion services. We should update the man page so this is clearer.RendPostPeriod and HiddenServiceAuthorizeClient only apply to v2 onion services. We should update the man page so this is clearer.Tor: 0.3.3.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/25628Document our Rust coding standards for error/failure types2021-07-22T16:20:50ZIsis LovecruftDocument our Rust coding standards for error/failure typesEvery crate which returns `Result<T, E>`s or `Option<T>` anywhere in its public interface should have an `errors.rs` module containing error types which implement either `Display` or `Debug`. See the `errors.rs` addition to the `protover...Every crate which returns `Result<T, E>`s or `Option<T>` anywhere in its public interface should have an `errors.rs` module containing error types which implement either `Display` or `Debug`. See the `errors.rs` addition to the `protover` crate from legacy/trac#24031 for an example.
In the future, when failure is 1.0.0, we should also require `::failure::Fail` for making errors easier to work with between crates.Tor: unspecified