The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2022-10-18T16:54:44Zhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26908make it more clear that torrc files should not contain any bridges in their M...2022-10-18T16:54:44Znusenumake it more clear that torrc files should not contain any bridges in their MyFamily lines
We improved this part of the documentation in the past but it is still not clear enough:
https://lists.torproject.org/pipermail/tor-relays/2018-July/015735.html
lets add:
"Do NOT add MyFamily lines to your bridge configuration files."...
We improved this part of the documentation in the past but it is still not clear enough:
https://lists.torproject.org/pipermail/tor-relays/2018-July/015735.html
lets add:
"Do NOT add MyFamily lines to your bridge configuration files."
to the torrc and MyFamily section of the man page.https://gitlab.torproject.org/tpo/core/tor/-/issues/26925Make link specifier handling in rend-spec-v3 more precise2021-07-22T16:20:36ZteorMake link specifier handling in rend-spec-v3 more preciseSplit off legacy/trac#26627.
We should specify that clients and services must not check untrusted link specifiers against the consensus:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1338
https://gitweb.torproject.org...Split off legacy/trac#26627.
We should specify that clients and services must not check untrusted link specifiers against the consensus:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1338
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
Services should also copy unrecognized rend point link specifiers from the introduce cell to the rendezvous join cell.
We can copy the text from the service intro->rend spec:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
To the the client desc->intro spec:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1338
Thanks to catalyst for picking up on these missing parts of the spec.
Edit: fix line numbersTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27052document rust/crypto2021-07-22T16:20:36Zcypherpunksdocument rust/cryptoAnd add `#![deny(missing_docs)]` to the top of the files to enforce it.
Attempted in [af182d4ab51d6a1a70559bbdcd4ab842aa855684](https://gitweb.torproject.org/tor.git/commit/?id=af182d4ab51d6a1a70559bbdcd4ab842aa855684) and [b6059297d7cb...And add `#![deny(missing_docs)]` to the top of the files to enforce it.
Attempted in [af182d4ab51d6a1a70559bbdcd4ab842aa855684](https://gitweb.torproject.org/tor.git/commit/?id=af182d4ab51d6a1a70559bbdcd4ab842aa855684) and [b6059297d7cb76f0e00e2098e38d6677d3033340](https://gitweb.torproject.org/tor.git/commit/?id=b6059297d7cb76f0e00e2098e38d6677d3033340) but forgot the exclamation point.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27130rust dependency updating instructions don't work2021-07-22T16:20:36ZTracrust dependency updating instructions don't workNone of the instructions mention updating `Cargo.lock`, which is required. The script `updateRustDependencies.sh` doesn't update that file, either.
**Trac**:
**Username**: cyberpunksNone of the instructions mention updating `Cargo.lock`, which is required. The script `updateRustDependencies.sh` doesn't update that file, either.
**Trac**:
**Username**: cyberpunksTor: unspecifiedNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27160Make GettingStartedRust.md say that we support rust stable2021-07-22T16:20:36ZteorMake GettingStartedRust.md say that we support rust stableIn legacy/trac#24765, we made CodingStandardsRust.md say that we support rust stable, but we left GettingStartedRust.md saying that we support rust nightly.In legacy/trac#24765, we made CodingStandardsRust.md say that we support rust stable, but we left GettingStartedRust.md saying that we support rust nightly.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27176fix inaccurate rust docs2021-07-22T16:20:36ZTracfix inaccurate rust docsSome method descriptions are outdated or were never correct, like the one for `parse_protocol_and_version_str()`.
**Trac**:
**Username**: cyberpunksSome method descriptions are outdated or were never correct, like the one for `parse_protocol_and_version_str()`.
**Trac**:
**Username**: cyberpunksTor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27198protover doesn't forbid version zero2021-09-16T14:29:03ZTracprotover doesn't forbid version zero[dir-spec.txt](https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt) says:
> Int = NON_ZERO_DIGIT
> Int = Int DIGIT
But the code in protover.c allows `Foo=0`.
**Trac**:
**Username**: cyberpunks[dir-spec.txt](https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt) says:
> Int = NON_ZERO_DIGIT
> Int = Int DIGIT
But the code in protover.c allows `Foo=0`.
**Trac**:
**Username**: cyberpunkshttps://gitlab.torproject.org/tpo/core/tor/-/issues/27204add info for IPv6-only hosts to torrc man page2021-07-22T16:20:36Ztraumschuleadd info for IPv6-only hosts to torrc man pageAdd a sentence to the ClientUseIPv6 section of the tor man page:
> For IPv6 only hosts, you need to also set **ClientUseIPv4** to 0 to disable IPv4.Add a sentence to the ClientUseIPv6 section of the tor man page:
> For IPv6 only hosts, you need to also set **ClientUseIPv4** to 0 to disable IPv4.Tor: 0.3.5.x-finaltraumschuletraumschulehttps://gitlab.torproject.org/tpo/core/tor/-/issues/27207Examples in CodingStandardsRust.md are wrong2021-09-16T14:29:03ZTracExamples in CodingStandardsRust.md are wrongThe section on `CString` is incorrect:
- `CString::new("bl\x00ah").unwrap().into_raw()` will panic in the 'unwrap' call, it will never return a pointer of any kind, dangling or otherwise.
Also, [12cf04646c571646b726e697d66ecafad7886cf2...The section on `CString` is incorrect:
- `CString::new("bl\x00ah").unwrap().into_raw()` will panic in the 'unwrap' call, it will never return a pointer of any kind, dangling or otherwise.
Also, [12cf04646c571646b726e697d66ecafad7886cf2](https://gitweb.torproject.org/tor.git/commit/doc/HACKING/CodingStandardsRust.md?id=12cf04646c571646b726e697d66ecafad7886cf2) seems to be the result of some miscommunication with [withoutboats](https://github.com/withoutboats):
- `.expect()` is [literally](https://doc.rust-lang.org/std/result/enum.Result.html#method.expect) '`.unwrap()`, but with a custom panic message,' it doesn't return an `Option` and is no safer than unwrap, but it is self-documenting.
**Trac**:
**Username**: cyberpunkshttps://gitlab.torproject.org/tpo/core/tor/-/issues/27317document that setting RelayBandwidthRate changes RelayBandwidthBurst2022-09-28T22:11:28ZTracdocument that setting RelayBandwidthRate changes RelayBandwidthBurstwhen setting RelayBandwidthRate I didn't expect that will also change
RelayBandwidthBurst (default: 0 according to the manpage)
I only realized it after connecting to the relay via Nyx. Nyx showed that
RelayBandwidthBurst is at the sa...when setting RelayBandwidthRate I didn't expect that will also change
RelayBandwidthBurst (default: 0 according to the manpage)
I only realized it after connecting to the relay via Nyx. Nyx showed that
RelayBandwidthBurst is at the same value as RelayBandwidthRate,
even though RelayBandwidthBurst does not appear in the torrc file
**Trac**:
**Username**: a_phttps://gitlab.torproject.org/tpo/core/tor/-/issues/27332outdated documentation for connection_handle_write_impl()2021-07-22T16:20:36ZTracoutdated documentation for connection_handle_write_impl()```
* This function gets called either from conn_write_callback() in main.c
* when libevent tells us that conn wants to write, or below
* from connection_buf_add() when an entire TLS record is ready.
```
_, or below ... when an entir...```
* This function gets called either from conn_write_callback() in main.c
* when libevent tells us that conn wants to write, or below
* from connection_buf_add() when an entire TLS record is ready.
```
_, or below ... when an entire TLS record is ready_ hasn't been accurate since [d9746bd468f551d1ada57d962b20eddd15256ce9](https://gitweb.torproject.org/tor.git/commit/?id=d9746bd468f551d1ada57d962b20eddd15256ce9).
It and connection_handle_read_impl also don't mention only ever being called indirectly via `connection_handle_write()`/read since [d3be00e0f454998db6387c8547d218a0db93db21](https://gitweb.torproject.org/tor.git/commit/?id=d3be00e0f454998db6387c8547d218a0db93db21), but that's more readily apparent at least.
**Trac**:
**Username**: cyberpunksTor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27333outdated docs for onion_extend_cpath()2021-07-22T16:20:36ZTracoutdated docs for onion_extend_cpath()The description of `onion_extend_cpath()` hasn't been accurate since [f2bd0e2f16944de3b3c8722fb9412ad60d0fae2c](https://gitweb.torproject.org/tor.git/commit/?id=f2bd0e2f16944de3b3c8722fb9412ad60d0fae2c) changed its arguments.
**Trac**: ...The description of `onion_extend_cpath()` hasn't been accurate since [f2bd0e2f16944de3b3c8722fb9412ad60d0fae2c](https://gitweb.torproject.org/tor.git/commit/?id=f2bd0e2f16944de3b3c8722fb9412ad60d0fae2c) changed its arguments.
**Trac**:
**Username**: cyberpunksTor: 0.3.5.x-finaltraumschuletraumschulehttps://gitlab.torproject.org/tpo/core/tor/-/issues/27334RelaxDirModeCheck on ControlSocket still requires group to m2022-06-17T17:36:58ZTracRelaxDirModeCheck on ControlSocket still requires group to mEven with RelaxDirModeCheck flag on the ControlSocket tor requires
the folder (containing the socket file) group to match the group of the user running tor.
Could you lift this requirement when the RelaxDirModeCheck flag is given or is ...Even with RelaxDirModeCheck flag on the ControlSocket tor requires
the folder (containing the socket file) group to match the group of the user running tor.
Could you lift this requirement when the RelaxDirModeCheck flag is given or is there an important reason for that?
os: FreeBSD 11.2
conf:
```
ControlSocket /var/run/tor-instances/123/controlsocket GroupWritable RelaxDirModeCheck
```
log:
```
Before Tor can create a control socket in "/var/run/tor-instances/123/controlsocket", the directory "/var/run/tor-instances/123" needs to exist, and to be accessible only by the user and group account that is running Tor. (On some Unix systems, anybody who can list a socket can connect to it, so Tor is being careful.)
```
**Trac**:
**Username**: a_phttps://gitlab.torproject.org/tpo/network-health/team/-/issues/11Write up a page explaining criteria for rejecting bad relays2021-05-17T09:29:00ZGeorg KoppenWrite up a page explaining criteria for rejecting bad relaysOur community and the network health team itself (and, of course, other stake holders like the directory authorities) would benefit from having some guidelines on what we think criteria for bad-relays are.
We should write that up and pr...Our community and the network health team itself (and, of course, other stake holders like the directory authorities) would benefit from having some guidelines on what we think criteria for bad-relays are.
We should write that up and probably point at least tor-internal to it for wider feedback, so everyone is on the same page.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/network-health/sbws/-/issues/40056Document better the differences between sbws and torflow scaling2021-02-25T20:22:30ZjugaDocument better the differences between sbws and torflow scalingThere's already some documentation at https://sbws.readthedocs.io/en/latest/how_works.html#running-the-generator and https://sbws.readthedocs.io/en/latest/torflow_aggr.html, but that does not include the `pid` values that torflow uses.
...There's already some documentation at https://sbws.readthedocs.io/en/latest/how_works.html#running-the-generator and https://sbws.readthedocs.io/en/latest/torflow_aggr.html, but that does not include the `pid` values that torflow uses.
Documenting this better would help to evaluate #40040.sbws: 1.1.x-finaljugajugahttps://gitlab.torproject.org/tpo/network-health/sbws/-/issues/40044Update the required disk space after #400172021-03-02T09:49:27ZjugaUpdate the required disk space after #40017Since the number of days after `datadir` files are compressed and removed has changed.Since the number of days after `datadir` files are compressed and removed has changed.sbws: 1.1.x-finaljugajugahttps://gitlab.torproject.org/tpo/network-health/sbws/-/issues/28990Move all or part of the documentation about Tor and the bandwidth scanner2022-03-01T15:26:38ZjugaMove all or part of the documentation about Tor and the bandwidth scannerI've writing documentation in https://onbasca.readthedocs.io/ that i didn't know where else could go.
Some of it might be useful only for me but some might be useful for other people and should be in Tor project domain.I've writing documentation in https://onbasca.readthedocs.io/ that i didn't know where else could go.
Some of it might be useful only for me but some might be useful for other people and should be in Tor project domain.sbws: 2.0.x-final-oldhttps://gitlab.torproject.org/tpo/network-health/onbasca/-/issues/107Move all or part of the documentation about Tor and the bandwidth scanner2023-12-11T09:51:28ZjugaMove all or part of the documentation about Tor and the bandwidth scannerI've writing documentation in https://onbasca.readthedocs.io/ that i didn't know where else could go.
Some of it might be useful only for me but some might be useful for other people and should be in Tor project domain.I've writing documentation in https://onbasca.readthedocs.io/ that i didn't know where else could go.
Some of it might be useful only for me but some might be useful for other people and should be in Tor project domain.jugajugahttps://gitlab.torproject.org/tpo/core/tor/-/issues/27388is_extrainfo in comment of router_parse_list_from_string() should be want_ext...2021-07-22T16:20:36ZNeel Chauhanneel@neelc.orgis_extrainfo in comment of router_parse_list_from_string() should be want_extrainfoTor: 0.3.5.x-finalNeel Chauhanneel@neelc.orgNeel Chauhanneel@neelc.orghttps://gitlab.torproject.org/tpo/network-health/sbws/-/issues/40069Ensure `recent` KeyValues behaviour is updated in the bandwidth file specific...2021-04-08T15:26:51ZjugaEnsure `recent` KeyValues behaviour is updated in the bandwidth file specificationsbws: 1.2.x-final