The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2021-07-22T16:20:36Zhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27388is_extrainfo in comment of router_parse_list_from_string() should be want_ext...2021-07-22T16:20:36ZNeel Chauhanneel@neelc.orgis_extrainfo in comment of router_parse_list_from_string() should be want_extrainfoTor: 0.3.5.x-finalNeel Chauhanneel@neelc.orgNeel Chauhanneel@neelc.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/27333outdated docs for onion_extend_cpath()2021-07-22T16:20:36ZTracoutdated docs for onion_extend_cpath()The description of `onion_extend_cpath()` hasn't been accurate since [f2bd0e2f16944de3b3c8722fb9412ad60d0fae2c](https://gitweb.torproject.org/tor.git/commit/?id=f2bd0e2f16944de3b3c8722fb9412ad60d0fae2c) changed its arguments.
**Trac**: ...The description of `onion_extend_cpath()` hasn't been accurate since [f2bd0e2f16944de3b3c8722fb9412ad60d0fae2c](https://gitweb.torproject.org/tor.git/commit/?id=f2bd0e2f16944de3b3c8722fb9412ad60d0fae2c) changed its arguments.
**Trac**:
**Username**: cyberpunksTor: 0.3.5.x-finaltraumschuletraumschulehttps://gitlab.torproject.org/tpo/core/tor/-/issues/27332outdated documentation for connection_handle_write_impl()2021-07-22T16:20:36ZTracoutdated documentation for connection_handle_write_impl()```
* This function gets called either from conn_write_callback() in main.c
* when libevent tells us that conn wants to write, or below
* from connection_buf_add() when an entire TLS record is ready.
```
_, or below ... when an entir...```
* This function gets called either from conn_write_callback() in main.c
* when libevent tells us that conn wants to write, or below
* from connection_buf_add() when an entire TLS record is ready.
```
_, or below ... when an entire TLS record is ready_ hasn't been accurate since [d9746bd468f551d1ada57d962b20eddd15256ce9](https://gitweb.torproject.org/tor.git/commit/?id=d9746bd468f551d1ada57d962b20eddd15256ce9).
It and connection_handle_read_impl also don't mention only ever being called indirectly via `connection_handle_write()`/read since [d3be00e0f454998db6387c8547d218a0db93db21](https://gitweb.torproject.org/tor.git/commit/?id=d3be00e0f454998db6387c8547d218a0db93db21), but that's more readily apparent at least.
**Trac**:
**Username**: cyberpunksTor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27204add info for IPv6-only hosts to torrc man page2021-07-22T16:20:36Ztraumschuleadd info for IPv6-only hosts to torrc man pageAdd a sentence to the ClientUseIPv6 section of the tor man page:
> For IPv6 only hosts, you need to also set **ClientUseIPv4** to 0 to disable IPv4.Add a sentence to the ClientUseIPv6 section of the tor man page:
> For IPv6 only hosts, you need to also set **ClientUseIPv4** to 0 to disable IPv4.Tor: 0.3.5.x-finaltraumschuletraumschulehttps://gitlab.torproject.org/tpo/core/tor/-/issues/27176fix inaccurate rust docs2021-07-22T16:20:36ZTracfix inaccurate rust docsSome method descriptions are outdated or were never correct, like the one for `parse_protocol_and_version_str()`.
**Trac**:
**Username**: cyberpunksSome method descriptions are outdated or were never correct, like the one for `parse_protocol_and_version_str()`.
**Trac**:
**Username**: cyberpunksTor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27160Make GettingStartedRust.md say that we support rust stable2021-07-22T16:20:36ZteorMake GettingStartedRust.md say that we support rust stableIn legacy/trac#24765, we made CodingStandardsRust.md say that we support rust stable, but we left GettingStartedRust.md saying that we support rust nightly.In legacy/trac#24765, we made CodingStandardsRust.md say that we support rust stable, but we left GettingStartedRust.md saying that we support rust nightly.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26925Make link specifier handling in rend-spec-v3 more precise2021-07-22T16:20:36ZteorMake link specifier handling in rend-spec-v3 more preciseSplit off legacy/trac#26627.
We should specify that clients and services must not check untrusted link specifiers against the consensus:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1338
https://gitweb.torproject.org...Split off legacy/trac#26627.
We should specify that clients and services must not check untrusted link specifiers against the consensus:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1338
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
Services should also copy unrecognized rend point link specifiers from the introduce cell to the rendezvous join cell.
We can copy the text from the service intro->rend spec:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
To the the client desc->intro spec:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1338
Thanks to catalyst for picking up on these missing parts of the spec.
Edit: fix line numbersTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26882IP address is not scrubbed in info logs, channel_tls_process_netinfo_cell() A...2021-07-22T16:20:36ZdmrIP address is not scrubbed in info logs, channel_tls_process_netinfo_cell() AND manpage for SafeLogging overgeneralizesHere's a log snippet from an `info` log I was manually reviewing to scrub before sharing.
```
[info] channel_tls_process_netinfo_cell(): Got good NETINFO cell from [scrubbed]:443; OR connection is now open, using protocol version 5. Its ...Here's a log snippet from an `info` log I was manually reviewing to scrub before sharing.
```
[info] channel_tls_process_netinfo_cell(): Got good NETINFO cell from [scrubbed]:443; OR connection is now open, using protocol version 5. Its ID digest is <redacted>. Our address is apparently <redacted>.
```
In the above, `<redacted>` is my notation; `[scrubbed]` is from SafeLogging.
(I'm not sure I had to redact the digest, but was just being conservative.)
`SafeLogging 1` was set (default).
Tor `0.3.3.7`
asn mentioned on #tor-dev that he thinks this is a bug.
Some brief notes from asn:
> "<none>" : fmt_and_decorate_addr(&my_apparent_addr));
> hm yeah that's I think a bug
> it should be safe_str_client()
> so weird that no one has mentioned htis before
It's worth noting the manpage for `SafeLogging` says:
> ...
> If this option is set to 0, Tor will not perform any scrubbing, if it is set to 1, all potentially sensitive strings are replaced.
> ...
arma advocated for a different resolution:
> if i were filing this ticket i would file a "scale back safelogging claims in the man page" ticket :)
(My preference is to scrub the IP address, but I also acknowledge the rabbit hole of trying to scrub anything "sensitive", especially in info/debug logs)Tor: 0.3.5.x-finalrl1987rl1987https://gitlab.torproject.org/tpo/core/tor/-/issues/26852doc: document Appveyor CI setup2021-07-22T16:20:36Zteordoc: document Appveyor CI setupTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26829torspec: bandwidth file generators should write the file atomically2021-07-22T16:20:36Zteortorspec: bandwidth file generators should write the file atomicallyGenerators should either:
* write the file to a temporary location, then rename it to the final path, or
* write the file to an archival location, then symlink it to the final pathGenerators should either:
* write the file to a temporary location, then rename it to the final path, or
* write the file to an archival location, then symlink it to the final pathTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26827torspec: DirAuths should only read the V3BandwidthsFile once per vote2021-07-22T16:20:36Zteortorspec: DirAuths should only read the V3BandwidthsFile once per voteOnce legacy/trac#26797 is implemented, we should document it in the spec.Once legacy/trac#26797 is implemented, we should document it in the spec.Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26702Remind authority operators that bandwidth files should be written atomcally2021-07-22T16:20:51ZteorRemind authority operators that bandwidth files should be written atomcallyTor reads bandwidth files when it's voting, around 50 minutes past every hour, and 20 minutes past hours when the consensus has failed.
We should recommend that authority operators generate and transfer bandwidth files ~~between 5-15 or...Tor reads bandwidth files when it's voting, around 50 minutes past every hour, and 20 minutes past hours when the consensus has failed.
We should recommend that authority operators generate and transfer bandwidth files ~~between 5-15 or 35-45 minutes~~ outside of 15-25 and 45-55 minutes past the hour. ~~The best place for this might be in dir-spec or the bandwidth file spec.~~Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26638add tor's code of conduct to the tor.git repo?2021-07-22T16:20:51ZIsis Lovecruftadd tor's code of conduct to the tor.git repo?It [looks like](https://github.com/torproject/tor/community) if we create a `CODE_OF_CONDUCT` or `CODE_OF_CONDUCT.md` file in the top-most directory of our repo, Github will do some nice things to let new contributors know about it (alon...It [looks like](https://github.com/torproject/tor/community) if we create a `CODE_OF_CONDUCT` or `CODE_OF_CONDUCT.md` file in the top-most directory of our repo, Github will do some nice things to let new contributors know about it (along with asking them to read the `CONTRIBUTING` guidelines). Should we add [our code of conduct](https://gitweb.torproject.org/community/policies.git/tree/code_of_conduct.txt)? Or add a link to where it can be found?Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/22747Pls document relay with restricted socket count2021-07-22T16:22:39ZTracPls document relay with restricted socket countThere is documentation in the Tor manual about how to alleviate the problem of constrained socket memory (ConstrainedSockets, ConstrainedSockSize), but not about a restricted number of sockets.
The problem of a restricted number of TCP ...There is documentation in the Tor manual about how to alleviate the problem of constrained socket memory (ConstrainedSockets, ConstrainedSockSize), but not about a restricted number of sockets.
The problem of a restricted number of TCP sockets is particularly acute in OpenVZ VPSs. A vendor may offer a great deal of bandwidth, but then restrict the practical use of it by imposing a low limit on the number of sockets in use.
So... how do I tell my relay to use no more than n TCP sockets?
-------------------------------------
```
# cat /proc/user_beancounters | grep sock
numtcpsock 3 4 3000 3000
othersockbuf 46240 108960 20571088 28942177
numothersock 42 56 3000 3000
```
**Trac**:
**Username**: tmpname0901Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/arti/-/issues/291Broken link(s) in docs depending on features2022-01-20T18:10:25ZIan Jacksoniwj@torproject.orgBroken link(s) in docs depending on featuresOn my system file:///volatile/rustcargo/Rustup/Arti/arti/target/doc/arti_client/index.html has this:
> by calling `[tor_rtcompat::async_std::current_runtime]`, which
i.e. a busted link.
This is probably only present when you're buildi...On my system file:///volatile/rustcargo/Rustup/Arti/arti/target/doc/arti_client/index.html has this:
> by calling `[tor_rtcompat::async_std::current_runtime]`, which
i.e. a busted link.
This is probably only present when you're building the docs with --all-features. but ff you build docs *without* --all-features you get more non-link stuff and some compiler warnings about them....Arti 0.1.0 release: Okay for experimental embeddingIan Jacksoniwj@torproject.orgIan Jacksoniwj@torproject.orghttps://gitlab.torproject.org/tpo/core/arti/-/issues/283Declare a MSRV policy2022-01-20T13:59:37ZNick MathewsonDeclare a MSRV policyWe should have a policy about our minimum supported rust version, and how/if it changes going forward. Since this is part of our promise to users, it should go in the %"Arti 0.1.0 release: Okay for experimental embedding" milestone.
S...We should have a policy about our minimum supported rust version, and how/if it changes going forward. Since this is part of our promise to users, it should go in the %"Arti 0.1.0 release: Okay for experimental embedding" milestone.
Split from #208.Arti 0.1.0 release: Okay for experimental embeddingNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/arti/-/issues/212Ship more example programs with Arti 0.1.02022-02-24T19:39:47ZNick MathewsonShip more example programs with Arti 0.1.0In #164, we brainstormed a bunch of example programs that we might right in order to show people how to use Arti. We should write and ship more of those with Arti 0.1.0.In #164, we brainstormed a bunch of example programs that we might right in order to show people how to use Arti. We should write and ship more of those with Arti 0.1.0.Arti 0.1.0 release: Okay for experimental embeddinghttps://gitlab.torproject.org/tpo/web/community/-/issues/222Add new training slides to the community portal2022-02-03T22:06:15ZemmapeelAdd new training slides to the community portalWe should add the new training slides to the community portal, so they can be translated.
- [ ] Review slides to make a decision on orientation.We should add the new training slides to the community portal, so they can be translated.
- [ ] Review slides to make a decision on orientation.Sponsor 9 - Phase 5 - Usability and Community Intervention on Support for Democracy and Human RightsGusGushttps://gitlab.torproject.org/tpo/community/l10n/-/issues/40037Go through issues raised by translators in Transifex2021-08-05T08:31:28ZemmapeelGo through issues raised by translators in TransifexI started going through the issues translators raise in transifex, it takes some time, so I decided to open this ticket to account for the work.
Pending issues:
- [x] tpo:/about/history: "The network needed to be operated by entities wi...I started going through the issues translators raise in transifex, it takes some time, so I decided to open this ticket to account for the work.
Pending issues:
- [x] tpo:/about/history: "The network needed to be operated by entities with diverse interests and trust assumptions, and the software needed to be free and open to maximize transparency and separation." - [Separation? of what, concerns maybe? is not clear what does it mean regarding free and open software. Also, maybe is 'open source', not 'open'.](https://gitlab.torproject.org/tpo/web/tpo/-/issues/192)
- [ ] "In 2007, the organization began developing bridges to the Tor network to address censorship, such as the need to get around government firewalls, in order for its users to access the open web." - needs to be rephrased to be better understood:'... began developing bridges as an addition to the Tor network to provide solutions against censorship, such as government firewalls, to help users to maintain access to the open web.
- [x] Suggest feedback: change 'suggest feedback' on our lektor templates for 'give feedback' or 'leave a suggestion' (see in the bottom at for example: https://support.torproject.org/misc/bug-or-feedback/ )
- [x] in https://tb-manual.torproject.org/circumvention/ we say: `Or, if you have Tor Browser running, click on "Preferences" in the hamburger menu and then on "Tor" in the sidebar.` But there is no "Tor" sidebar in preferences.
- [ ] [main ticket](https://gitlab.torproject.org/tpo/web/manual/-/issues/94) On the manual, at https://tb-manual.torproject.org/mobile-tor/ , we say: When Tor Browser is running, you would see so in your phone's notification panel along with the button "NEW IDENTITY". But:
- to see the "new identity" button you must expand the notification.
- better: "in your device's notification panel"Sponsor 9 - Phase 5 - Usability and Community Intervention on Support for Democracy and Human Rightsemmapeelemmapeelhttps://gitlab.torproject.org/tpo/core/arti/-/issues/288Config "errors If a required field has not been initialized" docs message2022-03-01T17:27:29ZIan Jacksoniwj@torproject.orgConfig "errors If a required field has not been initialized" docs messageStruct arti_client::config::circ::PreemptiveCircuitConfigBuilder
```
| errors If a required field has not been initialized
```
But there are no required fields. This is something `derive_builder` put in. We should suppress the message...Struct arti_client::config::circ::PreemptiveCircuitConfigBuilder
```
| errors If a required field has not been initialized
```
But there are no required fields. This is something `derive_builder` put in. We should suppress the message somehow.
Unless, of course, all of this is abolished in response to #285Arti 1.0.0: Ready for production use