The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2021-07-22T16:23:44Zhttps://gitlab.torproject.org/tpo/core/tor/-/issues/18891Make it clear that Address only works for IPv42021-07-22T16:23:44ZteorMake it clear that Address only works for IPv4Some operators expect Address to work with an IPv6 address, either a literal, or a DNS name with an AAAA record.
We should make this clearer in the manual.Some operators expect Address to work with an IPv6 address, either a literal, or a DNS name with an AAAA record.
We should make this clearer in the manual.Tor: 0.3.2.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/18736[Manual] Add some information about sub-domain rules2021-07-22T16:23:44Zcypherpunks[Manual] Add some information about sub-domain ruleshttps://www.torproject.org/docs/tor-manual.html.en
> HIDDEN SERVICE OPTIONS
> The following options are used to configure a hidden service.
We need official statement about second-level domain(subdomain) of .onion.
Likely,
> this one(1...https://www.torproject.org/docs/tor-manual.html.en
> HIDDEN SERVICE OPTIONS
> The following options are used to configure a hidden service.
We need official statement about second-level domain(subdomain) of .onion.
Likely,
> this one(1) and,
> git.xxxxxxxxx.onion
are using second level domain.
I know only two URLs.
1: https://tor.stackexchange.com/questions/10068/sub-domain-of-onion-is-allowed-officialyTor: 0.3.2.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/18345Fix all doxygen "X is not documented" warnings2021-07-22T16:23:43ZteorFix all doxygen "X is not documented" warningsQuoting arma:
It occurred to me while looking at the doxygen comment for
router_is_already_dir_fetching_ds() that if we had something go through
and complain about all cases where there's a function argument that is
not mentione...Quoting arma:
It occurred to me while looking at the doxygen comment for
router_is_already_dir_fetching_ds() that if we had something go through
and complain about all cases where there's a function argument that is
not mentioned by `<b>parameter</b>` (with the markup) in the doxygen
comment... we would end up with a lot of complaints.
We could fix this by placing `<b></b>` around documented parameters, and by documented undocumented parameters.
There might even be a way to semi-automatically do this using a script, and then clean up any mismatches.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/18312MapAddress should recommend fingerprints, not nicknames2021-07-22T16:23:43ZteorMapAddress should recommend fingerprints, not nicknamesSince we stopped voting on nicknames, they've become even less reliable as a way to identify a relay.
MapAddress (and similar man page entries) should be updated to recommend the use of fingerprints, not nicknames.Since we stopped voting on nicknames, they've become even less reliable as a way to identify a relay.
MapAddress (and similar man page entries) should be updated to recommend the use of fingerprints, not nicknames.Tor: 0.2.8.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/20435Update tor man page with AuthDirGuardBWGuarantee of 2 MBytes2021-07-22T16:23:16ZteorUpdate tor man page with AuthDirGuardBWGuarantee of 2 MBytesBugfix on ticket legacy/trac#12690, commit a57c07b in tor-0.2.5.6-alpha.
~~There is no tor-0.2.5.6-alpha in the versions list, see legacy/trac#20434.~~Bugfix on ticket legacy/trac#12690, commit a57c07b in tor-0.2.5.6-alpha.
~~There is no tor-0.2.5.6-alpha in the versions list, see legacy/trac#20434.~~Tor: 0.3.0.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/20153VirtualAddrNetworkIPv6 man entry should say "[FC00::]/7"2021-07-22T16:23:16ZteorVirtualAddrNetworkIPv6 man entry should say "[FC00::]/7"IPv6 addresses have to have some colons somewhere.IPv6 addresses have to have some colons somewhere.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/20152Update DirAuthority man entry for client begindir, no IPv6 DirPort2021-07-22T16:23:16ZteorUpdate DirAuthority man entry for client begindir, no IPv6 DirPortTor's DirAuthority entry says:
Tor will contact the authority at address:port (the DirPort) to
download directory documents. If an IPv6 address is supplied, Tor
will also download directory documents at t...Tor's DirAuthority entry says:
Tor will contact the authority at address:port (the DirPort) to
download directory documents. If an IPv6 address is supplied, Tor
will also download directory documents at the IPv6 address on the
DirPort.
But no Tor instance uses the IPv6 DirPort:
* clients (>= 0.2.8) use the IPv4 ORPort,
* clients (< 0.2.8) and relays use the IPv4 DirPort.Tor: 0.3.2.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/20117Update PathsNeededToBuildCircuits man page entry with actual default2021-07-22T16:23:16ZteorUpdate PathsNeededToBuildCircuits man page entry with actual default"if the directory authorities do not choose a value, Tor will use 0.6.""if the directory authorities do not choose a value, Tor will use 0.6."Tor: 0.2.9.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/20035Identify client-specific options that work with hidden services2021-07-22T16:23:16ZteorIdentify client-specific options that work with hidden servicesMany of the "client-specific" options in the tor manual page work with Hidden Services.
Others, such as Socks/Trans/NATD/DNSPort, do not.
It would be great to split up the client-only section into those options that truly only work for...Many of the "client-specific" options in the tor manual page work with Hidden Services.
Others, such as Socks/Trans/NATD/DNSPort, do not.
It would be great to split up the client-only section into those options that truly only work for clients, and those that also affect the behaviour of hidden services (and bridge relays, and relays, and authorities).
For example, when a bridge relay builds an anonymous 3-hop path to submit its descriptor, it is likely affected by all the client options that affect node selection. (Unless we specifically disable them for servers.)
And a hidden service's paths are affected by these same options.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/20014GETINFO version in torspec is inconsistent with the implementation2021-07-22T16:23:16ZteorGETINFO version in torspec is inconsistent with the implementationThe torspec description of GETINFO version is:
```
"version" -- The version of the server's software, including the name
of the software. (example: "Tor 0.0.9.4")
```
But tor responds:
```
GETINFO version
250-version=0.2.8.6 (...The torspec description of GETINFO version is:
```
"version" -- The version of the server's software, including the name
of the software. (example: "Tor 0.0.9.4")
```
But tor responds:
```
GETINFO version
250-version=0.2.8.6 (git-4d217548e3f05569)
250 OK
```
The "Tor " is missing from the response. We should remove it from the spec.Tor: 0.3.0.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/19381wish: conditionally build man page (tor.1) and html doc using independent con...2021-07-22T16:23:16Ztoralfwish: conditionally build man page (tor.1) and html doc using independent configure options
Currently it is practice in Gentoo Linux to install at least the the man page.
However that creation is coupled to the html files too (right ?) and therefore forces the Tor package to pull in more - otherwise completely unneeded - depen...
Currently it is practice in Gentoo Linux to install at least the the man page.
However that creation is coupled to the html files too (right ?) and therefore forces the Tor package to pull in more - otherwise completely unneeded - dependent packages.
De-coupling tor.1 from the html docs would at least allow us in the Gentoo Linux universe to get rid of packages like libxslt and friends at a dedicated Tor relay.Tor: 0.4.2.x-finalDamian JohnsonDamian Johnsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/21720Update Directory Server Options section for automatic DirCache2021-07-22T16:22:56ZteorUpdate Directory Server Options section for automatic DirCacheThis section header is wrong:
```
DIRECTORY SERVER OPTIONS
The following options are useful only for directory servers (that is,
if DirPort is non-zero):
```
It should read:
```
DIRECTORY SERVER OPTIONS
The followin...This section header is wrong:
```
DIRECTORY SERVER OPTIONS
The following options are useful only for directory servers (that is,
if DirPort is non-zero):
```
It should read:
```
DIRECTORY SERVER OPTIONS
The following options are useful only for directory servers:
(Relays with enough bandwidth automatically become directory
servers, see DirCache for details.)
```Tor: 0.3.0.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/21715Possible error in the Tor manual (section "NumEntryGuards NUM")2021-07-22T16:22:56ZTracPossible error in the Tor manual (section "NumEntryGuards NUM")In both, the Tor -stable Manual and the Tor -alpha Manual, there is a possible error in the section "NumEntryGuards NUM".
Literally, this is the description of the "NumEntryGuards NUM" option: "If UseEntryGuards is set to 1, we will tr...In both, the Tor -stable Manual and the Tor -alpha Manual, there is a possible error in the section "NumEntryGuards NUM".
Literally, this is the description of the "NumEntryGuards NUM" option: "If UseEntryGuards is set to 1, we will try to pick a total of NUM routers as long-term entries for our circuits. If NUM is 0, we try to learn the number from the NumEntryGuards consensus parameter, and default to 3 if the consensus parameter isn’t set. (Default: 0)".
But I think the correct description would be: "If UseEntryGuards is set to 1, we will try to pick a total of NUM routers as long-term entries for our circuits. If NUM is 0, we try to learn the number from the NumEntryGuards consensus parameter, and default to 1 if the consensus parameter isn’t set. (Default: 0)". Because Tor currently chooses a single entry guard, does not choose three.
**Trac**:
**Username**: moe-szyslak-0Tor: 0.3.1.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/21405Clarify "address" in man page: IPv4, IPv6, hostname?2021-07-22T16:22:56ZteorClarify "address" in man page: IPv4, IPv6, hostname?The DirAuthority line only takes an IPv4 address as an "address".
But other torrc options take IPv6 addresses or hostnames.
We should clarify what we mean when we say "address".
Reported by Andrew Smith:
https://lists.torproject.org/pi...The DirAuthority line only takes an IPv4 address as an "address".
But other torrc options take IPv6 addresses or hostnames.
We should clarify what we mean when we say "address".
Reported by Andrew Smith:
https://lists.torproject.org/pipermail/tor-relays/2017-February/011876.htmlTor: 0.3.2.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/21151man page lists wrong default for DataDirectory2021-07-22T16:22:56ZRoger Dingledineman page lists wrong default for DataDirectoryIn my doc/tor.1 in my git checkout, I have
```
DataDirectory DIR
Store working data in DIR (Default: /usr/local/var/lib/tor)
```
Apparently the underlying code (in tor.1.txt) is
```
[[DataDirectory]] **DataDirectory** ...In my doc/tor.1 in my git checkout, I have
```
DataDirectory DIR
Store working data in DIR (Default: /usr/local/var/lib/tor)
```
Apparently the underlying code (in tor.1.txt) is
```
[[DataDirectory]] **DataDirectory** __DIR__::
Store working data in DIR (Default: @LOCALSTATEDIR@/lib/tor)
```
It looks like if DataDirectory remains unset (which is the default), on Windows you get
```
get_windows_conf_root()
```
whereas on other platforms, you get
```
d = "~/.tor";
```
and then it's only if you're running as root that you get
```
fn = tor_strdup(LOCALSTATEDIR PATH_SEPARATOR "tor");
```
But I admit that all of this is confusing, because we have functions like `find_torrc_filename()` and `get_default_conf_file()` and `get_torrc_fname()` so it's hard to say for sure.Tor: 0.3.1.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/21124ChangeLog: reference to 18625 actually corresponds to 186262021-07-22T16:22:54ZteorChangeLog: reference to 18625 actually corresponds to 18626The ChangeLog lines:
```
- Avoid spurious failures from configure files related to calling
exit(0) in TOR_SEARCH_LIBRARY. Fixes bug 18625; bugfix on
0.2.0.1-alpha. Patch from "cypherpunks".
```
actually correspond to lega...The ChangeLog lines:
```
- Avoid spurious failures from configure files related to calling
exit(0) in TOR_SEARCH_LIBRARY. Fixes bug 18625; bugfix on
0.2.0.1-alpha. Patch from "cypherpunks".
```
actually correspond to legacy/trac#18626.
This issue was added in commit db13527.Tor: 0.3.0.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/21122Document all options that can't be changed while tor is running2021-07-22T16:22:54ZteorDocument all options that can't be changed while tor is runningTurns out we've been pretty bad at keeping the man page up to date with options_transition_allowed().Turns out we've been pretty bad at keeping the man page up to date with options_transition_allowed().Tor: 0.3.0.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/21109apparent inconsistency in prop2642021-07-22T16:22:54Zcypherpunksapparent inconsistency in prop264In A.1, "the protocol list for all current Tor versions" says HSDir=1, there is no version 2. But in A.2, both clients and relays are required to support HSDir=2, which A.1 just said does not exist.
https://gitweb.torproject.org/torspec...In A.1, "the protocol list for all current Tor versions" says HSDir=1, there is no version 2. But in A.2, both clients and relays are required to support HSDir=2, which A.1 just said does not exist.
https://gitweb.torproject.org/torspec.git/tree/proposals/264-subprotocol-versions.txt#n304Tor: 0.3.3.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/20486HiddenServiceDirectory is created if it doesn't exist2021-07-22T16:22:54ZteorHiddenServiceDirectory is created if it doesn't existSplit off legacy/trac#20484
* Update the man page, which incorrectly says that HiddenServiceDirectory must exist - tor creates the HiddenServiceDirectory if it doesn't existSplit off legacy/trac#20484
* Update the man page, which incorrectly says that HiddenServiceDirectory must exist - tor creates the HiddenServiceDirectory if it doesn't existTor: 0.3.0.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/22951NETINFO cells are mandatory, but tor-spec says "may"2021-07-22T16:22:40ZteorNETINFO cells are mandatory, but tor-spec says "may"In this context, "may" is ambiguous: NETINFO is actually a mandatory requirement:
```
cell (4.5). As soon as it gets the CERTS cell, the initiator knows
whether the responder is correctly authenticated. At this point the
- initi...In this context, "may" is ambiguous: NETINFO is actually a mandatory requirement:
```
cell (4.5). As soon as it gets the CERTS cell, the initiator knows
whether the responder is correctly authenticated. At this point the
- initiator may send a NETINFO cell if it does not wish to
+ initiator MUST send a NETINFO cell if it does not wish to
authenticate, or a CERTS cell, an AUTHENTICATE cell (4.4), and a NETINFO
cell if it does. When this handshake is in use, the first cell must
be VERSIONS, VPADDING or AUTHORIZE, and no other cell type is allowed to
intervene besides those specified, except for PADDING and VPADDING cells.
```
https://gitweb.torproject.org/torspec.git/tree/tor-spec.txt#n482Tor: 0.3.2.x-final