The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2023-11-30T19:09:57Zhttps://gitlab.torproject.org/tpo/web/tpo/-/issues/297Incorrect Recommended Version Displayed2023-11-30T19:09:57Zpyrodie18Incorrect Recommended Version Displayed<!--
* Use this issue template for reporting a new bug.
-->
### Summary
**Summarize the bug encountered concisely.**
### Steps to reproduce:
**How one can reproduce the issue - this is very important.**
1. Navigate to https://www.tor...<!--
* Use this issue template for reporting a new bug.
-->
### Summary
**Summarize the bug encountered concisely.**
### Steps to reproduce:
**How one can reproduce the issue - this is very important.**
1. Navigate to https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions/
### What is the current bug behavior?
Results are `[ "10.0.5", "10.0.5-MacOS", "10.0.5-Linux", "10.0.5-Windows", "10.5a4", "10.5a4-MacOS", "10.5a4-Linux", "10.5a4-Windows" ]`
### What is the expected behavior?
The correct version is 11.0.10 according to the direct download links on the page.
### Environment
Windows system using Chrome
### Relevant logs and/or screenshots
N/Ahttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40134Log messages from client NAT check failures are confusing2022-05-31T22:11:07ZDavid Fifielddcf@torproject.orgLog messages from client NAT check failures are confusingWhen [`CheckIfRestrictedNAT`](https://gitweb.torproject.org/pluggable-transports/snowflake.git/tree/common/nat/nat.go?h=v2.1.0#n34) fails with an error, it logs a message like `Error: no response from server`. But in context, the message...When [`CheckIfRestrictedNAT`](https://gitweb.torproject.org/pluggable-transports/snowflake.git/tree/common/nat/nat.go?h=v2.1.0#n34) fails with an error, it logs a message like `Error: no response from server`. But in context, the messages confusingly appear to refer to the broker rendezvous, not the STUN server connection:
```
Target URL: snowflake-broker.torproject.net.global.prod.fastly.net
Front URL: cdn.sstatic.net
Error: no response from server
Error: no response from server
Error: no response from server
```
In this situation, communication with the broker has succeeded and a proxy has been assigned, but the client is having trouble checking its own NAT type. These log messages should say "STUN" or "NAT" somewhere in them, and ideally also the address of the server that failed (possibly subject to safe-log scrubbing).
Refactoring suggestion: instead of having a log call at every return of `isRestrictedMapping`, you can use [`fmt.Errorf("...: %w")`](https://pkg.go.dev/errors) to wrap the underlying error with additional context, and just return the error. That way, the logging can be consolidated in [`updateNATType`](https://gitweb.torproject.org/pluggable-transports/snowflake.git/tree/client/lib/snowflake.go?h=v2.1.0#n239), which is also where the STUN server address can be added and displayed.itchyonionitchyonionhttps://gitlab.torproject.org/tpo/web/support/-/issues/300Search bar with fixed width2022-07-26T20:57:11ZGusSearch bar with fixed widthKeeping the search bar a fixed width (like \~600px) before the mobile breakpoint would be great too, otherwise it gets a little short at tablet sizes.
https://gitlab.torproject.org/tpo/web/support/-/merge_requests/108#note_2799154Keeping the search bar a fixed width (like \~600px) before the mobile breakpoint would be great too, otherwise it gets a little short at tablet sizes.
https://gitlab.torproject.org/tpo/web/support/-/merge_requests/108#note_2799154Sponsor 9 - Phase 6 - Usability and Community Intervention on Support for Democracy and Human Rightshttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40471Integrate libwinsane into build and link into tor daemon2023-11-01T19:19:42ZrichardIntegrate libwinsane into build and link into tor daemonlibwinsane: https://github.com/skeeto/scratch/tree/master/libwinsane
Would fix utf8 path handling on Windows in tor. We can probably get this working by pointing LDFLAGS/LDLIBS to the output .o file, but long term we should also patch ...libwinsane: https://github.com/skeeto/scratch/tree/master/libwinsane
Would fix utf8 path handling on Windows in tor. We can probably get this working by pointing LDFLAGS/LDLIBS to the output .o file, but long term we should also patch tor with new config option (--enable-libwinsane or similar) which handles this 'correctly' on windows.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40121add prometheus support to snowflake proxy2024-02-14T16:48:40Zcypherpunksadd prometheus support to snowflake proxyfrom today's relay meetup:
For better maintainability and service monitoring please add a prometheus exporter to snowflake proxy with at least the following data:
- bandwidth
- memory usage
- uptime
- sockets/connections
- version
Th...from today's relay meetup:
For better maintainability and service monitoring please add a prometheus exporter to snowflake proxy with at least the following data:
- bandwidth
- memory usage
- uptime
- sockets/connections
- version
This will allow us to detect when the service crashed and got restarted or uses significantly less/more bw/memory/sockets.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40118Fix misleading proxy usage statistics message on launch2022-05-31T20:36:21Zmeskiomeskio@torproject.orgFix misleading proxy usage statistics message on launchAs soon as you launch the proxy it displays:
```
2022/03/23 09:27:18 In the last 1h0m0s, there were 0 connections. Traffic Relayed ↑ 0 B, ↓ 0 B.
```
I guess it will be better to don't display that until some time has actually passed. Or ...As soon as you launch the proxy it displays:
```
2022/03/23 09:27:18 In the last 1h0m0s, there were 0 connections. Traffic Relayed ↑ 0 B, ↓ 0 B.
```
I guess it will be better to don't display that until some time has actually passed. Or at least don't say `In the last 1h`, because it hasn't being running 1hour.itchyonionitchyonionhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40117display the proxy NAT type in the logs2022-11-16T18:19:45Zmeskiomeskio@torproject.orgdisplay the proxy NAT type in the logsThe proxy NAT type is only being written to the logs if the `-verbose` flag is set. Will be nice to display it anyway.The proxy NAT type is only being written to the logs if the `-verbose` flag is set. Will be nice to display it anyway.itchyonionitchyonionhttps://gitlab.torproject.org/tpo/network-health/metrics/website/-/issues/40044Update BridgeDB's Bridge Pool Assignments documentation2022-09-05T16:56:14ZGeorg KoppenUpdate BridgeDB's Bridge Pool Assignments documentationLooking over a recent bridge pool assignment file one can see:
```
005fd4d7decbb250055b861579e6fdc79ad17bee email transport=obfs4 ip=4 blocklist=ru
00782946f4c54ce1d028f21e541ef8440ecaa0ee settings ip=4 blocklist=ru
00a4295a8477453d6afe1...Looking over a recent bridge pool assignment file one can see:
```
005fd4d7decbb250055b861579e6fdc79ad17bee email transport=obfs4 ip=4 blocklist=ru
00782946f4c54ce1d028f21e541ef8440ecaa0ee settings ip=4 blocklist=ru
00a4295a8477453d6afe1ca4c2f19e3708e63fc4 email ip=4
00afd5ca2f89305b89171450cf34f247858f14e8 settings transport=obfs4 ip=4 blocklist=ru
00e1ae6cb75e47e363e6aef9f67a49c0e854fde7 moat transport=obfs4 ip=4
00e6f1d633d4e29db31f43d1e6e3e928e5c1810d moat transport=obfs4 ip=4 blocklist=ru
0110a6cf41a07637808fff79c0783ff37462b525 email ip=4 blocklist=ru
01292375ae04f41e7453d8e85df446c22a8d7101 settings ip=4 port=443 blocklist=ru
01341c9b4bc01b3a11e80a645a0bde45db02f04b moat transport=obfs4 ip=4
01436ef5b118fd95004a75f4616a6094d4aa4748 moat transport=obfs4 ip=4
0145c4524211a250519864627e4ae31eecccd39f moat transport=obfs4 ip=4
01520c1bb2c46bf0f54969b71217be04c1f8eb58 telegram transport=obfs4 ip=4 port=443
```
. However, our website does not know anything about `settings` or `telegram` or `ip` or `blocklist` or `transport` etc.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40116Soften Tor log output for non critical events2022-04-12T15:57:06ZCecylia BocovichSoften Tor log output for non critical eventsWe had a forum post from a user who interpreted one of the snowflake connection events as a critical failure of snowflake: https://forum.torproject.net/t/snowflake-does-not-work-anymore/2650/2
While a failure to connect to the broker ca...We had a forum post from a user who interpreted one of the snowflake connection events as a critical failure of snowflake: https://forum.torproject.net/t/snowflake-does-not-work-anymore/2650/2
While a failure to connect to the broker can be critical, a failure to open a data channel with a snowflake is not unusual and snowflake can easily recover from it. Let's make a small change of the log message from "connection failed" to "trying a new proxy: [error message]" or something like thatitchyonionitchyonionhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40115Scrub pt.Log calls like other logs2022-11-07T16:25:28ZDavid Fifielddcf@torproject.orgScrub pt.Log calls like other logs!67 added [`ptEventLogger`](https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/blob/bd636a1374efb514bbc40acbd1dcaf0ecec26916/client/lib/pt_event_logger.go) which sends messages to the managing process usin...!67 added [`ptEventLogger`](https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/blob/bd636a1374efb514bbc40acbd1dcaf0ecec26916/client/lib/pt_event_logger.go) which sends messages to the managing process using `pt.Log`. But these logs are not scrubbed of IP addresses the way all other logs are scrubbed (as in
#21304).
I saw this in the Tor Logs in Tor Browser:
```
3/17/22, 02:24:50.145 [NOTICE] Managed proxy "./TorBrowser/Tor/PluggableTransports/snowflake-client": offer created
3/17/22, 02:24:50.146 [NOTICE] Managed proxy "./TorBrowser/Tor/PluggableTransports/snowflake-client": broker failure dial tcp: lookup cdn.sstatic.net on 192.168.0.1:53: dial udp 192.168.0.1:53: connect: network is unreachable
```itchyonionitchyonionhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40853use Subprocess.jsm to launch tor2023-01-10T15:14:41ZMark Smithuse Subprocess.jsm to launch torIn Firefox 49, Mozilla added a new Subprocess.jsm module (they use it to implement the WebExtensions Native Messaging API). Kathy and I have not looked at it closely yet, but this module may provide a better way for Tor Launcher to start...In Firefox 49, Mozilla added a new Subprocess.jsm module (they use it to implement the WebExtensions Native Messaging API). Kathy and I have not looked at it closely yet, but this module may provide a better way for Tor Launcher to start and manage the tor process. In particular, Subprocess.jsm provides access to stderr which would allow Tor Launcher to capture all output produced by tor.
Docs:
https://firefox-source-docs.mozilla.org/toolkit/modules/subprocess/toolkit_modules/subprocess/index.htmlSponsor 131 - Phase 5 - Ongoing MaintenancePier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/web/community/-/issues/259What happens to bad relays - outdated2023-05-11T18:39:05ZcypherpunksWhat happens to bad relays - outdatedThe page https://community.torproject.org/relay/community-resources/bad-relays/ lists three things that can happen with bad relays: BadExit, Invalid and Reject. As of now, relay cannot be made Invalid (since proposal 272), but can (or no...The page https://community.torproject.org/relay/community-resources/bad-relays/ lists three things that can happen with bad relays: BadExit, Invalid and Reject. As of now, relay cannot be made Invalid (since proposal 272), but can (or not yet? should be clarified) become MiddleOnly.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40103mix of past and present in snowflake proxy log2022-07-09T04:20:15Ztoralfmix of past and present in snowflake proxy log"In the last 1h0m0s, there are 28 connections. Traffic Relayed ↑ 273 MB, ↓ 273 MB."
are -> were
or ?"In the last 1h0m0s, there are 28 connections. Traffic Relayed ↑ 273 MB, ↓ 273 MB."
are -> were
or ?https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40429hash_incrementals script hangs on sha256sum when no .incremental.mar files ar...2022-02-14T15:01:10Zrichardhash_incrementals script hangs on sha256sum when no .incremental.mar files are presentRan into this today when attempting to build tbb-11.5a4-build1
I had incorrectly set `torbrowser_incremental_from` to 11.5a3 which was an Android-only release. As 11.5a4 is Desktop-only, there were no .incremental-mar files to be used.
...Ran into this today when attempting to build tbb-11.5a4-build1
I had incorrectly set `torbrowser_incremental_from` to 11.5a3 which was an Android-only release. As 11.5a4 is Desktop-only, there were no .incremental-mar files to be used.
We should verify that the set of filenames output by `ls -1 | grep '\.incremental\.mar$' | sort` is not empty, otherwise sha256sum will hang indefinitely waiting for data to be read in from stdin.boklmboklmhttps://gitlab.torproject.org/tpo/tpa/anon_ticket/-/issues/51"Generate identifier" "Create identifier"2023-12-07T14:54:45Zcypherpunks"Generate identifier" "Create identifier"A detail of user interface:
When I first landed on the anonymous ticket site, it offered "Create identifier" and "Login with identifier". However the Main Links bar on the left has "Generate identifier". Probably the result is the same, ...A detail of user interface:
When I first landed on the anonymous ticket site, it offered "Create identifier" and "Login with identifier". However the Main Links bar on the left has "Generate identifier". Probably the result is the same, but labeling the link differently makes it not obvious.https://gitlab.torproject.org/tpo/web/support/-/issues/280Discourage more running a browser in parallel to Tor Browser2022-11-30T16:52:28ZGeorg KoppenDiscourage more running a browser in parallel to Tor BrowserWe have https://support.torproject.org/tbb/tbb-17/ for answering the question about whether it is safe to running a different browser in parallel to Tor Browser.
It's correct that *Tor Browser's* privacy features are unaffected by that ...We have https://support.torproject.org/tbb/tbb-17/ for answering the question about whether it is safe to running a different browser in parallel to Tor Browser.
It's correct that *Tor Browser's* privacy features are unaffected by that but we should stress more the risk of linking both browsing activities.
Maybe something like
```
If you run Tor Browser and another browser at the same time, it won't affect Tor's performance or privacy properties. However, be aware that when using Tor and another browser at the same time, your Tor activity could be linked to your non-Tor (real) IP from the other browser, simply by moving your mouse from one browser into the other. Or you may imply forget and accidentally use that non-private browser to do something that you intended to do in Tor Browser instead.
```
Thanks to `ForMariosTheHacker` at h1 to point that out.GusGushttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40733MOZ_ASSERT on about:tor2022-10-04T19:46:41ZPier Angelo VendrameMOZ_ASSERT on about:tor### Summary
`about:tor` crashes in debug builds, because a `MOZ_ASSERT` is triggered.
### Steps to reproduce:
1. Compile Tor Browser with `ac_add_options --enable-debug` in the `mozconfig`
2. Run Tor Browser
3. Connect to the Tor net...### Summary
`about:tor` crashes in debug builds, because a `MOZ_ASSERT` is triggered.
### Steps to reproduce:
1. Compile Tor Browser with `ac_add_options --enable-debug` in the `mozconfig`
2. Run Tor Browser
3. Connect to the Tor network
4. You will see the tab crashing
5. Try to go to any other address, it will work
6. Try to write `about:tor` in the address bar, and go there: the tab will crash
### What is the current bug behavior?
The tab crashes, and Tor Browser asks you whether you want to reload it.
But if you press it, the tab crashes again. Other tabs work normally.
If you attach a debugger to Tor Browser, it will stop in one of the `MOZ_ASSERT` of `nsresult NS_CompareLoadInfoAndLoadContext(nsIChannel* aChannel)`.
File: `netwerk/base/nsNetUtil.cpp`, line: around 3092 (the first `MOZ_ASSERT` of the function).
Visual Studio tells that it is a dereferenced `nullptr`, but I do not understand why (it seem to me it is using normal objects allocated on stack; I will have to investigate more).
### What is the expected behavior?
I wanted to see the normal `about:tor` page :smile:
### Environment
I tested on a 91.3.0/11.0.1 Windows build compiled by me, with `ac_add_options --enable-debug`.
This happened both on Windows 10 and Windows 11.
This happens on Linux as well (remember to update the `build` as well, to copy debug `geckodriver`).
### Relevant logs and/or screenshots
![about_tor](/uploads/16177a720b8246d5a840c038ce77b1aa/about_tor.png)https://gitlab.torproject.org/tpo/web/support/-/issues/275Dead link on FAQ2022-01-13T18:10:35ZcypherpunksDead link on FAQOn main page of support website, in section named "Gmail warns me that my account may have been compromised", there is a link to fscked.org, which seems to be a long-dead mikeperry's website.On main page of support website, in section named "Gmail warns me that my account may have been compromised", there is a link to fscked.org, which seems to be a long-dead mikeperry's website.https://gitlab.torproject.org/tpo/web/tpo/-/issues/262Remove jinja template escaping from "Become a Member" section2022-07-09T04:26:25ZGusRemove jinja template escaping from "Become a Member" sectionhttps://www.torproject.org/about/membership/
```
Become a Member
{ _("Join the Tor Project Membership Program and demonstrate your commitment to privacy online and become more deeply involved in the Tor community. Email us at giving@to...https://www.torproject.org/about/membership/
```
Become a Member
{ _("Join the Tor Project Membership Program and demonstrate your commitment to privacy online and become more deeply involved in the Tor community. Email us at giving@torproject.org. to get started.") }
```emmapeelemmapeelhttps://gitlab.torproject.org/tpo/anti-censorship/rdsys/-/issues/70Unexpected Naming Scheme in Semantic Versioning Represention Structure2022-09-27T09:58:21ZshelikhooUnexpected Naming Scheme in Semantic Versioning Represention StructureIn the [Version](https://gitlab.torproject.org/tpo/anti-censorship/rdsys/-/blob/f7d0b7451e242a711f3c9887348b84a6ae054c38/pkg/usecases/resources/links.go#L14) Structure, "Major" version is named "Mayor" version, which is different from it...In the [Version](https://gitlab.torproject.org/tpo/anti-censorship/rdsys/-/blob/f7d0b7451e242a711f3c9887348b84a6ae054c38/pkg/usecases/resources/links.go#L14) Structure, "Major" version is named "Mayor" version, which is different from its [definition](https://semver.org/) form. If this is unintentional, we could consider renaming it to its definition form.