The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2022-12-05T18:53:38Zhttps://gitlab.torproject.org/tpo/tpa/team/-/issues/40798TPA-RFC-31: outsource email services2022-12-05T18:53:38ZanarcatTPA-RFC-31: outsource email servicesThe proposal to host the entirety of our email services in-house, TPA-RFC-15, was officially rejected (see tpo/tpa/team#40363 and wiki-replica@ea20e615 for details). Now we need to figure out which part of email we'll outsource, and to ...The proposal to host the entirety of our email services in-house, TPA-RFC-15, was officially rejected (see tpo/tpa/team#40363 and wiki-replica@ea20e615 for details). Now we need to figure out which part of email we'll outsource, and to whom.
This ticket is to track the drafting and adoption of that proposal. Once that's done, new tickest should be created for those individual tasks.
quick brainstorm of a checklist:
- [x] brainstorm requirements here
- [x] adopt requirements
- [x] figure out what we'll do with the existing email services (e.g. probably retire submission?)
- [x] personas
- [x] list possible providers
- [x] generic
- [x] transactional
- [x] checkin with isa about what SLA we want
- [ ] officialize quotes, don't forget to mention SLA
- [ ] costs
- [x] staff, setup
- [x] staff, ongoing
- [ ] hosting
- [ ] timeline
- [ ] approval: same as TPA-RFC-15? (TPA, internal, ops, in that order?)
- [ ] deadline: maybe draft this within 2-3 weeks max, adoption in 4-6 weeks?
- [ ] review TPA-RFC-15 to see if we forgot any bits
any other ideas?
draft lives in https://gitlab.torproject.org/tpo/tpa/team/-/wikis/policy/tpa-rfc-31-outsource-emailimprove mail servicesanarcatanarcat2022-12-08https://gitlab.torproject.org/tpo/tpa/team/-/issues/40765User reporting "gmail couldn't verify whether it accually came from torprojec...2022-12-15T21:04:22Zal smithUser reporting "gmail couldn't verify whether it accually came from torproject.org" messageHi TPA, I'm passing along an issue that a user reported to me regarding our newsletter:
> I receive your newsletter and thanks for that!
> Now Gmail puts a warning about spam or malware on the mail.
> I would like to know your opinion o...Hi TPA, I'm passing along an issue that a user reported to me regarding our newsletter:
> I receive your newsletter and thanks for that!
> Now Gmail puts a warning about spam or malware on the mail.
> I would like to know your opinion on that.
> Should I worry?
>
> I link a pic to this mail to show you what it's all about!
>
> ![Screen_Shot_2022-05-18_at_10.43.53_AM](/uploads/3500a6cfdcfb904d0d58a66832f934f1/Screen_Shot_2022-05-18_at_10.43.53_AM.png)
>
> (It's in danish - I'll translate it:) Be careful with this message. Gmail couldn't verify whether it actually came from torproject.org.
> Avoid clicking links, downloading files or answering this message with personal data!
>
> What do you think of this?improve mail serviceshttps://gitlab.torproject.org/tpo/tpa/team/-/issues/40640Gmail rejects mail from submission.tpo as spam from time to time2022-12-15T20:33:26ZGeorg KoppenGmail rejects mail from submission.tpo as spam from time to timeThis is at least the second case where a mail I sent to a Gmail address bounces back and could not get delivered (I needed to fall back to using Riseup). Here is what I got (the mail address I sent to being redacted):
```
This is the mai...This is at least the second case where a mail I sent to a Gmail address bounces back and could not get delivered (I needed to fall back to using Riseup). Here is what I got (the mail address I sent to being redacted):
```
This is the mail system at host submit-01.torproject.org.
I'm sorry to have to inform you that your message could not
be delivered to one or more recipients. It's attached below.
For further assistance, please send mail to postmaster.
If you do so, please include this problem report. You can
delete your own text from the attached returned message.
The mail system
<XXX@gmail.com>: host gmail-smtp-in.l.google.com[2a00:1450:4010:c02::1b]
said: 550-5.7.26 This message does not have authentication information or
fails to 550-5.7.26 pass authentication checks. To best protect our users
from spam, the 550-5.7.26 message has been blocked. Please visit 550-5.7.26
https://support.google.com/mail/answer/81126#authentication for more 550
5.7.26 information. o25-20020ac24359000000b004437b0e446asi11253489lfl.62 -
gsmtp (in reply to end of DATA command)
Reporting-MTA: dns; submit-01.torproject.org
X-Postfix-Queue-ID: A948A80095
X-Postfix-Sender: rfc822; gk@torproject.org
Arrival-Date: Tue, 1 Mar 2022 08:03:06 +0000 (UTC)
Final-Recipient: rfc822; XXX@gmail.com
Original-Recipient: rfc822;XXX@gmail.com
Action: failed
Status: 5.7.26
Remote-MTA: dns; gmail-smtp-in.l.google.com
Diagnostic-Code: smtp; 550-5.7.26 This message does not have authentication
information or fails to 550-5.7.26 pass authentication checks. To best
protect our users from spam, the 550-5.7.26 message has been blocked.
Please visit 550-5.7.26
https://support.google.com/mail/answer/81126#authentication for more 550
5.7.26 information. o25-20020ac24359000000b004437b0e446asi11253489lfl.62 -
gsmtp
```improve mail serviceshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/27202Tor unable to bind one of the listener ports2020-06-27T14:35:19ZTracTor unable to bind one of the listener portsWhen trying to reconnect to tor browser, the error code shows up saying that it can not bind one of the listener ports and will not let me continue. I've tried redownloading the application and it still does the same thing. I can't seem ...When trying to reconnect to tor browser, the error code shows up saying that it can not bind one of the listener ports and will not let me continue. I've tried redownloading the application and it still does the same thing. I can't seem to figure out what the issue is.
**Trac**:
**Username**: DfrostyTor: unspecifiedhttps://gitlab.torproject.org/tpo/network-health/sbws/-/issues/30174possible SBWS measurement quality regression2022-02-17T09:18:41Zstarlightpossible SBWS measurement quality regressionWith the release of v1.1 to longclaw seeing evidence of measurement quality degradation, regression. Have not had time to work up an analysis.
Recommend running Matt's original scanner and comparing raw bandwidth results.With the release of v1.1 to longclaw seeing evidence of measurement quality degradation, regression. Have not had time to work up an analysis.
Recommend running Matt's original scanner and comparing raw bandwidth results.sbws: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/32218Systemd problem with ExecReload and CAP_KILL2020-07-27T19:39:02ZTracSystemd problem with ExecReload and CAP_KILLHi
There is a known issue with CGroup hardening which systemd applies, that without CAP_KILL capability, it's not possible to send HUP signal by managed slice, even to MAINPID.
Please add it to CapabilityBoundingSet= section in unit file...Hi
There is a known issue with CGroup hardening which systemd applies, that without CAP_KILL capability, it's not possible to send HUP signal by managed slice, even to MAINPID.
Please add it to CapabilityBoundingSet= section in unit file.
Running Tor 0.4.2.2-alpha on Gentoo.
https://gitweb.torproject.org/tor.git/tree/contrib/dist/tor.service.in?id=d5cbc58094ec740e768d5fa88a51c20c645ed70e
**Trac**:
**Username**: sunovaTor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/31149Tor is stuck at "Loading Network Status"2020-07-29T12:41:21ZTracTor is stuck at "Loading Network Status"Tor Version: 8.5.4
Operating System: Windows 7
This is the Log I get after clicking:https://paste2.org/mUggK824
**Trac**:
**Username**: bornadxTor Version: 8.5.4
Operating System: Windows 7
This is the Log I get after clicking:https://paste2.org/mUggK824
**Trac**:
**Username**: bornadxTor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/29499permission error: nyx requires executable permission bit for `/var/lib/tor`2020-07-29T03:12:05Zcypherpunkspermission error: nyx requires executable permission bit for `/var/lib/tor`Offending logs from strace:
```
stat("/var/lib/tor/control_auth_cookie", 0x7ffca7ba61f0) = -1 EACCES (Permission denied)
stat("/var/lib/tor/control_auth_cookie", 0x7ffca7ba61f0) = -1 EACCES (Permission denied)
write(1, "We were unable to...Offending logs from strace:
```
stat("/var/lib/tor/control_auth_cookie", 0x7ffca7ba61f0) = -1 EACCES (Permission denied)
stat("/var/lib/tor/control_auth_cookie", 0x7ffca7ba61f0) = -1 EACCES (Permission denied)
write(1, "We were unable to read tor's aut"..., 176We were unable to read tor's authentication cookie...
Path: /var/lib/tor/control_auth_cookie
Issue: Authentication failed: '/var/lib/tor/control_auth_cookie' doesn't exist) = 176
```
Permissions on /var/lib/tor:
` drwx------ 3 tor tor 4.0K Feb 14 17:04 tor `
Permissions for cookie file:
` -rw-r----- 1 tor tor 32 Feb 13 06:36 control_auth_cookie `
A quick fix on the user part is to add the executable bit for group, but in general the cookie file should be accessible without the executable bit set so as long as the cookie file is configured to be readable by group (i.e. 'CookieAuthFileGroupReadable 1' written in /etc/tor/torrc).Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/29201Tor bootstrap hangs when offline2020-07-23T20:41:29ZDamian JohnsonTor bootstrap hangs when offlineHi Nick. When launching a tor process stem uses bootstrap messages to determine when the instance we launch is available. Recently-ish tor changed such that when offline tor bootstrapping does not progress past 0%, printing hundreds of.....Hi Nick. When launching a tor process stem uses bootstrap messages to determine when the instance we launch is available. Recently-ish tor changed such that when offline tor bootstrapping does not progress past 0%, printing hundreds of...
```
Jan 29 11:36:27.000 [warn] Problem bootstrapping. Stuck at 0% (starting): Starting. (Network is unreachable; NOROUTE; count 11; recommendation warn; host 322C6E3A973BC10FC36DE3037AD27BC89F14723B at 212.83.154.33:8443)
Jan 29 11:36:28.000 [warn] Problem bootstrapping. Stuck at 0% (starting): Starting. (Network is unreachable; NOROUTE; count 12; recommendation warn; host F741E5124CB12700DA946B78C9B2DD175D6CD2A1 at 163.172.154.162:9001)
Jan 29 11:36:28.000 [warn] Problem bootstrapping. Stuck at 0% (starting): Starting. (Network is unreachable; NOROUTE; count 14; recommendation warn; host D71B1CA1C9DC7E8CA64158E106AD770A21160FEE at 185.34.33.2:31415)
Jan 29 11:36:29.000 [warn] Problem bootstrapping. Stuck at 0% (starting): Starting. (Network is unreachable; NOROUTE; count 13; recommendation warn; host F2DFE5FA1E4CF54F8E761A6D304B9B4EC69BDAE8 at 129.13.131.140:443)
Jan 29 11:36:30.000 [warn] Problem bootstrapping. Stuck at 0% (starting): Starting. (Network is unreachable; NOROUTE; count 14; recommendation warn; host 47C42E2094EE482E7C9B586B10BABFB67557030B at 185.220.101.34:20034)
Jan 29 11:36:30.000 [warn] Problem bootstrapping. Stuck at 0% (starting): Starting. (Network is unreachable; NOROUTE; count 14; recommendation warn; host B06F093A3D4DFAD3E923F4F28A74901BD4F74EB1 at 178.17.174.14:9001)
Jan 29 11:36:31.000 [warn] Problem bootstrapping. Stuck at 0% (starting): Starting. (Network is unreachable; NOROUTE; count 15; recommendation warn; host CF6D0AAFB385BE71B8E111FC5CFF4B47923733BC at 154.35.175.225:443)
```
There's a few issues with this...
1. Poor experience from a user perspective. Deluging the user with hundreds of warnings is pretty unhelpful.
2. Stem's ability to launch tor processes no longer works when offline.
3. Stem's integ tests no longer pass when offline. I can sidestep this but first I'd like to confirm if this is the desired behavior from tor or not.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28944Debian logrotate misses line "su"2020-07-28T23:53:36ZTracDebian logrotate misses line "su"The freshly installed Tor Relay on Debian 9.6 creates a /etc/logrotate.d/tor that seems to miss a line. Without the option "su", logrotate produces this output:
/etc/cron.daily/logrotate:
error: skipping "/var/log/tor/debug.log" because...The freshly installed Tor Relay on Debian 9.6 creates a /etc/logrotate.d/tor that seems to miss a line. Without the option "su", logrotate produces this output:
/etc/cron.daily/logrotate:
error: skipping "/var/log/tor/debug.log" because parent directory has insecure permissions (It's world writable or writable by group which is not "root") Set "su" directive in config file to tell logrotate which user/group should be used for rotation.
error: skipping "/var/log/tor/notices.log" because parent directory has insecure permissions (It's world writable or writable by group which is not "root") Set "su" directive in config file to tell logrotate which user/group should be used for rotation.
run-parts: /etc/cron.daily/logrotate exited with return code 1
**Trac**:
**Username**: IlkaTor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28927TB 8.5a6 using obfs4 did not leave dormant mode on request2020-07-28T23:45:13ZtraumschuleTB 8.5a6 using obfs4 did not leave dormant mode on requestToday a long running TB 8.5a6 using obfs4 repeatedly logged about being in dormant mode and did not build any circuits for existing and new tabs until the bridge was disabled. Then everything worked again.
Tor version: 0.3.5.5-alpha (gi...Today a long running TB 8.5a6 using obfs4 repeatedly logged about being in dormant mode and did not build any circuits for existing and new tabs until the bridge was disabled. Then everything worked again.
Tor version: 0.3.5.5-alpha (git-a2ecc19ab923f34c) running on Linux with Libevent 2.1.8-stable, OpenSSL 1.0.2q, Zlib 1.2.8, Liblzma N/A, and Libzstd N/A.
Related: legacy/trac#2149, legacy/trac#25375, legacy/trac#28335, legacy/trac#28847, legacy/trac#28849
Steps to reproduce:
1. Start a fresh TB 8.5a6 with `--debug --log` and enable obfs4.
2. Use it for some days.
3. Let it run idle for some hours.
Step 2 may be optional, the computer was suspended several times but not the day this bug happened.
Will add the exact message when it happens again.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28702bootstrapping slow at times2020-07-28T23:41:24Zweasel (Peter Palfrader)bootstrapping slow at timesHi!
Tor 0.3.4.9, on Debian stretch (Thus linked against libssl 1.1.0f-3+deb9u2), sometimes bootstraps slowly.
The times in the following samples are times (in seconds) from process launch (with a non-existing data directory) until PROG...Hi!
Tor 0.3.4.9, on Debian stretch (Thus linked against libssl 1.1.0f-3+deb9u2), sometimes bootstraps slowly.
The times in the following samples are times (in seconds) from process launch (with a non-existing data directory) until PROGRESS=100 is reported in a getinfo status/bootstrap-phase:
9, 9, 7, 45, 11, 16, 17, 9, 21, 6, 10, 15, 44, 15, 15, 15, 7, 14, 7, 8, 12, 8, 14, 13, 8, 8, 11, 6, 8, 8, 35, 16, 11, 7, 7, 9, 7, 8, 13, 10, 8, 10, 14, 12, 15, 6, 7, 8, 91, 24, 13, 10, 10, 10
Most of the bootstraps are quite comfortable in the sub 20s, but there are a few outliers well above 30 seconds.
This is on an unfiltered network, with low latency and plenty of bandwidth.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/28241Corrupt cached consensus and microdescs2020-07-28T23:19:03ZteorCorrupt cached consensus and microdescsA relay operator reported file corruption on disk:
```
Non-exit
Oct 28 23:48:32.587 [notice] Tor 0.3.5.3-alpha running on FreeBSD with
Libevent 2.1.8-stable, OpenSSL LibreSSL 2.7.4, Zlib 1.2.11, Liblzma
5.2.3, and Libzstd 1.3.5.
...
Oct ...A relay operator reported file corruption on disk:
```
Non-exit
Oct 28 23:48:32.587 [notice] Tor 0.3.5.3-alpha running on FreeBSD with
Libevent 2.1.8-stable, OpenSSL LibreSSL 2.7.4, Zlib 1.2.11, Liblzma
5.2.3, and Libzstd 1.3.5.
...
Oct 28 23:48:33.000 [notice] Bootstrapped 0%: Starting
Oct 28 23:48:34.000 [warn] couldn't find start of hashed material
"network-status-version"
Oct 28 23:48:34.000 [warn] Unable to compute digest of network-status
Oct 28 23:48:34.000 [warn] Unable to parse networkstatus consensus
Oct 28 23:48:34.000 [warn] Couldn't load consensus microdesc
networkstatus from cache
Oct 28 23:48:34.000 [warn] parse error: Malformed object: missing object
end line
Oct 28 23:48:34.000 [warn] Unparseable microdescriptor
Bridge:
Oct 28 14:35:17.667 [notice] Tor 0.3.3.9 (git-45028085ea188baf) running
on FreeBSD with Libevent 2.1.8-stable, OpenSSL LibreSSL 2.7.4, Zlib
1.2.11, Liblzma 5.2.3, and Libzstd 1.3.5.
...
Oct 28 14:35:53.000 [notice] Bootstrapped 0%: Starting
Oct 28 14:35:55.000 [warn] parse error: Annotations mixed with keywords
Oct 28 14:35:55.000 [warn] Unparseable microdescriptor
```
I replied:
This looks like file corruption, but we'd still like to see the corrupt file, because it might be tor's fault.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27855Tor exited during startup2020-07-28T23:08:25ZTracTor exited during startup9/25/18, 13:52:22.810 [WARN] You specified a public address '42.93.251.189:3128' for SocksPort. Other people on the Internet might find your computer and use it as an open proxy. Please don't allow this unless you have a good reason.
9/...9/25/18, 13:52:22.810 [WARN] You specified a public address '42.93.251.189:3128' for SocksPort. Other people on the Internet might find your computer and use it as an open proxy. Please don't allow this unless you have a good reason.
9/25/18, 13:52:22.810 [NOTICE] DisableNetwork is set. Tor will not make or accept non-control network connections. Shutting down all existing connections.
**Trac**:
**Username**: kevinnoahTor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26933Minor memleak in HSv3 configuration2021-09-30T13:45:56ZGeorge KadianakisMinor memleak in HSv3 configurationI ran my HSv3 under valgrind for a while. I didn't find anything major.
The only interesting thing I could find is this leaked string during service configuration:
```
==13380== 26 bytes in 1 blocks are still reachable in loss record 54...I ran my HSv3 under valgrind for a while. I didn't find anything major.
The only interesting thing I could find is this leaked string during service configuration:
```
==13380== 26 bytes in 1 blocks are still reachable in loss record 545 of 654
==13380== at 0x4C2BC20: malloc (vg_replace_malloc.c:296)
==13380== by 0x2EB977: tor_malloc_ (util_malloc.c:45)
==13380== by 0x2D6946: esc_for_log (util.c:605)
==13380== by 0x2D6C3D: escaped (util.c:677)
==13380== by 0x26D26C: config_generic_service (hs_config.c:372)
==13380== by 0x26D26C: config_service (hs_config.c:471)
==13380== by 0x26D26C: hs_config_service_all (hs_config.c:555)
==13380== by 0x206996: options_validate (config.c:4384)
==13380== by 0x20AB2F: options_init_from_string (config.c:5497)
==13380== by 0x20B170: options_init_from_torrc (config.c:5273)
==13380== by 0x15B7BC: tor_init (main.c:3524)
==13380== by 0x15C23C: tor_run_main (main.c:4239)
==13380== by 0x1557A9: tor_main (tor_api.c:84)
==13380== by 0x155518: main (tor_main.c:32)
```Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26787Core file left on travis hardened rust builld2020-07-28T22:28:57ZMike PerryCore file left on travis hardened rust builldhttps://travis-ci.org/torproject/tor/jobs/403730172
It looks like all the tests pass, the only problem I can see is the mysterious core left over at the end. I'm unable to get this to happen on my system.https://travis-ci.org/torproject/tor/jobs/403730172
It looks like all the tests pass, the only problem I can see is the mysterious core left over at the end. I'm unable to get this to happen on my system.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26780Fix division by zero error reports from Coverity (CID: 1415721, 1415722, and ...2020-07-28T22:29:42ZAlexander Færøyahf@torproject.orgFix division by zero error reports from Coverity (CID: 1415721, 1415722, and 1415723)We should fix the current Coverity issues. Coverity CID 1415721, 1415722, and 1415723 seems to be somewhat related in that they all stem from Coverity not being able to identify the output domain for `get_net_param_from_list()`We should fix the current Coverity issues. Coverity CID 1415721, 1415722, and 1415723 seems to be somewhat related in that they all stem from Coverity not being able to identify the output domain for `get_net_param_from_list()`Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26469tor on SunOS: [err] Error from libevent: evport.c:425: Assertion evpd->ed_pen...2020-07-28T19:32:28ZTractor on SunOS: [err] Error from libevent: evport.c:425: Assertion evpd->ed_pending[i] == fd failed in evport_del
```
Tor 0.3.3.7 (git-035a35178c92da94) running on SunOS with Libevent 2.1.8-stable, OpenSSL 1.0.2o, Zlib 1.2.11, Liblzma N/A, and Libzstd N/A.
```
(this error was also observed under tor 0.3.3.6 for about two weeks, no change with updat...
```
Tor 0.3.3.7 (git-035a35178c92da94) running on SunOS with Libevent 2.1.8-stable, OpenSSL 1.0.2o, Zlib 1.2.11, Liblzma N/A, and Libzstd N/A.
```
(this error was also observed under tor 0.3.3.6 for about two weeks, no change with updating to 0.3.3.7)
every 10-20 minutes (sometimes longer) the process crashes with:
```
[err] Error from libevent: evport.c:425: Assertion evpd->ed_pending[i] == fd failed in evport_del
```
Contrary to tor crashes no libevent stacktrace is provided in default output.
The OS-Project under which the Service is running should have sufficent fd-ulimits:
```
ulimit -n
65536
```
Service privileges for the running User are pretty standard:
```
privileges='basic,net_privaddr'
```
**Trac**:
**Username**: ruebezahlTor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26356Tor 0.3.3.6 fails to compile under cygwin (x86_64)2020-07-28T19:23:27ZGeorg KoppenTor 0.3.3.6 fails to compile under cygwin (x86_64)From the 0.3.3.6 blog post's comments (https://blog.torproject.org/comment/275501#comment-275501):
```
I try to build latest tor 0.3.3.6 from source under "x86_64 Cygwin".
Earlier versions did compile, I'm running now "Tor version 0.3.2....From the 0.3.3.6 blog post's comments (https://blog.torproject.org/comment/275501#comment-275501):
```
I try to build latest tor 0.3.3.6 from source under "x86_64 Cygwin".
Earlier versions did compile, I'm running now "Tor version 0.3.2.9 (git-9e8b762fcecfece6)."
Compilation now Fails with the following erros:
make all-am
make[1]: Entering directory '/cygdrive/f/tor-0.3.3.6'
CC src/ext/ed25519/ref10/src_ext_ed25519_ref10_libed25519_ref10_a-fe_0.o
In file included from src/ext/ed25519/ref10/crypto_int32.h:6,
from src/ext/ed25519/ref10/fe.h:4,
from src/ext/ed25519/ref10/fe_0.c:1:
./src/common/torint.h:214:2: error: #error "Can't define ssize_t."
#error "Can't define ssize_t."
^~~~~
./src/common/torint.h:237:2: error: #error "void * is either >8 bytes or <= 2. In either case, I am confused."
#error "void * is either >8 bytes or <= 2. In either case, I am confused."
^~~~~
./src/common/torint.h:241:2: error: #error "Missing type int8_t"
#error "Missing type int8_t"
^~~~~
./src/common/torint.h:244:2: error: #error "Missing type uint8_t"
#error "Missing type uint8_t"
^~~~~
./src/common/torint.h:247:2: error: #error "Missing type int16_t"
#error "Missing type int16_t"
^~~~~
./src/common/torint.h:250:2: error: #error "Missing type uint16_t"
#error "Missing type uint16_t"
^~~~~
./src/common/torint.h:253:2: error: #error "Missing type int32_t"
#error "Missing type int32_t"
^~~~~
./src/common/torint.h:256:2: error: #error "Missing type uint32_t"
#error "Missing type uint32_t"
^~~~~
./src/common/torint.h:259:2: error: #error "Missing type int64_t"
#error "Missing type int64_t"
^~~~~
./src/common/torint.h:262:2: error: #error "Missing type uint64_t"
#error "Missing type uint64_t"
^~~~~
./src/common/torint.h:269:2: error: #error "Seems that your platform doesn't use 2's complement arithmetic. Argh."
#error "Seems that your platform doesn't use 2's complement arithmetic. Argh."
^~~~~
./src/common/torint.h:277:2: error: #error "Can't define LONG_MAX"
#error "Can't define LONG_MAX"
^~~~~
./src/common/torint.h:287:2: error: #error "Can't define INT_MAX"
#error "Can't define INT_MAX"
^~~~~
./src/common/torint.h:299:2: error: #error "Can't define UINT_MAX"
#error "Can't define UINT_MAX"
^~~~~
./src/common/torint.h:309:2: error: #error "Can't define SHORT_MAX"
#error "Can't define SHORT_MAX"
^~~~~
./src/common/torint.h:367:2: error: #error "Can't define SSIZE_MAX"
#error "Can't define SSIZE_MAX"
^~~~~
make[1]: *** [Makefile:6513: src/ext/ed25519/ref10/src_ext_ed25519_ref10_libed25519_ref10_a-fe_0.o] Error 1
make[1]: Leaving directory '/cygdrive/f/tor-0.3.3.6'
make: *** [Makefile:3409: all] Error 2
```Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/26337Investigate making rust error types use the failure crate2021-09-16T14:30:20ZIsis LovecruftInvestigate making rust error types use the failure crateAs our Rust code increases, we'll eventually want a nicer way to convert between error types than we currently have. We'll probably want to use boats's `failure` [crate](https://crates.io/crates/failure). They mentioned a while ago tha...As our Rust code increases, we'll eventually want a nicer way to convert between error types than we currently have. We'll probably want to use boats's `failure` [crate](https://crates.io/crates/failure). They mentioned a while ago that they were going to make a 1.0.0 release soon, and afaict there's not really anything about the current release that is expected to change, so we can probably start working on this now-ish.
[update] This ticket is pending stability of the `failure` crate and the direction of the error trait in Rust https://github.com/rust-lang/rfcs/pull/2504Tor: unspecified