The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2022-07-20T14:38:16Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40008Make "Restart to update" message clearer2022-07-20T14:38:16ZMatthew FinkelMake "Restart to update" message clearerIn https://blog.torproject.org/comment/288256#comment-288256 we received some feedback that the `Restart to update Tor Browser` message is not clear about *what* should be restarted. This comes from Firefox's message choice (`updateResta...In https://blog.torproject.org/comment/288256#comment-288256 we received some feedback that the `Restart to update Tor Browser` message is not clear about *what* should be restarted. This comes from Firefox's message choice (`updateRestart.panelUI.label2`).
I'm not sure what we should do right now, as Mozilla may not be interested in changing their phrasing (but maybe they will).https://gitlab.torproject.org/tpo/core/tor/-/issues/21020Refactor dirserv_generate_networkstatus_vote_obj2021-09-16T14:33:05ZChelsea KomloRefactor dirserv_generate_networkstatus_vote_objdirserv_generate_networkstatus_vote_obj in dirserv.c can have pieces of its logic pulled into smaller functions.
This will help with readability/testability. Furthermore, future versions could use these functions where applicable (v4, v...dirserv_generate_networkstatus_vote_obj in dirserv.c can have pieces of its logic pulled into smaller functions.
This will help with readability/testability. Furthermore, future versions could use these functions where applicable (v4, v5, etc).Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/21023Replace custom checks with Autoconf macros2021-09-16T14:33:05ZcypherpunksReplace custom checks with Autoconf macrosRemoving environ in legacy/trac#19142 didn't work on BSDs but the check in `configure.ac` can be simplified. Autoconf provides the `AC_CHECK_DECL` macro for these kinds of checks and turns the current check into a oneliner.
The `malloc(...Removing environ in legacy/trac#19142 didn't work on BSDs but the check in `configure.ac` can be simplified. Autoconf provides the `AC_CHECK_DECL` macro for these kinds of checks and turns the current check into a oneliner.
The `malloc(0)` check can also be simplified by replacing it with the `AC_FUNC_MALLOC` macro.
These are only two candidates I've found so far, there are probably more hence this ticket.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40011Cannot change Background Color in Preferences2022-11-29T16:01:39ZGeorg KoppenCannot change Background Color in PreferencesUsing Tor 9.0.9 , based on Firefox 68.7.0esr, 2019 iMac running Catalina 10.15.4
In preferences, I can change the font color, but not the background color.
I have no problem changing everything in Firefox.
This is a reference to lega...Using Tor 9.0.9 , based on Firefox 68.7.0esr, 2019 iMac running Catalina 10.15.4
In preferences, I can change the font color, but not the background color.
I have no problem changing everything in Firefox.
This is a reference to legacy/trac#34026.https://gitlab.torproject.org/tpo/core/tor/-/issues/21024Remove more code related to the old tor-fw-helper2020-06-27T13:57:31ZcypherpunksRemove more code related to the old tor-fw-helperThere is still some code related to the old tor-fw-helper (which was removed in legacy/trac#13338) in various files.
Attaching a patch once i get a ticket number.There is still some code related to the old tor-fw-helper (which was removed in legacy/trac#13338) in various files.
Attaching a patch once i get a ticket number.Tor: 0.3.0.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/21026Remove the abort handler in the backtrace generator2020-06-27T13:57:31ZcypherpunksRemove the abort handler in the backtrace generatorThe [abort handler](https://gitweb.torproject.org/tor.git/tree/src/test/test_bt_cl.c?id=51ee549a90e3e1b6c87f4ac588ac9fed51f0cc27#n79) in the backtrace generator calls `exit(3)` which is not asynchronous-signal-safe. Calling `exit(3)` in ...The [abort handler](https://gitweb.torproject.org/tor.git/tree/src/test/test_bt_cl.c?id=51ee549a90e3e1b6c87f4ac588ac9fed51f0cc27#n79) in the backtrace generator calls `exit(3)` which is not asynchronous-signal-safe. Calling `exit(3)` in this context is undefined behavior according to the C standard. See https://www.securecoding.cert.org/confluence/x/34At for more information.
FWICT the handler is meant to force the backtrace generator to always have an zero exit code. How the generator is currently used its exit code does not matter so the handler can probably be removed.
Patch coming soon after some testing.Tor: 0.3.0.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/21027tor_bug_occurred_(): Bug: src/or/entrynodes.c:816: entry_guard_add_to_sample_...2020-06-27T13:57:31ZGeorge Kadianakistor_bug_occurred_(): Bug: src/or/entrynodes.c:816: entry_guard_add_to_sample_impl: Non-fatal assertion !(have_sampled_guard_with_id(gs, rsa_id_digest)) failed. (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)Hey,
I've been running an oldish version of the guard branch on my tor browser. Top commit is `2767ae18064a879218` plus some extra logging code of mine.
I used Tor with guards and in my logs the following appeared:
```
Dec 18 01:10:04....Hey,
I've been running an oldish version of the guard branch on my tor browser. Top commit is `2767ae18064a879218` plus some extra logging code of mine.
I used Tor with guards and in my logs the following appeared:
```
Dec 18 01:10:04.000 [warn] tor_bug_occurred_(): Bug: src/or/entrynodes.c:816: entry_guard_add_to_sample_impl: Non-fatal assertion !(have_sampled_guard_with_id(gs, rsa_id_digest)) failed. (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: Non-fatal assertion !(have_sampled_guard_with_id(gs, rsa_id_digest)) failed in entry_guard_add_to_sample_impl at src/or/entrynodes.c:816. Stack trace: (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /usr/lib/x86_64-linux-gnu/libasan.so.1(backtrace+0x3a) [0x7f0cde5be48a] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(log_backtrace+0x46) [0x7f0cdff74dc6] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_bug_occurred_+0x12f) [0x7f0cdffc4c1f] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x8a249a) [0x7f0cdff2f49a] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x8a3b5c) [0x7f0cdff30b5c] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x8a500f) [0x7f0cdff3200f] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(entry_guards_update_all+0x10f0) [0x7f0cdff379e0] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(guards_update_all+0x83) [0x7f0cdff43cc3] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(set_options+0x62af) [0x7f0cdfe2521f] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(options_trial_assign+0xb3) [0x7f0cdfe28693] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x803aff) [0x7f0cdfe90aff] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(connection_control_process_inbuf+0xdcd) [0x7f0cdfe9df9d] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x7cb938) [0x7f0cdfe58938] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x56f716) [0x7f0cdfbfc716] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/libevent-2.0.so.5(event_base_loop+0x937) [0x7f0cdde408d7] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(do_main_loop+0x385) [0x7f0cdfbfe535] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(tor_main+0x1385) [0x7f0cdfc03385] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(main+0x1c) [0x7f0cdfbf16dc] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x7f0cdc098b45] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
Dec 18 01:10:04.000 [warn] Bug: /home/f/tor-browser_en-US/Browser/TorBrowser/Tor/tor(+0x56665b) [0x7f0cdfbf365b] (on Tor 0.3.0.0-alpha-dev 8b75261b6dc341de)
```
I've since restarted Tor to use git master, will update the ticket accordingly. Perhaps the above traceback is enough to identify the issue anyway.Tor: 0.3.0.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40015TB broken on MacOS 11 Big Sur2020-08-20T07:27:55ZAlexander Færøyahf@torproject.orgTB broken on MacOS 11 Big SurGot the following email today on gitlab-admin@
`Hi the tor browser currently loads pages but not displays them just a gray/white screen it is still interactable but can’t see anything on the website`Got the following email today on gitlab-admin@
`Hi the tor browser currently loads pages but not displays them just a gray/white screen it is still interactable but can’t see anything on the website`https://gitlab.torproject.org/tpo/core/tor/-/issues/21028tor never checks TLS certificate lifetimes2021-08-23T15:17:06Zteortor never checks TLS certificate lifetimesWe have tor_tls_check_lifetime(), why don't we use it?
This could be an issue if a relay never rotates its certificate, or its certificate is out of date because its clock is wrong.We have tor_tls_check_lifetime(), why don't we use it?
This could be an issue if a relay never rotates its certificate, or its certificate is out of date because its clock is wrong.Tor: 0.3.1.x-finalhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40017Audit Firefox 68-78 diff for proxy issues2020-10-13T21:13:06ZMike PerryAudit Firefox 68-78 diff for proxy issuesThis audit is for the code in gecko-dev.
The fenix component/UI audit is https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34177This audit is for the code in gecko-dev.
The fenix component/UI audit is https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34177Sponsor 58 - Tor Browser Security, Performance, & Usability ImprovementsMike PerryMike Perry2020-08-25https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40018Linux64 10.0a1-10.0a2 incremental update fails2020-07-01T14:02:57ZMatthew FinkelLinux64 10.0a1-10.0a2 incremental update failsIn `Browser/TorBrowser/UpdateInfo/updates/last-update.log`, I see:
```
FINISH PATCH TorBrowser/Tor/tor
backup_restore: cannot get info for backup file: TorBrowser/Tor/tor.moz-backup, err: 2
FINISH PATCH TorBrowser/Docs/ChangeLog.txt
back...In `Browser/TorBrowser/UpdateInfo/updates/last-update.log`, I see:
```
FINISH PATCH TorBrowser/Tor/tor
backup_restore: cannot get info for backup file: TorBrowser/Tor/tor.moz-backup, err: 2
FINISH PATCH TorBrowser/Docs/ChangeLog.txt
backup_restore: cannot get info for backup file: TorBrowser/Docs/ChangeLog.txt.moz-backup, err: 2
FINISH ADD TorBrowser/Data/Browser/profile.default/extensions/{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi
backup_restore: cannot get info for backup file: TorBrowser/Data/Browser/profile.default/extensions/{73a6fe31-595d-460b-a920-fcc0f8843232}.xpi.moz-backup, err: 2
failed: 2
calling QuitProgressUI
```
The updater logs show the file was successfully downloaded and verified:
```
*** AUS:SVC Downloader:onStartRequest - original URI spec: https://cdn.torproject.org/aus1/torbrowser/10.0a2/tor-browser-linux64-10.0a1-10.0a2_en-US.incremental.mar, final URI spec: https://cdn-fastly.torproject.org/aus1/torbrowser/10.0a2/tor-browser-linux64-10.0a1-10.0a2_en-US.incremental.mar
*** AUS:SVC Downloader:onProgress - progress: 512/4773259
*** AUS:SVC Downloader:onProgress - progress: 27420/4773259
*** AUS:SVC Downloader:onProgress - progress: 67179/4773259
*** AUS:SVC Downloader:onProgress - progress: 163149/4773259
[snip]
*** AUS:SVC Downloader:onProgress - progress: 4512012/4773259
*** AUS:SVC Downloader:onProgress - progress: 4725004/4773259
*** AUS:SVC Downloader:onProgress - progress: 4773259/4773259
*** AUS:SVC Downloader:onStopRequest - downloader: nsIIncrementalDownload, original URI spec: https://cdn.torproject.org/aus1/torbrowser/10.0a2/tor-browser-linux64-10.0a1-10.0a2_en-US.incremental.mar, final URI spec: https://cdn-fastly.torproject.org/aus1/torbrowser/10.0a2/tor-browser-linux64-10.0a1-10.0a2_en-US.incremental.mar, status: 0
*** AUS:SVC Downloader:onStopRequest - status: 0, current fail: 0, max fail: 10, retryTimeout: 2000
*** AUS:SVC Downloader:_verifyDownload called
*** AUS:SVC Downloader:_verifyDownload downloaded size == expected size.
*** AUS:SVC Downloader:_verifyDownload hashes match.
```
However, installing the complete update was successful.https://gitlab.torproject.org/tpo/core/tor/-/issues/21031Please don't remove ClientDNSRejectInternalAddresses2020-06-27T13:57:31ZSebastian HahnPlease don't remove ClientDNSRejectInternalAddressesI have a private tor network that lives in 10.0.0.0/8, and removing this option would make that network unusable.I have a private tor network that lives in 10.0.0.0/8, and removing this option would make that network unusable.Tor: 0.3.2.x-finalSebastian HahnSebastian Hahnhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40019".onion available" is been displayed in an https onion site2020-08-18T09:41:11ZGus".onion available" is been displayed in an https onion siteAn user reported that visiting SecureDrop onion site (https://secrdrop5wyphb5x.onion/) will show the purple pill (.onion available). And if you have enabled TBB to prioritize onions, the page will reload in loop.
Related: https://githu...An user reported that visiting SecureDrop onion site (https://secrdrop5wyphb5x.onion/) will show the purple pill (.onion available). And if you have enabled TBB to prioritize onions, the page will reload in loop.
Related: https://github.com/freedomofpress/securedrop.org/issues/698https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40020On a v2 onion page, Onion-Location with a v3 onion should count as "onion ava...2022-07-12T20:03:14ZRoger DingledineOn a v2 onion page, Onion-Location with a v3 onion should count as "onion available"If I load a v2 onion service, and it gives me an Onion-Location header listing a v3 onion service, then we should show the "onion available" button to the user, auto switch to it if their Tor Browser is configured to auto switch when oni...If I load a v2 onion service, and it gives me an Onion-Location header listing a v3 onion service, then we should show the "onion available" button to the user, auto switch to it if their Tor Browser is configured to auto switch when onion is available, etc.
This way there can be an authenticated way to update people from a site's legacy v2 address to their new v3 address.
Originally suggested by Alec on
https://lists.torproject.org/pipermail/tor-dev/2020-June/014372.htmlhttps://gitlab.torproject.org/tpo/core/tor/-/issues/21033hs: HiddenServiceNumIntroductionPoints can't go below the default value of 32020-06-27T13:57:31ZDavid Gouletdgoulet@torproject.orghs: HiddenServiceNumIntroductionPoints can't go below the default value of 3With the `HiddenServiceNumIntroductionPoints` option, one should be able to go from 0 to the maximum allowed that is 10.
Currently, our code restrict from default value of 3 to the maximum value of 10. Bug is here:
```
service->n...With the `HiddenServiceNumIntroductionPoints` option, one should be able to go from 0 to the maximum allowed that is 10.
Currently, our code restrict from default value of 3 to the maximum value of 10. Bug is here:
```
service->n_intro_points_wanted =
(unsigned int) tor_parse_long(line->value, 10,
NUM_INTRO_POINTS_DEFAULT,
NUM_INTRO_POINTS_MAX, &ok, NULL);
```Tor: 0.3.0.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40022Update new icons in Tor Browser branding2020-08-07T14:11:50ZAlex CatarineuUpdate new icons in Tor Browser brandingSome new icons (default22.png/default24.png) were added in https://bugzilla.mozilla.org/show_bug.cgi?id=1570397. Even though these don't seem to be used currently, we should update our branding patch to also include these.
See comment: ...Some new icons (default22.png/default24.png) were added in https://bugzilla.mozilla.org/show_bug.cgi?id=1570397. Even though these don't seem to be used currently, we should update our branding patch to also include these.
See comment: https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33533#note_2682426.https://gitlab.torproject.org/tpo/core/tor/-/issues/21035Assertion in 0.2.9.8: monotime_coarse_get2020-06-27T13:57:30ZTracAssertion in 0.2.9.8: monotime_coarse_getDec 20 02:44:06.000 [notice] Tor 0.2.9.8 (git-01ab67e38b358ae9) opening log file.
Dec 20 02:44:06.630 [notice] Tor 0.2.9.8 (git-01ab67e38b358ae9) running on Linux with Libevent 2.0.22-stable, OpenSSL 1.0.2j and Zlib 1.2.8.
Dec 20 02:44:0...Dec 20 02:44:06.000 [notice] Tor 0.2.9.8 (git-01ab67e38b358ae9) opening log file.
Dec 20 02:44:06.630 [notice] Tor 0.2.9.8 (git-01ab67e38b358ae9) running on Linux with Libevent 2.0.22-stable, OpenSSL 1.0.2j and Zlib 1.2.8.
Dec 20 02:44:06.630 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Dec 20 02:44:06.630 [notice] Read configuration file "/etc/tor/torrc".
Dec 20 02:44:06.633 [notice] Based on detected system memory, MaxMemInQueues is set to 6144 MB. You can override this by setting MaxMemInQueues by hand.
Dec 20 02:44:06.634 [notice] Opening Socks listener on 127.0.0.1:9050
Dec 20 02:44:06.634 [notice] Opening OR listener on 46.29.248.238:443
Dec 20 02:44:06.634 [notice] Opening Directory listener on 46.29.248.238:80
Dec 20 02:44:06.000 [notice] Parsing GEOIP IPv4 file /usr/share/tor/geoip.
Dec 20 02:44:06.000 [notice] Parsing GEOIP IPv6 file /usr/share/tor/geoip6.
Dec 20 02:44:06.000 [notice] Configured to measure statistics. Look for the *-stats files that will first be written to the data directory in 24 hours from now.
Dec 20 02:44:06.000 [err] tor_assertion_failed_(): Bug: src/common/compat_time.c:359: monotime_coarse_get: Assertion r == 0 failed; aborting. (on Tor 0.2.9.8 01ab67e38b358ae9)
Dec 20 02:44:06.000 [err] Bug: Assertion r == 0 failed in monotime_coarse_get at src/common/compat_time.c:359. Stack trace: (on Tor 0.2.9.8 01ab67e38b358ae9)
Dec 20 02:44:06.000 [err] Bug: /usr/bin/tor(log_backtrace+0x42) [0x2b9dce1a5222] (on Tor 0.2.9.8 01ab67e38b358ae9)
Dec 20 02:44:06.000 [err] Bug: /usr/bin/tor(tor_assertion_failed_+0xa3) [0x2b9dce1bd6d3] (on Tor 0.2.9.8 01ab67e38b358ae9)
Dec 20 02:44:06.000 [err] Bug: /usr/bin/tor(monotime_coarse_get+0x59) [0x2b9dce1a9e59] (on Tor 0.2.9.8 01ab67e38b358ae9)
Dec 20 02:44:06.000 [err] Bug: /usr/bin/tor(tor_main+0x86) [0x2b9dce099d46] (on Tor 0.2.9.8 01ab67e38b358ae9)
Dec 20 02:44:06.000 [err] Bug: /usr/bin/tor(main+0x19) [0x2b9dce096b19] (on Tor 0.2.9.8 01ab67e38b358ae9)
Dec 20 02:44:06.000 [err] Bug: /lib64/libc.so.6(__libc_start_main+0xfd) [0x2b9dcf1e6d1d] (on Tor 0.2.9.8 01ab67e38b358ae9)
Dec 20 02:44:06.000 [err] Bug: /usr/bin/tor(+0xada29) [0x2b9dce096a29] (on Tor 0.2.9.8 01ab67e38b358ae9)
---------------------------
Environment: CentOS v6.8, OpenVZ virtualization, confirmed system time is accurate. No problem seen in same environment with Tor v0.2.8.11.
**Trac**:
**Username**: tmpname0901Tor: 0.2.9.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40025Revert add-on install permissions introduced in Mozilla's 15600592022-11-16T15:26:24ZGeorg KoppenRevert add-on install permissions introduced in Mozilla's 1560059We should revert https://bugzilla.mozilla.org/show_bug.cgi?id=1560059 to make it harder to accidentally install extensions in Tor Browser.We should revert https://bugzilla.mozilla.org/show_bug.cgi?id=1560059 to make it harder to accidentally install extensions in Tor Browser.Tor Browser: 10.0https://gitlab.torproject.org/tpo/core/tor/-/issues/21037Scary log message "AAAA...AAA" in connection_or_set_identity_digest()2020-06-27T13:57:30ZRoger DingledineScary log message "AAAA...AAA" in connection_or_set_identity_digest()On moria1 running today's 0.3.0.1-alpha-dev, I see these info-level logs:
```
Dec 19 20:42:39.727 [info] connection_or_set_identity_digest(): Set identity digest for 0x1369a250 ((null)): FFD94A523D3A66323E3E4F7707AFCBD44A8D38C4 <null>.
D...On moria1 running today's 0.3.0.1-alpha-dev, I see these info-level logs:
```
Dec 19 20:42:39.727 [info] connection_or_set_identity_digest(): Set identity digest for 0x1369a250 ((null)): FFD94A523D3A66323E3E4F7707AFCBD44A8D38C4 <null>.
Dec 19 20:42:39.727 [info] connection_or_set_identity_digest(): (Previously: 0000000000000000000000000000000000000000 AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA)
```
That last part reminds me of elsewhere in our code where we do
```
memwipe(mem, 0xAA, memlen); /* poison memory */
```
Coincidence? I think it is, because I bet AAA..AAA is the base64 of 000..000, since I see ed25519_fmt() returns a base64 thing.
Still, I wonder if we might do a smarter log message for the case where the key used to be unset, since I'm not the only person who is going to see this line and be concerned.Tor: 0.3.0.x-finalhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40026Onion-Location notification doorhanger sometimes appears out of place2022-11-08T23:30:27ZAlex CatarineuOnion-Location notification doorhanger sometimes appears out of placeIt usually happens when there are several tabs open, after switching between the tab that has the notification doorhanger and the other tabs.It usually happens when there are several tabs open, after switching between the tab that has the notification doorhanger and the other tabs.