The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2020-06-27T13:52:16Zhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27532Bug: tor_tls_context_new: Assertion dh failed2020-06-27T13:52:16ZteorBug: tor_tls_context_new: Assertion dh failedI get an assertion failure on macOS 10.13:
```
$ gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 9.1.0 (clang-902.0.39.2)
Target: x86...I get an assertion failure on macOS 10.13:
```
$ gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 9.1.0 (clang-902.0.39.2)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
$ brew list --versions | grep openssl
openssl 1.0.2o_2
```
(Yes, gcc is an alias for clang on macOS by default.)
Our macOS CI passes with:
```
$ gcc --version
...
Target: x86_64-apple-darwin17.4.0
...
$ if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install openssl; fi
Warning: openssl 1.0.2p is already installed and up-to-date
To reinstall 1.0.2p, run `brew reinstall openssl`
```
https://travis-ci.org/teor2345/tor/jobs/425576549#L1132
Have we broken compatibility with 1.0.2o?
I've done a `make clean`, so it's probably not my machine.
Here is the tor log:
```
$ /Users/base/tor-master/build-c/src/app/tor --ignore-missing-torrc -f /Users/base/chutney/net/nodes/000a/torrc --list-fingerprint --orport 1 --datadirectory /Users/base/chutney/net/nodes/000a
Sep 06 07:32:14.174 [notice] Tor 0.3.5.0-alpha-dev (git-22e24031452d5785) running on Darwin with Libevent 2.1.8-stable, OpenSSL 1.0.2o, Zlib 1.2.11, Liblzma 5.2.4, and Libzstd 1.3.5.
...
Sep 06 07:32:14.176 [notice] Configuration file "/Users/base/chutney/net/nodes/000a/torrc" not present, using reasonable defaults.
...
Sep 06 07:27:13.545 [err] tor_assertion_failed_: Bug: ../src/lib/tls/tortls_openssl.c:632: tor_tls_context_new: Assertion dh failed; aborting. (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: Assertion dh failed in tor_tls_context_new at ../src/lib/tls/tortls_openssl.c:632. Stack trace: (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 0 tor 0x000000010be5572c log_backtrace_impl + 76 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 1 tor 0x000000010be45bd8 tor_assertion_failed_ + 392 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 2 tor 0x000000010bd7454e tor_tls_context_new + 4190 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 3 tor 0x000000010bd7050c tor_tls_context_init + 156 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 4 tor 0x000000010bc8742f init_keys + 2191 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 5 tor 0x000000010b8e6da6 tor_run_main + 1734 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 6 tor 0x000000010ba48721 tor_main + 161 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 7 tor 0x000000010b842bdb main + 27 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 8 libdyld.dylib 0x00007fff54fbe015 start + 1 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Sep 06 07:27:13.547 [err] Bug: 9 ??? 0x0000000000000009 0x0 + 9 (on Tor 0.3.5.0-alpha-dev 22e24031452d5785)
Abort trap: 6
Exit 134
```Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27530Configure: Use AC_TRY_RUN() to check that --enable-gcc-hardening works2020-06-27T13:52:16ZteorConfigure: Use AC_TRY_RUN() to check that --enable-gcc-hardening worksSplit off [comment:3:ticket:27460 legacy/trac#27460 Comment 3]:
> maybe in 0.3.5 we should change the implementation of gcc-hardening so that it does an AC_TRY_RUN() to see whether it can use these compiler flags safely. That could be a...Split off [comment:3:ticket:27460 legacy/trac#27460 Comment 3]:
> maybe in 0.3.5 we should change the implementation of gcc-hardening so that it does an AC_TRY_RUN() to see whether it can use these compiler flags safely. That could be another ticket, though.
When we merge to 0.3.5, we should also revert legacy/trac#27460.Tor: 0.4.1.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27521Comment: typo in get_interface_addresses_win32() function comment2020-06-27T13:52:16ZteorComment: typo in get_interface_addresses_win32() function commentTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27519missing "Service configured in" for hs-v3 lines in info log2020-07-28T22:59:41Ztraumschulemissing "Service configured in" for hs-v3 lines in info log(My) Tor version 0.3.5.0-alpha-dev does not print out
> [info] {GENERAL} Service configured in "/var/lib/tor/hidden_service
for v3 onion services. The output for
```
rgrep "Service configured in" /var/log/tor/|grep hsv3
```
is empty h...(My) Tor version 0.3.5.0-alpha-dev does not print out
> [info] {GENERAL} Service configured in "/var/lib/tor/hidden_service
for v3 onion services. The output for
```
rgrep "Service configured in" /var/log/tor/|grep hsv3
```
is empty here, although i have at least one onion service configure in a path by that name.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27500Tor crashes upon ORPort disconnection2020-06-27T13:52:16ZDamian JohnsonTor crashes upon ORPort disconnectionHi Nick, as discussed this morning tor had a regression between commits fd994f5-b8a2bdb. Tor crashes when Stem attempts to connect with its ORPort then disconnect. Here's its stacktrace...
```
Sep 05 20:36:47.000 [err] tor_assertion_fai...Hi Nick, as discussed this morning tor had a regression between commits fd994f5-b8a2bdb. Tor crashes when Stem attempts to connect with its ORPort then disconnect. Here's its stacktrace...
```
Sep 05 20:36:47.000 [err] tor_assertion_failed_(): Bug: src/core/mainloop/connection.c:5109: assert_connection_ok: Assertion or_conn->tls failed; aborting. (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: Assertion or_conn->tls failed in assert_connection_ok at src/core/mainloop/connection.c:5109. Stack trace: (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(log_backtrace_impl+0x47) [0x55fcc4c95447] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(tor_assertion_failed_+0x94) [0x55fcc4c90bb4] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(assert_connection_ok+0x575) [0x55fcc4c240a5] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(connection_mark_for_close_internal_+0x27) [0x55fcc4c246b7] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(connection_handle_read+0x517) [0x55fcc4c28bb7] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(+0x5470e) [0x55fcc4b0470e] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x819) [0x7fb789e174c9] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(do_main_loop+0x1fa) [0x55fcc4b069aa] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(tor_run_main+0x11d5) [0x55fcc4b09065] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(tor_main+0x3a) [0x55fcc4b012fa] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(main+0x19) [0x55fcc4b00e79] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7fb789196830] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Sep 05 20:36:47.000 [err] Bug: tor(_start+0x29) [0x55fcc4b00ec9] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
Aborted (core dumped)
```
Unfortunately since this is with the ORPort rather than the ControlPort I can't provide a simple telnet demo. If you need repro steps just let me know and I can come up with a demo.Tor: 0.3.5.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27492Try IPv4 or IPv6 more often based on public or private IP addresses2020-06-27T13:52:17ZNeel Chauhanneel@neelc.orgTry IPv4 or IPv6 more often based on public or private IP addressesSuggested by teor at legacy/trac#17835:
> 7. If the machine has public IPv4 addresses, try IPv4 a lot more often
> 8. If the machine has public IPv6 addresses, try IPv6 a lot more often
> 9. If the machine has private IPv4 address...Suggested by teor at legacy/trac#17835:
> 7. If the machine has public IPv4 addresses, try IPv4 a lot more often
> 8. If the machine has public IPv6 addresses, try IPv6 a lot more often
> 9. If the machine has private IPv4 addresses, try IPv4 a little bit more often
> 10. If the machine has private IPv6 addresses (excluding link-local addresses), try IPv6 a little bit more oftenTor: unspecifiedNeel Chauhanneel@neelc.orgNeel Chauhanneel@neelc.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/27491Prefer IPv4 or IPv6 based on the number of failures2020-06-27T13:52:17ZNeel Chauhanneel@neelc.orgPrefer IPv4 or IPv6 based on the number of failuresSuggested by teor at legacy/trac#17835:
> 3. If the machine instantly fails IPv4 or IPv6 connections, stop those connections for a while
> 4. When there are a lot more IPv4 than IPv6 failures, don't try IPv4 as much
> 5. When there are ...Suggested by teor at legacy/trac#17835:
> 3. If the machine instantly fails IPv4 or IPv6 connections, stop those connections for a while
> 4. When there are a lot more IPv4 than IPv6 failures, don't try IPv4 as much
> 5. When there are a lot more IPv6 than IPv4 failures, don't try IPv6 as much
> 6. After a while, forget old failuresTor: unspecifiedNeel Chauhanneel@neelc.orgNeel Chauhanneel@neelc.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/27490When ClientPreferIPv6ORPort is set to auto, and a relay is being chosen for a...2020-06-27T13:52:17ZNeel Chauhanneel@neelc.orgWhen ClientPreferIPv6ORPort is set to auto, and a relay is being chosen for a directory or orport connection, prefer IPv4 or IPv6 at randomSuggested by teor at legacy/trac#17835:
>1. Make ClientPreferIPv6ORPort into an autobool
>2. When ClientPreferIPv6ORPort is set to auto, and a relay is being chosen for a directory or orport connection, prefer IPv4 or IPv6 at randomSuggested by teor at legacy/trac#17835:
>1. Make ClientPreferIPv6ORPort into an autobool
>2. When ClientPreferIPv6ORPort is set to auto, and a relay is being chosen for a directory or orport connection, prefer IPv4 or IPv6 at randomTor: 0.4.0.x-finalNeel Chauhanneel@neelc.orgNeel Chauhanneel@neelc.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/274880.3.4.6-rc ChangeLog omits bug268762020-06-27T13:52:17ZTaylor Yu0.3.4.6-rc ChangeLog omits bug26876At arma's suggestion, we should check the 0.3.4 ChangeLog for omissions.
It looks like bf33ddd291 deleted changes/bug26876 but 59e813f5f9 didn't actually incorporate its contents into the ChangeLog. We should fix this. We should proba...At arma's suggestion, we should check the 0.3.4 ChangeLog for omissions.
It looks like bf33ddd291 deleted changes/bug26876 but 59e813f5f9 didn't actually incorporate its contents into the ChangeLog. We should fix this. We should probably check for other omissions of this sort, too.Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27481Bug: src/core/mainloop/connection.c:5109: assert_connection_ok: Assertion or_...2020-06-27T13:52:17ZDavid Gouletdgoulet@torproject.orgBug: src/core/mainloop/connection.c:5109: assert_connection_ok: Assertion or_conn->tls failedLatest git master 06c14f920900f99935e0cf6072aeb50231464eba asserts reliably everytime it tries to boostrap. Triggered on one of my relay (no weird or special configuration). See info.log attached:
```
Sep 05 20:02:59.636 [err] tor_asser...Latest git master 06c14f920900f99935e0cf6072aeb50231464eba asserts reliably everytime it tries to boostrap. Triggered on one of my relay (no weird or special configuration). See info.log attached:
```
Sep 05 20:02:59.636 [err] tor_assertion_failed_(): Bug: src/core/mainloop/connection.c:5109: assert_connection_ok: Assertion or_conn->tls failed; aborting. (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: Assertion or_conn->tls failed in assert_connection_ok at src/core/mainloop/connection.c:5109. Stack trace: (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(log_backtrace_impl+0x47) [0x5650452200b7] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(tor_assertion_failed_+0x94) [0x56504521b824] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(assert_connection_ok+0x575) [0x5650451aaed5] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(connection_mark_for_close_internal_+0x27) [0x5650451ab4e7] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(connection_handle_read+0x517) [0x5650451afa07] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.636 [err] Bug: ./git/tor/src/app/tor(+0x5745e) [0x56504508b45e] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x819) [0x7fc50440e4c9] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: ./git/tor/src/app/tor(do_main_loop+0x1fa) [0x56504508d6fa] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: ./git/tor/src/app/tor(tor_run_main+0x11d5) [0x56504508fdc5] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: ./git/tor/src/app/tor(tor_main+0x3a) [0x56504508804a] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: ./git/tor/src/app/tor(main+0x19) [0x565045087bc9] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7fc503326830] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
Sep 05 20:02:59.637 [err] Bug: ./git/tor/src/app/tor(_start+0x29) [0x565045087c19] (on Tor 0.3.5.0-alpha-dev 06c14f920900f999)
```Tor: 0.3.5.x-finalhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27471HS intermittently fails: Non-fatal assertion failed in send_introduce12020-06-27T13:52:18ZTracHS intermittently fails: Non-fatal assertion failed in send_introduce1When running 0.3.4.7-rc on Buster from deb.tpo
```
[WARN] Bug: /usr/bin/tor(_start+0x2a) [0x55edbc918eea]
[WARN] Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7fd267a49b17]
[WARN] Bug: /usr/bin/tor(main+0x1...When running 0.3.4.7-rc on Buster from deb.tpo
```
[WARN] Bug: /usr/bin/tor(_start+0x2a) [0x55edbc918eea]
[WARN] Bug: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7fd267a49b17]
[WARN] Bug: /usr/bin/tor(main+0x19) [0x55edbc918e99]
[WARN] Bug: /usr/bin/tor(tor_main+0x3a) [0x55edbc9190ea]
[WARN] Bug: /usr/bin/tor(tor_run_main+0x1005) [0x55edbc921155]
[WARN] Bug: /usr/bin/tor(do_main_loop+0x205) [0x55edbc91ea85]
[WARN] Bug: /usr/lib/x86_64-linux-gnu/libevent-2.1.so.6(event_base_loop+0x5a7) [0x7fd26873f537]
[WARN] Bug: /usr/lib/x86_64-linux-gnu/libevent-2.1.so.6(+0x229ba) [0x7fd26873e9ba]
[WARN] Bug: /usr/bin/tor(+0x5271e) [0x55edbc91c71e]
[WARN] Bug: /usr/bin/tor(connection_handle_read+0xa73) [0x55edbc9decf3]
[WARN] Bug: /usr/bin/tor(+0x11e016) [0x55edbc9e8016]
[WARN] Bug: /usr/bin/tor(channel_tls_handle_cell+0x4db) [0x55edbc9a3e4b]
[WARN] Bug: /usr/bin/tor(command_process_cell+0x318) [0x55edbc9c2368]
[WARN] Bug: /usr/bin/tor(circuit_receive_relay_cell+0x2c4) [0x55edbc9448f4]
[WARN] Bug: /usr/bin/tor(+0x788bb) [0x55edbc9428bb]
[WARN] Bug: /usr/bin/tor(rend_process_relay_cell+0x293) [0x55edbc94b9b3]
[WARN] Bug: /usr/bin/tor(hs_client_receive_rendezvous_acked+0x79) [0x55edbca31a89]
[WARN] Bug: /usr/bin/tor(connection_ap_attach_pending+0x178) [0x55edbc9e1e58]
[WARN] Bug: /usr/bin/tor(connection_ap_handshake_attach_circuit+0x3bd) [0x55edbc9c0f3d]
[WARN] Bug: /usr/bin/tor(hs_client_send_introduce1+0x232) [0x55edbca31382]
[WARN] Bug: /usr/bin/tor(tor_bug_occurred_+0xb9) [0x55edbca6e499]
[WARN] Bug: /usr/bin/tor(log_backtrace+0x43) [0x55edbca537a3]
[WARN] Bug: Non-fatal assertion !(ip == NULL) failed in send_introduce1 at ../src/or/hs_client.c:559. Stack trace:
[WARN] tor_bug_occurred_(): Bug: ../src/or/hs_client.c:559: send_introduce1: Non-fatal assertion !(ip == NULL) failed.
```
**Trac**:
**Username**: tgragnatoTor: 0.4.2.x-finalDavid Gouletdgoulet@torproject.orgDavid Gouletdgoulet@torproject.orghttps://gitlab.torproject.org/tpo/core/tor/-/issues/27470tor nightly build fails for Windows 64 bit with "error: conflicting types for...2020-06-27T13:52:18ZGeorg Koppentor nightly build fails for Windows 64 bit with "error: conflicting types for 'tor_tls_new'"Starting with today's nightly build `tor` compilation fails for Windows x86_64:
```
src/lib/tls/tortls_openssl.c:1010:1: error: conflicting types for 'tor_tls_new'
tor_tls_new(int sock, int isServer)
^~~~~~~~~~~
In file included from s...Starting with today's nightly build `tor` compilation fails for Windows x86_64:
```
src/lib/tls/tortls_openssl.c:1010:1: error: conflicting types for 'tor_tls_new'
tor_tls_new(int sock, int isServer)
^~~~~~~~~~~
In file included from src/lib/tls/tortls_openssl.c:59:0:
./src/lib/tls/tortls.h:91:12: note: previous declaration of 'tor_tls_new' was here
tor_tls_t *tor_tls_new(tor_socket_t sock, int is_server);
^~~~~~~~~~~
CC src/trunnel/hs/src_trunnel_libor_trunnel_a-cell_common.o
Makefile:12587: recipe for target 'src/lib/tls/src_lib_libtor_tls_a-tortls_openssl.o' failed
make[1]: *** [src/lib/tls/src_lib_libtor_tls_a-tortls_openssl.o] Error 1
make[1]: *** Waiting for unfinished jobs....
src/lib/tls/tortls_openssl.c:1010:1: error: conflicting types for 'tor_tls_new'
tor_tls_new(int sock, int isServer)
^~~~~~~~~~~
In file included from src/lib/tls/tortls_openssl.c:59:0:
./src/lib/tls/tortls.h:91:12: note: previous declaration of 'tor_tls_new' was here
tor_tls_t *tor_tls_new(tor_socket_t sock, int is_server);
^~~~~~~~~~~
make[1]: *** [src/lib/tls/src_lib_libtor_tls_testing_a-tortls_openssl.o] Error 1
Makefile:12489: recipe for target 'src/lib/tls/src_lib_libtor_tls_testing_a-tortls_openssl.o' failed
make[1]: Leaving directory '/var/tmp/build/tor-79a7fbb79b7f'
Makefile:4731: recipe for target 'all' failed
make: *** [all] Error 2
```https://gitlab.torproject.org/tpo/core/tor/-/issues/27468CI: add builds with the latest clang and gcc2020-07-28T22:59:51ZteorCI: add builds with the latest clang and gccWe could add the latest gcc and clang to our Travis matrix.
Travis is running older gcc and clang versions:
* Linux: Ubuntu's older clang and gcc
* macOS: Apple's custom clang, no gcc
Appveyor is already running gcc 8.2, and it seems t...We could add the latest gcc and clang to our Travis matrix.
Travis is running older gcc and clang versions:
* Linux: Ubuntu's older clang and gcc
* macOS: Apple's custom clang, no gcc
Appveyor is already running gcc 8.2, and it seems to be updated every 6-12 months.Tor: unspecifiedhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27467Remove unused GetAdaptersAddresses_fn_t2020-06-27T13:52:18ZteorRemove unused GetAdaptersAddresses_fn_tWe removed the code that uses this type in 0.3.5, but we forgot to remove the type itself.We removed the code that uses this type in 0.3.5, but we forgot to remove the type itself.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27465Windows: cast between incompatible function types in address.c2020-06-27T13:52:18ZteorWindows: cast between incompatible function types in address.c```
bash.exe : ../src/common/address.c: In function 'get_interface_addresses_win32':
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (../src/common/a...dresses_...```
bash.exe : ../src/common/address.c: In function 'get_interface_addresses_win32':
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (../src/common/a...dresses_win32'::String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
../src/common/address.c:1499:14: error: cast between incompatible function types from 'FARPROC' {aka 'long long int (*)()'} to 'ULONG (*)(ULONG, ULONG, void *, IP_ADAPTER_ADDRESSES_XP *, ULONG *)' {aka 'long unsigned int
(*)(long unsigned int, long unsigned int, void *, struct _IP_ADAPTER_ADDRESSES_XP *, long unsigned int *)'} [-Werror=cast-function-type]
if (!(fn = (GetAdaptersAddresses_fn_t)
^
```
https://ci.appveyor.com/project/teor2345/tor/build/1.0.152/job/g7dxnnck0r3p66n9#L1093Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27464Appveyor: stop reinstalling packages that haven't been updated2020-06-27T13:52:18ZteorAppveyor: stop reinstalling packages that haven't been updatedIf we give pacman the --needed argument, it will stop reinstalling identical packages.If we give pacman the --needed argument, it will stop reinstalling identical packages.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27463hs: rend_client_send_introduction v0 string truncation warning2020-06-27T13:52:18Zteorhs: rend_client_send_introduction v0 string truncation warning```
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I.. -I../src/ext -Isrc/ext -I../src/ext/trunnel -I../src/trunnel -I../src/common -Isrc/common -I../src/ext/trunnel -I../src/trunnel -I../src/or -Isrc/or -DSHARE_DATADIR="\"/mingw64/share\"...```
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I.. -I../src/ext -Isrc/ext -I../src/ext/trunnel -I../src/trunnel -I../src/common -Isrc/common -I../src/ext/trunnel -I../src/trunnel -I../src/or -Isrc/or -DSHARE_DATADIR="\"/mingw64/share\"" -DLOCALSTATEDIR="\"/mingw64/var\"" -DBINDIR="\"/mingw64/bin\"" -I../src -I../src/common -I/c/OpenSSL-Win64/include -IC:/msys64/mingw64/include -g -O2 -fasynchronous-unwind-tables -Wall -fno-strict-aliasing -Waddress -Warray-bounds -Wdate-time -Wdouble-promotion -Wduplicate-decl-specifier -Wduplicated-cond -Wextra -Wfloat-conversion -Wignored-attributes -Wimplicit-fallthrough -Winit-self -Wlogical-op -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn -Wnormalized=nfkc -Wnull-dereference -Woverlength-strings -Woverride-init -Wshadow -Wshift-count-negative -Wshift-count-overflow -Wshift-negative-value -Wshift-overflow=2 -Wsizeof-array-argument -Wstrict-overflow=1 -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wswitch-bool -Wsync-nand -Wtrampolines -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-const-variable=2 -Wunused-local-typedefs -Wvariadic-macros -W -Wfloat-equal -Wundef -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings -Wnested-externs -Wbad-function-cast -Wswitch-enum -Waggregate-return -Wpacked -Wunused -Wunused-parameter -Wold-style-definition -Wmissing-declarations -Werror -MT src/or/rendclient.o -MD -MP -MF $depbase.Tpo -c -o src/or/rendclient.o ../src/or/rendclient.c ...
bash.exe : ../src/or/rendclient.c: In function 'rend_client_send_introduction':
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (../src/or/rendc..._introduction'::String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
../src/or/rendclient.c:243:5: error: 'strncpy' output may be truncated copying 20 bytes from a string of length 41 [-Werror=stringop-truncation]
strncpy(tmp, rendcirc->build_state->chosen_exit->nickname,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(MAX_NICKNAME_LEN+1)); /* nul pads */
~~~~~~~~~~~~~~~~~~~~~
```
https://ci.appveyor.com/project/teor2345/tor/build/1.0.149/job/yttwj9fom8k0jh5c#L1253Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27461Windows: cast between incompatible function types in main2020-06-27T13:52:18ZteorWindows: cast between incompatible function types in main```
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I.. -I../src/ext -Isrc/ext -I../src/ext/trunnel -I../src/trunnel -I../src/common -Isrc/common -I../src/ext/trunnel -I../src/trunnel -I../src/or -Isrc/or -DSHARE_DATADIR="\"/mingw64/share\"...```
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I.. -I../src/ext -Isrc/ext -I../src/ext/trunnel -I../src/trunnel -I../src/common -Isrc/common -I../src/ext/trunnel -I../src/trunnel -I../src/or -Isrc/or -DSHARE_DATADIR="\"/mingw64/share\"" -DLOCALSTATEDIR="\"/mingw64/var\"" -DBINDIR="\"/mingw64/bin\"" -I../src -I../src/common -I/c/OpenSSL-Win64/include -IC:/msys64/mingw64/include -g -O2 -fasynchronous-unwind-tables -Wall -fno-strict-aliasing -Waddress -Warray-bounds -Wdate-time -Wdouble-promotion -Wduplicate-decl-specifier -Wduplicated-cond -Wextra -Wfloat-conversion -Wignored-attributes -Wimplicit-fallthrough -Winit-self -Wlogical-op -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn -Wnormalized=nfkc -Wnull-dereference -Woverlength-strings -Woverride-init -Wshadow -Wshift-count-negative -Wshift-count-overflow -Wshift-negative-value -Wshift-overflow=2 -Wsizeof-array-argument -Wstrict-overflow=1 -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wswitch-bool -Wsync-nand -Wtrampolines -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-const-variable=2 -Wunused-local-typedefs -Wvariadic-macros -W -Wfloat-equal -Wundef -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings -Wnested-externs -Wbad-function-cast -Wswitch-enum -Waggregate-return -Wpacked -Wunused -Wunused-parameter -Wold-style-definition -Wmissing-declarations -Werror -MT src/or/main.o -MD -MP -MF $depbase.Tpo -c -o src/or/main.o ../src/or/main.c &&\
...
bash.exe : ../src/or/main.c: In function 'tor_run_main':
At line:2 char:5
+ & $commandPath $args 2>&1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (../src/or/main....'tor_run_main'::String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
../src/or/main.c:4215:28: error: cast between incompatible function types from 'FARPROC' {aka 'long long int (*)()'} to 'BOOL (*)(DWORD)' {aka 'int (*)(long unsigned int)'} [-Werror=cast-function-type]
PSETDEP setdeppolicy = (PSETDEP)GetProcAddress(hMod,
^
```
https://ci.appveyor.com/project/teor2345/tor/build/1.0.138/job/691be5b3uror0sok#L1146Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27460Appveyor: --disable-gcc-hardening2020-06-27T13:52:19ZteorAppveyor: --disable-gcc-hardening--disable-gcc-hardening gets us further, but there are still more errors.--disable-gcc-hardening gets us further, but there are still more errors.Tor: 0.3.4.x-finalteorteorhttps://gitlab.torproject.org/tpo/core/tor/-/issues/27453Travis: don't exit when showing the logs fails2020-06-27T13:52:19ZteorTravis: don't exit when showing the logs failsTor: 0.3.5.x-finalteorteor