The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2022-05-17T10:33:21Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40883[Connection Settings] Ask for confirmation before removing all bridges2022-05-17T10:33:21ZPier Angelo Vendrame[Connection Settings] Ask for confirmation before removing all bridgesFor #40861 we added a button to remove all the bridge lines at once.
However, users may confuse it with a "collapse bridge lines" again, and click it by mistake.
Therefore, we should ask whether they are sure they really want to delete...For #40861 we added a button to remove all the bridge lines at once.
However, users may confuse it with a "collapse bridge lines" again, and click it by mistake.
Therefore, we should ask whether they are sure they really want to delete all the bridges.Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40892[torconnect] Highlight the UI elements in error red instead of the breadcrumb2022-05-17T10:33:47Zdonuts[torconnect] Highlight the UI elements in error red instead of the breadcrumbHere's an example:
![torconnect-assist-location-check_2x](/uploads/f95f777d0b7f9b4e3a5021ed1091bf61/torconnect-assist-location-check_2x.png)
The idea is to move the red error highlighting from the tab to the actions themselves, since t...Here's an example:
![torconnect-assist-location-check_2x](/uploads/f95f777d0b7f9b4e3a5021ed1091bf61/torconnect-assist-location-check_2x.png)
The idea is to move the red error highlighting from the tab to the actions themselves, since this seems like a more useful place to draw the user's attention. Initially I kept the error highlighting in the breadcrumb too, but it was a little too much.Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40893[Connection Settings] Use a lighter background for bridge-moji2022-05-17T10:33:56Zdonuts[Connection Settings] Use a lighter background for bridge-mojiSome of the emoji are a little hard to see in 11.5a9, could we change the grey used behind them to grey-90 at 5% opacity please?
It should look like so:
![connected-builtin-obfs4-collapsed_2x](/uploads/af5fdaf7d356eff424d61739619686f1/...Some of the emoji are a little hard to see in 11.5a9, could we change the grey used behind them to grey-90 at 5% opacity please?
It should look like so:
![connected-builtin-obfs4-collapsed_2x](/uploads/af5fdaf7d356eff424d61739619686f1/connected-builtin-obfs4-collapsed_2x.png)Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40894[Connection Settings] Switch the bridge line text to grey-602022-05-17T10:34:03Zdonuts[Connection Settings] Switch the bridge line text to grey-60Could you lighten the bridge line text (e.g. "obfs4 185.82.202.15:443 07E3239A...") in both the collapsed and expanded states to grey-60 please?
I think it's slightly easier on the eye when there are a lot of bridge lines visible:
![co...Could you lighten the bridge line text (e.g. "obfs4 185.82.202.15:443 07E3239A...") in both the collapsed and expanded states to grey-60 please?
I think it's slightly easier on the eye when there are a lot of bridge lines visible:
![connected-builtin-obfs4-expanded_2x](/uploads/4bd69a890b2f8bd14f47b9409d6fe3d9/connected-builtin-obfs4-expanded_2x.png)Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40895[Connection Settings] Expand bridge automatically if connected (or it's the o...2022-05-17T10:34:12Zdonuts[Connection Settings] Expand bridge automatically if connected (or it's the only one)Would it be possible to automatically expand the bridge card in connection settings if it meets one of the following conditions?
- It's the one Tor Browser is currently connected to
- Or if it's the only bridge configuredWould it be possible to automatically expand the bridge card in connection settings if it meets one of the following conditions?
- It's the one Tor Browser is currently connected to
- Or if it's the only bridge configuredSponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40897[torconnect] Limit the extent of the "Show All Bridges" fade2022-05-17T10:34:18Zdonuts[torconnect] Limit the extent of the "Show All Bridges" fadeCould we adjust the fade that leads to the "Show all bridges" button please? At the moment some of the bridge lines look disabled.
For ref – in Figma the fade only applies to the last item before the button, like so:
<img src="/upload...Could we adjust the fade that leads to the "Show all bridges" button please? At the moment some of the bridge lines look disabled.
For ref – in Figma the fade only applies to the last item before the button, like so:
<img src="/uploads/70532ffad55b64cfb8032a76d73b661a/figma-fade.png" width=75% />
If that's not possible let me know and we can figure out something else :)
**Screenshot**
![current-bridges-fade-screenshot](/uploads/c9f268cea2f0fb3a5987a848a3b43749/current-bridges-fade-screenshot.png)
**Full mockup**
![connected-builtin-obfs4-collapsed_2x](/uploads/af5fdaf7d356eff424d61739619686f1/connected-builtin-obfs4-collapsed_2x.png)Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40888[torconnect] Add initial "Connect to Tor" tab to breadcrumb2022-05-17T10:36:54Zdonuts[torconnect] Add initial "Connect to Tor" tab to breadcrumbIn the latest iteration of Connection Assist's design in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40781#note_2794457, I added Connect to Tor as the first tab in the breadcrumb sequence. This is to help facilita...In the latest iteration of Connection Assist's design in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40781#note_2794457, I added Connect to Tor as the first tab in the breadcrumb sequence. This is to help facilitate backwards navigation after a failed attempt at a regular connection, and is intended as a more permanent solution to simply renaming the "Connect" button to "Try Again" in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40874:
![torconnect-assist-connect_2x](/uploads/7ba1b5e571968fae4c0a1878229a0ea8/torconnect-assist-connect_2x.png)
Notes:
- After the first attempt fails, users should still be forwarded to Connection Assist – i.e. the second tab in the sequence.
- Connect to Tor should also remain breadcrumbless by default as per the designs in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40780, unless Connection Assist has been fired up in response to a connection error.
- Once users are able to navigate back to Connect to Tor using the breadcrumb, the Connect/Try Again button may be removed from the Connection Assist tab.
The intended UX can be demo'd using this prototype too: [Figma prototype](https://www.figma.com/proto/Vsh1aPOZGneDX4Zp27mjsK/torconnect?page-id=1667%3A11813&node-id=1767%3A10994&viewport=289%2C48%2C0.56&scaling=min-zoom&starting-point-node-id=1767%3A10994)Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40896[Connection Settings] Update strings for current bridges2022-05-17T10:47:13Zdonuts[Connection Settings] Update strings for current bridgesI added a new string below the "Your Current Bridges" heading to help explain what's going on when the user sees multiple bridgelines:
> `You can keep one or more bridges saved, and Tor will choose which one to use when you connect to t...I added a new string below the "Your Current Bridges" heading to help explain what's going on when the user sees multiple bridgelines:
> `You can keep one or more bridges saved, and Tor will choose which one to use when you connect to the Tor Network. If it fails, Tor will automatically switch to another.`
I think that's vaguely accurate – right?
I also shortened the string within the bridge card itself a little:
> `Share this bridge using the QR code or by copying its address:`
Here's how it looks in practice (although we should comment out the Learn mores within the Current Bridges section and bridge cards until the tb-manual is updated with destinations for them):
![connected-builtin-obfs4-collapsed_2x](/uploads/af5fdaf7d356eff424d61739619686f1/connected-builtin-obfs4-collapsed_2x.png)Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/android-components/-/issues/40076Rebase android-components patches to 99.02022-05-17T12:39:56ZaguestuserRebase android-components patches to 99.0Rebase android-components patches from [android-components-96.0.15-11.5-1](http://eweiibe6tdjsdprb4px6rqrzzcsi22m4koia44kc5pcjr7nec2rlxyad.onion/tpo/applications/android-components/-/tree/android-components-96.0.15-11.5-1) to [android-co...Rebase android-components patches from [android-components-96.0.15-11.5-1](http://eweiibe6tdjsdprb4px6rqrzzcsi22m4koia44kc5pcjr7nec2rlxyad.onion/tpo/applications/android-components/-/tree/android-components-96.0.15-11.5-1) to [android-components-99.0.3-11.5-1](http://eweiibe6tdjsdprb4px6rqrzzcsi22m4koia44kc5pcjr7nec2rlxyad.onion/tpo/applications/android-components/-/tree/android-components-99.0.3-11.5-1)Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40461Prepare stable release 11.0.12 (Android)2022-05-17T12:45:52ZrichardPrepare stable release 11.0.12 (Android)<details>
<summary>Explanation of variables</summary>
- `$(TOR_LAUNCHER_VERSION)` : version of `tor-launcher`, used in tags
- example : `0.2.33`
- `$(ESR_VERSION)` : the Mozilla defined ESR version, used in various places for buil...<details>
<summary>Explanation of variables</summary>
- `$(TOR_LAUNCHER_VERSION)` : version of `tor-launcher`, used in tags
- example : `0.2.33`
- `$(ESR_VERSION)` : the Mozilla defined ESR version, used in various places for building tor-browser tags, labels, etc
- example : `91.6.0`
- `$(ESR_TAG)` : the Mozilla defined hg (Mercurial) tag associated with `$(ESR_VERSION)`
- exmaple : `FIREFOX_91_7_0esr_BUILD2`
- `$(TOR_BROWSER_MAJOR)` : the Tor Browser major version
- example : `11`
- `$(TOR_BROWSER_MINOR)` : the Tor Browser minor version
- example : either `0` or `5`; Alpha's is always (Stable + 5) % 10
- `$(FIREFOX_BUILD_N)` : the firefox build revision within a given `tor-browser` branch; this is separate from the `$(TOR_BROWSER_BUILD_N) ` value
- example : `build1`
- `$(TOR_BROWSER_BUILD_N)` : the tor-browser build revision for a given Tor Browser release; used in tagging git commits
- example : `build2`
- *NOTE* : `$(FIREFOX_BUILD_N)` and `$(TOR_BROWSER_BUILD_N)` typically are the same, but it is possible for them to diverge. For example :
- if we have multiple Tor Browser releases on a given ESR branch the two will become out of sync as the `$(FIREFOX_BUILD_N)` value will increase, while the `$(TOR_BROWSER_BUILD_N)` value may stay at `build1` (but the `$(TOR_BROWSER_VERSION)` will increase)
- if we have build failures unrelated to `tor-browser`, the `$(TOR_BROWSER_BUILD_N)` value will increase while the `$(FIREFOX_BUILD_N)` will stay the same.
- `$(TOR_BROWSER_VERSION)` : the published Tor Browser version
- example : `11.5a6`, `11.0.7`
</details>
### fenix
- [x] Sign/Tag commit: `tor-browser-96.3.0-11.0-1-build2`
- [x] Push tag to GitLab
### android-components
- [x] Sign/Tag commit: `android-components-96.0.15-11.0-1` (not updated from 11.0.8)
- [x] Push tag to GitLab
### geckoview
- [x] Sign/Tag commit: `geckoview-96.0.3-11.0-1-build2`
- [x] Push tag to Gitolite
### tor-browser-build
- [x] Update `rbm.conf`
- [x] `var/torbrowser_version` : update to next version
- [x] `var/torbrowser_build` : update to `$(TOR_BROWSER_BUILD_N)`
- [x] ***(Android Only)*** Update allowed_addons.json by running (from `tor-browser-build` root)`./tools/fetch_allowed_addons.py > projects/tor-browser/allowed_addons.json
- [x] Check for NoScript updates here : https://addons.mozilla.org/en-US/firefox/addon/noscript - no updates, stay on 11.4.5
- [x] Check for openssl updates here : https://github.com/openssl/openssl/tags
- [x] update to 1.1.1o
- [x] Check for tor updates here: https://gitlab.torproject.org/tpo/core/tor/-/tags
- [x] Stay on 0.4.6.10, as requested in #40479
- [x] Check for go updates here : https://golang.org/dl - already at 1.17.9
- [x] Update `ChangeLog.txt`
- [x] Open MR with above changes
- [x] Sign/Tag commit : `make signtag-(alpha|release)`
- [x] Push tag to origin
### blog
- [x] Duplicate previous Stable or Alpha release blog post as appropriate to new directory under `content/blog/new-release-tor-browser-$(TOR_BROWSER_VERSION)` and update with info on release :
- [x] Update Tor Browser version numbers
- [x] Note any ESR rebase
- [x] Link to any Firefox security updates
- [x] Note any updates to :
- [x] tor
- [x] openssl
- [x] go
- [x] noscript
- [x] Convert ChangeLog.txt to markdown format used here by : `tor-browser-build/tools/changelog-format-blog-post`
- [x] Push to origin as new branch, open 'Draft :' MR
- [x] Remove draft from MR once signed-packages are uploaded
### website
- [x] `databags/versions.ini` : Update the downloads versions
- `torbrowser-stable/version` : sort of a catch-all for latest stable version
- `torbrowser-stable/win32` : tor version in the expert bundle
- `torbrowser-*-stable/version` : platform-specific stable versions
- `torbrowser-*-alpha/version` : platform-specific alpha versions
- `tor-stable`,`tor-alpha` : set by tor devs, do not touch
- Git commit commands:
- For all platforms: `git commit databags/versions.ini -m "Add new Tor Browser version ${VERSION}"`
- For only desktop platforms: `git commit databags/versions.ini -m "Add new Tor Browser version ${VERSION} (desktop)"`
- For only Android platform: `git commit databags/versions.ini -m "Add new Tor Browser version ${VERSION} (Android)"`
- [x] Push to origin as new branch, open 'Draft :' MR
- [x] Remove draft from MR once signed-packages are uploaded
### unsigned build uploads
- [x] Upload unsigned builds to people.torproject.org
- [x] Email tor-qa@lists.torproject.org with links to unsigned builds
### signing (Android)
- [x] Sign apks using alpha or release signing key
- [x] Upload packages to signing machine
- [x] Create OpenPGP detached signatures
### signed build uploads
- [x] Upload all build artifacts to web server
- [x] Upload signed apks, shasums, and detached signature files to web server
- [x] Synchronize all packages to web server mirrorsPier Angelo VendramePier Angelo Vendrame2022-04-07https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40918[torconnect] In 11.5a11 the breadcrumbs are visible on the first bootstrap2022-05-17T12:46:51ZPier Angelo Vendrame[torconnect] In 11.5a11 the breadcrumbs are visible on the first bootstrapDuring the first bootstrap, the breadcrumbs should not visible.
During all the changes, however, I introduced a regression for which they now are.During the first bootstrap, the breadcrumbs should not visible.
During all the changes, however, I introduced a regression for which they now are.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40890[torconnect] Combine "Connection Assist" and "Location Settings" into a singl...2022-05-17T13:09:50Zdonuts[torconnect] Combine "Connection Assist" and "Location Settings" into a single tabIn the usability testing @nah conducted in https://gitlab.torproject.org/tpo/ux/research/-/issues/52, only one user realized Tor Browser was using their location when attempting to try a bridge. To ensure we get informed consent for this...In the usability testing @nah conducted in https://gitlab.torproject.org/tpo/ux/research/-/issues/52, only one user realized Tor Browser was using their location when attempting to try a bridge. To ensure we get informed consent for this feature and bring the location UI forward we've combined the Connection Assist and Location Settings tabs into one:
![torconnect-assist_2x](/uploads/a2ad5c57a870bd7112401592d798afce/torconnect-assist_2x.png)
Given that change, we'll also need to incorporate and default to the "Automatic" option that's currently present in Connection Settings (see https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40782#note_2771120 for reference).
And provide a dedicated error screen for when autolocate fails:
![torconnect-autolocate-error_2x](/uploads/2b9d9d306e5749c542f68f15d390b61f/torconnect-autolocate-error_2x.png)Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/web/community/-/issues/274Add Russian translation2022-05-17T13:10:33ZemmapeelAdd Russian translationWe have several sections translated to Russian, and given this is such a big website with so many different sections we have decided to publish even if we have not completed the whole site.We have several sections translated to Russian, and given this is such a big website with so many different sections we have decided to publish even if we have not completed the whole site.emmapeelemmapeelhttps://gitlab.torproject.org/tpo/core/arti/-/issues/180Periodic events should wake up less often2022-05-17T13:19:40ZNick MathewsonPeriodic events should wake up less oftenRight now, we have a few periodic events that probe for some condition once a second. That's not great! Instead we should have them run as needed based on a real scheduler of some kind, possibly with a mechanism to run them ahead-of-t...Right now, we have a few periodic events that probe for some condition once a second. That's not great! Instead we should have them run as needed based on a real scheduler of some kind, possibly with a mechanism to run them ahead-of-time.
For any periodic events that _can't_ be made to run less often, we need to use something like Tor's Dormant mode to disable them when we're offline (see #71).
Subtasks.
* [ ] Generic "periodic event that can be turned on and off" implementation. (est 16h)
* [ ] `continually_expire_channels` (est 2h)
* [ ] `continually_launch_timeout_testing_circuits` (est 2h)
* [ ] `continually_build_preemptive_circuits` (est 8h)
* [ ] `circmgr::mgr::spawn_expiration_task` (est 2h)
* [ ] `update_persistent_state` (est 2h)
* [ ] Directory updater task. (est 8h)Arti 1.0.0: Ready for production useetaetahttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40887Implement amends to torconnect and Connection Settings following 11.5a92022-05-17T13:29:06ZdonutsImplement amends to torconnect and Connection Settings following 11.5a9This is the parent ticket for any amends to torconnect or Connection Settigns that didn't make it in time for 11.5a9, with the intention that they can be fixed for the next Alpha instead.This is the parent ticket for any amends to torconnect or Connection Settigns that didn't make it in time for 11.5a9, with the intention that they can be fixed for the next Alpha instead.Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/network-health/metrics/onionperf/-/issues/40026Wait until a tgen transfer finishes before starting a new one2022-05-17T14:09:30ZAna CusturaWait until a tgen transfer finishes before starting a new oneFrom the discussion in https://gitlab.torproject.org/tpo/metrics/onionperf/-/issues/40018 it looks like we really want to avoid overlapping transfers for S61 experiments.
I will have a look at what we can do with tgen to achieve this.From the discussion in https://gitlab.torproject.org/tpo/metrics/onionperf/-/issues/40018 it looks like we really want to avoid overlapping transfers for S61 experiments.
I will have a look at what we can do with tgen to achieve this.https://gitlab.torproject.org/tpo/network-health/metrics/onionperf/-/issues/40016Errors/Time visualizations break when using Seaborn 0.112022-05-17T14:09:30ZAna CusturaErrors/Time visualizations break when using Seaborn 0.11Pip now installs Seaborn 0.11 by default. Our code to visualize transfer errors over time does not work as intented with this new version (see attached side-by-side screenshot between 0.10.1 and 0.11.0).
I had a quick look at https://se...Pip now installs Seaborn 0.11 by default. Our code to visualize transfer errors over time does not work as intented with this new version (see attached side-by-side screenshot between 0.10.1 and 0.11.0).
I had a quick look at https://seaborn.pydata.org/whatsnew.html to work out why, and noticed the new Seaborn version also adds a ecdf plot: https://seaborn.pydata.org/generated/seaborn.ecdfplot.html#seaborn.ecdfplot
We might consider using this to plot our ecdfs, and require Seaborn >= 0.11.0
Happy to make both these changes as part of this ticket.![Screenshot_2020-12-11_at_10.01.34](/uploads/4d2f46d1c8f021ccfb04acb112401ed6/Screenshot_2020-12-11_at_10.01.34.png)Ana CusturaAna Custurahttps://gitlab.torproject.org/tpo/network-health/metrics/onionperf/-/issues/40013Write tests for data-wrangling parts in the visualize mode2022-05-17T14:09:30ZKarsten LoesingWrite tests for data-wrangling parts in the visualize modeAs spotted by @gaba in #40012, we don't have tests for the visualize mode. Let's work on tests for the data-wrangling parts that take analysis files as input and produce data frames as output.As spotted by @gaba in #40012, we don't have tests for the visualize mode. Let's work on tests for the data-wrangling parts that take analysis files as input and produce data frames as output.https://gitlab.torproject.org/tpo/network-health/metrics/onionperf/-/issues/40014Onionperf switch for stopping measurements after a specific number of build t...2022-05-17T14:09:30ZGeorge KadianakisOnionperf switch for stopping measurements after a specific number of build time eventsHello,
in https://gitlab.torproject.org/tpo/core/tor/-/issues/40157 we run experiments until 1k circuit build time events are gathered. I tried to automate the experiments by running onionperf with `--tgen-num-transfers` so that it stop...Hello,
in https://gitlab.torproject.org/tpo/core/tor/-/issues/40157 we run experiments until 1k circuit build time events are gathered. I tried to automate the experiments by running onionperf with `--tgen-num-transfers` so that it stops after 1k transfers, but that does not seem to reflect the number of CBT events emited on the control port.
I remember that with `--tgen-num-transfers 1000` I only got about 120 `BUILDTIMEOUT_SET` events on the control port. I will redo this experiment to make sure that I remember right and also check the number of build times on the state file.
\cc @acute @mikeperry @karstenSponsor 61 - Making the Tor network faster & more reliable for users in Internet-repressive placesAna CusturaAna Custurahttps://gitlab.torproject.org/tpo/network-health/metrics/onionperf/-/issues/40029Update link to onionperf repo after metrics projects moved2022-05-17T14:32:42ZGeorg KoppenUpdate link to onionperf repo after metrics projects movedWe should update the link to the onionperf repo as all the metrics repositories got moved to the network-health space.We should update the link to the onionperf repo as all the metrics repositories got moved to the network-health space.Georg KoppenGeorg Koppen