The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2020-06-27T14:39:14Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/18951Mac OS: HTTPS-E missing after update2020-06-27T14:39:14ZMark SmithMac OS: HTTPS-E missing after updateIn the TB 6.0a5 installable packages (dmg files), HTTPS-E is included under TorBrowser.app/Contents/Resources/distribution/extensions as expected. But after completing an incremental update from TB 6.0a4 to 6.0a5, the HTTPS-E extension i...In the TB 6.0a5 installable packages (dmg files), HTTPS-E is included under TorBrowser.app/Contents/Resources/distribution/extensions as expected. But after completing an incremental update from TB 6.0a4 to 6.0a5, the HTTPS-E extension is missing.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/18950Disable or audit Reader View in ESR 452020-06-27T14:39:14ZGeorg KoppenDisable or audit Reader View in ESR 45Firefox ships with a new feature, Reader View (https://support.mozilla.org/en-US/kb/firefox-reader-view-clutter-free-web-pages). We should audit it or disable it for the time being if we don't get to that.Firefox ships with a new feature, Reader View (https://support.mozilla.org/en-US/kb/firefox-reader-view-clutter-free-web-pages). We should audit it or disable it for the time being if we don't get to that.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/anti-censorship/bridgedb/-/issues/18949Update BridgeDB's CI to run tests with next version of Twisted2020-06-27T13:43:01ZIsis LovecruftUpdate BridgeDB's CI to run tests with next version of Twisted[BridgeDB's CI](https://travis-ci.org/isislovecruft/bridgedb/builds/127250227) is set up to run the tests several times, with the idea that it runs one time each with installed versions of Twisted and PyOpenSSL included in both Debian st...[BridgeDB's CI](https://travis-ci.org/isislovecruft/bridgedb/builds/127250227) is set up to run the tests several times, with the idea that it runs one time each with installed versions of Twisted and PyOpenSSL included in both Debian stable and testing (so that we always know that we can run on the next stable release). Since we recently upgraded to Debian jessie, these versions are now outdated.Isis LovecruftIsis Lovecrufthttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/18948"Check for Tor Browser Update" label should by dynamic2022-06-18T01:34:44ZMark Smith"Check for Tor Browser Update" label should by dynamicAs discussed on IRC, it is a little irritating (and potentially confusing) that Tor Browser displays "WARNING: this browser is out of date" but then directs users to choose "Check for Tor Browser Update" (clearly, the browser already kno...As discussed on IRC, it is a little irritating (and potentially confusing) that Tor Browser displays "WARNING: this browser is out of date" but then directs users to choose "Check for Tor Browser Update" (clearly, the browser already knows that there is an update available).
We could change the text of that Torbutton menu item to "Update Tor Browser" in this situation or we could go even further and add an "Update Now" button to the about:tor page.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/189476.0a5 is not starting on OS X if put into /Applications2020-06-27T14:39:14ZGeorg Koppen6.0a5 is not starting on OS X if put into /ApplicationsNick reported that 6.0a5 on OS X is neither starting after an update nor after being freshly downloaded. The error message is: Tor launcher\n\nTor unexpectedly exited. This might be a bug in Tor itself...
Running "tor.real" from the com...Nick reported that 6.0a5 on OS X is neither starting after an update nor after being freshly downloaded. The error message is: Tor launcher\n\nTor unexpectedly exited. This might be a bug in Tor itself...
Running "tor.real" from the command line is starting it fine.
After a bit of testing it turned out that putting it on the desktop is working fine, too. Just having it in /Applications produces the bug. I guess this is due to legacy/trac#13252.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/18946Investigate fingerprinting potential of lack of H.264 support2022-06-18T01:33:39ZGeorg KoppenInvestigate fingerprinting potential of lack of H.264 supportOn Linux H.264 is enabled as long as ffmpeg is available. This might be a fingerprinting vector. We should investigate whether this is actually the case.On Linux H.264 is enabled as long as ffmpeg is available. This might be a fingerprinting vector. We should investigate whether this is actually the case.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/18945Disable monitoring the connected state of Tor Browser users2022-11-10T11:46:53ZGeorg KoppenDisable monitoring the connected state of Tor Browser users`network.manage-offline-status` should be set to `false` again in order to disable monitoring the connected state of users. (basically enabling the status quo ante).`network.manage-offline-status` should be set to `false` again in order to disable monitoring the connected state of users. (basically enabling the status quo ante).https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/18944Remove block-malicious-sites-checkbox on TLS error page2020-06-27T14:39:14ZGeorg KoppenRemove block-malicious-sites-checkbox on TLS error pageIf a secure connection failed the error page contains a checkbox stating "Report errors like this to help Mozilla identify and block malicious sites". We don't want to do this.If a secure connection failed the error page contains a checkbox stating "Report errors like this to help Mozilla identify and block malicious sites". We don't want to do this.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/core/tor/-/issues/18943sha3 testsuite fails on big endian hosts2020-06-27T13:59:09Zweasel (Peter Palfrader)sha3 testsuite fails on big endian hostsHi,
looking at the current https://buildd.debian.org/status/package.php?p=tor&suite=experimental, in particular at
https://buildd.debian.org/status/fetch.php?pkg=tor&arch=mips&ver=0.2.8.2-alpha-1&stamp=1461496211
https://buildd.debian....Hi,
looking at the current https://buildd.debian.org/status/package.php?p=tor&suite=experimental, in particular at
https://buildd.debian.org/status/fetch.php?pkg=tor&arch=mips&ver=0.2.8.2-alpha-1&stamp=1461496211
https://buildd.debian.org/status/fetch.php?pkg=tor&arch=powerpc&ver=0.2.8.2-alpha-1&stamp=1461451662
https://buildd.debian.org/status/fetch.php?pkg=tor&arch=s390x&ver=0.2.8.2-alpha-1&stamp=1461436567
suggests that the sha3 test suite fails on big-endian hosts.
```
crypto/sha3: [forking]
FAIL ../src/test/test_crypto.c:506: assert(data == mem_op_hex_tmp): E241F247AF432EEDB73B6377C955F93F42B162AD7A2047E468381A59451EB178 vs 677035391CD3701293D385F037BA32796252BB7CE180B00B582DD9B20AAAD7F0
[sha3 FAILED]
crypto/sha3_xof: [forking]
FAIL ../src/test/test_crypto.c:854: assert(out == mem_op_hex_tmp): 62FBE70B8BA99C650A17E57A921F558D0D24DF1C960463DE4DEAB998B4287550F3B909E83FA6B202873F3DAF9AE3A816014814386C8534CAF25E828F80AB0B8E233D669CCC0C0A94213896DB9018714D096C82AF8B52D68906B28F636CDE99EC5C78C31D992A66E4D957C41AFBD27A776AD3F486728BE7B4AE5DBA090AA6B3D0B858E7730CF59727E505F757E8441BAD63639FABFB40AE3F647DECDB7AF60BC6B4A93C2F3300A97698BC84B0AAEDD8FC278CC1AF9C33B09712443CD5F1D4713582EA1E40C0F3C4F2D3D854747803EC55EAD1ED512E964053A193137EB9BC4DD97D619F679401AF7B152D264793E7F886C0FECA5F5D4C9F2AB01C66558256BC2FE8E322F3B8D159960E53B63D7EF207588B402018F0C1AA8CEEDDB44BA32071F5D3EBB426CFEC939462BCE590BE7CD968534552103A38C428B36F8E832F05C7BDFEC0935C2893C0D875C0A43089A484CF4F60E2A80434BBB90068870ACADCE6B59521B19ECECDD14B237D0E149FE40ABC2188DA16C0527A19FE9584BF925199CAB95B9504561E24D648F64A088C58A336D78111852C4F8782882D9F7D9AF7B82960D682D83DD5FD681DF07BD47B116393DFEDEBDCA3DB464B68CA9DBF6AD3756FCFAE3BBD7E4B4737D8556081C855414A722EDEB7FF4B31AF4F3FF5F65368A9CE2F7BAA3507CFAFBF455F164143BC6F5CE4554F695EFAD65513116C26BA915750 vs 8A5199B4A7E133E264A86202720655894D48CFF344A928CF8347F48379CEF347DFC5BCFFAB99B27B1F89AA2735E23D30088FFA03B9EDB02B9635470AB9F1038985D55F9CA774572DD006470EA65145469609F9FA0831BF1FFD842DC24ACADE27BD9816E3B5BF2876CB112232A0EB4475F1DFF9F5C713D9FFD4CCB89AE5607FE35731DF06317949EEF646E9591CF3BE53ADD6B7DD2B6096E2B3FB06E662EC8B2D77422DAAD9463CD155204ACDBD38E319613F39F99B6DFB35CA9365160066DB19835888C2241FF9A731A4ACBB5663727AAC34A401247FBAA7499E7D5EE5B69D31025E63D04C35C798BCA1262D5673A9CF0930B5AD89BD485599DC184528DA4790F088EBD170B635D9581632D2FF90DB79665CED430089AF13C9F21F6D443A818064F17AEC9E9C5457001FA8DC6AFBADBE3138F388D89D0E6F22F66671255B210754ED63D81DCE75CE8F189B534E6D6B3539AA51E837C42DF9DF59C71E6171CD4902FE1BDC73FB1775B5C754A1ED4EA7F3105FC543EE0418DAD256F3F6118EA77114A16C15355B42877A1DB2A7DF0E155AE1D8670ABCEC3450F4E2EEC9838F895423EF63D261138BAAF5D9F104CB5A957AEA06C0B9B8C78B0D441796DC0350DDEABB78A33B6F1F9E68EDE3D1805C7B7E2CFD54E0FAD62F0D8CA67A775DC4546AF9096F2EDB221DB42843D65327861282DC946A0BA01A11863AB2D1DFD16E3973D4
[sha3_xof FAILED]
```Tor: 0.2.8.x-finalYawning AngelYawning Angelhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/18942"Download an external file type?" dialog appears on wrong X11 workspace/desktop2022-06-18T01:32:34Zcypherpunks"Download an external file type?" dialog appears on wrong X11 workspace/desktop* Find some downloadable file on the web and click on it to bring up the "Download an external file type?" dialog.
* Before the dialog appears, quickly switch to a different X11 workspace that has another Tor Browser window open.
The d...* Find some downloadable file on the web and click on it to bring up the "Download an external file type?" dialog.
* Before the dialog appears, quickly switch to a different X11 workspace that has another Tor Browser window open.
The dialog should pop up on top of the browser window in which the link was clicked, but instead appears above whichever browser window had focus last. Upon clicking "Download file" nothing will seem to happen, because the next dialog does appear on the other (proper) workspace.
Version: tor-browser-linux64-6.0a5-hardened_ALL.tar.xzhttps://gitlab.torproject.org/tpo/tpa/team/-/issues/18941nagios colchicifolium?2020-06-27T14:19:27ZKarsten Loesingnagios colchicifolium?can I receive email notifications from nagios for colchicifolium, in
particular for these two checks?
disk usage on /
disk usage on /srv
Thanks in advance!can I receive email notifications from nagios for colchicifolium, in
particular for these two checks?
disk usage on /
disk usage on /srv
Thanks in advance!https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/18939Tor Browser invites you to "send a copy of your Tor Log to the support team"2022-06-18T01:32:21ZRoger DingledineTor Browser invites you to "send a copy of your Tor Log to the support team"Along with the recent fix for legacy/trac#10534, we should consider not referring people to the nebulous "support team", especially since there isn't one currently.Along with the recent fix for legacy/trac#10534, we should consider not referring people to the nebulous "support team", especially since there isn't one currently.https://gitlab.torproject.org/tpo/core/tor/-/issues/18938Authorities should reject non-UTF-8 content in ExtraInfo descriptors2020-06-27T13:59:09ZteorAuthorities should reject non-UTF-8 content in ExtraInfo descriptorsIn legacy/trac#18656, we discovered that authorities don't validate that ExtraInfo descriptors are printable ASCII before accepting them.
Authorities (and HSDirs) should check every ~~directory~~ extrainfo document they receive consists...In legacy/trac#18656, we discovered that authorities don't validate that ExtraInfo descriptors are printable ASCII before accepting them.
Authorities (and HSDirs) should check every ~~directory~~ extrainfo document they receive consists only of ~~"printing ASCII"~~ UTF-8, as defined in ~~torspec...~~ prop285:
https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt
~~I've heard others say that the following lines allow non-ASCII content, but I'm not sure if that's actually the case, and if it is, how many relays this would affect:~~
* ~~the "platform" line in relay descriptors, which is a "human-readable string",~~
* ~~the contact "info" line in relay descriptors, which has an undefined format.~~
Edit: allowing users to spell their names correctly is important. That's why we'll use utf-8 for relay descriptors, votes, and consensuses.
~~If it is, I'd recommend we make them all ASCII for consistency, and update torspec to clarify, and include it as a "major" change in an 0.2.x tor release.~~
~~(This means that some users will be unable to spell their names correctly. But there was never any guarantee that 8-bit characters in "info" would be interpreted as users intended. I think security is more important here.)~~Tor: unspecifiedNeel Chauhanneel@neelc.orgNeel Chauhanneel@neelc.orghttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/18937What's new (bugs) in Tor Browser 6.0a5 -- April 28 2016 - 2017 (7.0a3)2022-06-18T01:30:28ZbugzillaWhat's new (bugs) in Tor Browser 6.0a5 -- April 28 2016 - 2017 (7.0a3)This is a META bug.
All discussion in comments.This is a META bug.
All discussion in comments.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/18935MS bugs - Danger! Windows updates break everything on their way!2020-06-27T14:39:15ZbugzillaMS bugs - Danger! Windows updates break everything on their way!READ THIS BEFORE USING TOR BROWSER ON WINDOWS!
With the April's 2016 patch Tuesday Microsoft has shown to everybody what grade of software it's going to supply from now on:
[KB3147071](https://support.microsoft.com/en-us/kb/3147071) - ...READ THIS BEFORE USING TOR BROWSER ON WINDOWS!
With the April's 2016 patch Tuesday Microsoft has shown to everybody what grade of software it's going to supply from now on:
[KB3147071](https://support.microsoft.com/en-us/kb/3147071) - Welcome new "fast-ring"/"pre-beta" quality (see legacy/trac#18171), now for production servers ;) Discussion: https://www.dslreports.com/forum/r30702359-MS-patch-installing-old-vulnerable-version-of-ntdll-dll Proof from MS filelist:
```
x64 Windows 8.1 and Windows Server 2012 R2
File name,File version,File size,Date,Time,Platform,Service branch,
Ntdll.dll,"6.3.9600.18194","1,737,080","13-Jan-2016","21:26","x64","Not applicable",
```
And together with the
[KB3146706](https://support.microsoft.com/en-us/kb/3146706) - Welcome BSOD 0x0000006B (http://www.windowsnewscenter.com/2016/04/26/is-microsoft-using-security-patch-kb-3146706-to-break-pirate-copies-of/)
they present you:
Problem with application hangs due to EMET 5.5 EAF mitigation after Windows 7 April 2016 updates
https://social.technet.microsoft.com/Forums/en-US/7a681da9-d1d3-4566-a13d-55af0de0f2a5/problem-with-application-hangs-due-to-emet-55-eaf-mitigation-after-windows-7-april-2016-updates?forum=emet
[KB3149090](https://support.microsoft.com/en-us/kb/3149090) - can be PITA too (https://www.reddit.com/r/sysadmin/comments/4ewule/windows_32bit_emet_kb3146706_issue/)
[KB3145739](https://support.microsoft.com/en-us/kb/3145739) - can prevent you from installing all the April's crap until you install it manually.
And even Windows Update can daunt you to stop installing April's crap by going to very long several days checking for it with full CPU load... (can be fixed as the previous item)
Hangs and crashes of Tor Browser that are probably related to this crap are listed in comments:https://gitlab.torproject.org/tpo/core/tor/-/issues/18934test suite failures with expensive hardening.2020-06-27T13:59:09Zweasel (Peter Palfrader)test suite failures with expensive hardening.Building master [fb9c9e04f002fbbd9745911a17481b49ed66c9f4] with --enable-gcc-warnings --disable-silent-rules --enable-expensive-hardening,
```
16:59:04 =============================================
16:59:04 tor 0.2.9.0-alpha-dev: ./t...Building master [fb9c9e04f002fbbd9745911a17481b49ed66c9f4] with --enable-gcc-warnings --disable-silent-rules --enable-expensive-hardening,
```
16:59:04 =============================================
16:59:04 tor 0.2.9.0-alpha-dev: ./test-suite.log
16:59:04 =============================================
16:59:04
16:59:04 # TOTAL: 9
16:59:04 # PASS: 6
16:59:04 # SKIP: 1
16:59:04 # XFAIL: 0
16:59:04 # FAIL: 2
16:59:04 # XPASS: 0
16:59:04 # ERROR: 0
16:59:04
16:59:04 .. contents:: :depth: 2
16:59:04
16:59:04 FAIL: src/test/test-memwipe
16:59:04 ===========================
16:59:04
16:59:04 =================================================================
16:59:04 ==28523==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffec6e913d0 at pc 0x7fc25b0fdb29 bp 0x7ffec6e90f60 sp 0x7ffec6e90f58
16:59:04 READ of size 1 at 0x7ffec6e913d0 thread T0
16:59:04 #0 0x7fc25b0fdb28 in vmemeq ../src/test/test-memwipe.c:66
16:59:04 #1 0x7fc25b0fdb28 in check_a_buffer ../src/test/test-memwipe.c:88
16:59:04 #2 0x7fc25b0fc0c0 in main ../src/test/test-memwipe.c:180
16:59:04 #3 0x7fc257a66b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
16:59:04 #4 0x7fc25b0fd5ea (/srv/jenkins-workspace/workspace/tor-ci-linux-master/ARCHITECTURE/amd64/SUITE/jessie/build-tree-tor/src/test/test-memwipe+0x1545ea)
16:59:04
16:59:04 Address 0x7ffec6e913d0 is located in stack of thread T0 at offset 1056 in frame
16:59:04 #0 0x7fc25b0fd8af in check_a_buffer ../src/test/test-memwipe.c:74
16:59:04
16:59:04 This frame has 1 object(s):
16:59:04 [32, 1056) 'buf' <== Memory access at offset 1056 overflows this variable
16:59:04 HINT: this may be a false positive if your program uses some custom stack unwind mechanism or swapcontext
16:59:04 (longjmp and C++ exceptions *are* supported)
16:59:04 SUMMARY: AddressSanitizer: stack-buffer-overflow ../src/test/test-memwipe.c:66 vmemeq
16:59:04 Shadow bytes around the buggy address:
16:59:04 0x100058dca220: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
16:59:04 0x100058dca230: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
16:59:04 0x100058dca240: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
16:59:04 0x100058dca250: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
16:59:04 0x100058dca260: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
16:59:04 =>0x100058dca270: 00 00 00 00 00 00 00 00 00 00[f3]f3 f3 f3 00 00
16:59:04 0x100058dca280: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1
16:59:04 0x100058dca290: f1 f1 00 00 00 f4 00 00 00 00 00 00 00 00 00 00
16:59:04 0x100058dca2a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
16:59:04 0x100058dca2b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
16:59:04 0x100058dca2c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
16:59:04 Shadow byte legend (one shadow byte represents 8 application bytes):
16:59:04 Addressable: 00
16:59:04 Partially addressable: 01 02 03 04 05 06 07
16:59:04 Heap left redzone: fa
16:59:04 Heap right redzone: fb
16:59:04 Freed heap region: fd
16:59:04 Stack left redzone: f1
16:59:04 Stack mid redzone: f2
16:59:04 Stack right redzone: f3
16:59:04 Stack partial redzone: f4
16:59:04 Stack after return: f5
16:59:04 Stack use after scope: f8
16:59:04 Global redzone: f9
16:59:04 Global init order: f6
16:59:04 Poisoned by user: f7
16:59:04 Contiguous container OOB:fc
16:59:04 ASan internal: fe
16:59:04 ==28523==ABORTING
16:59:04
16:59:04 SKIP: src/test/test_switch_id.sh
16:59:04 ================================
16:59:04
16:59:04 This test only works when run as root. Skipping.
16:59:04
16:59:04 FAIL: src/test/test_bt.sh
16:59:04 =========================
16:59:04
16:59:04 OK
16:59:04 ../src/test/test_bt_cl.c:39:24: runtime error: store to null pointer of type 'volatile int'
16:59:04 ASAN:SIGSEGV
16:59:04 =================================================================
16:59:04 ==28713==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f9c360d73b4 sp 0x7fff3cd6cd20 bp 0x7fff3cd6cd40 T0)
16:59:04 #0 0x7f9c360d73b3 in crash ../src/test/test_bt_cl.c:39
16:59:04 #1 0x7f9c360d73f0 in oh_what ../src/test/test_bt_cl.c:58
16:59:04 #2 0x7f9c360d7441 in a_tangled_web ../src/test/test_bt_cl.c:64
16:59:04 #3 0x7f9c360d7490 in we_weave ../src/test/test_bt_cl.c:70
16:59:04 #4 0x7f9c360d6a74 in main ../src/test/test_bt_cl.c:119
16:59:04 #5 0x7f9c335d4b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
16:59:04 #6 0x7f9c360d71ea (/srv/jenkins-workspace/workspace/tor-ci-linux-master/ARCHITECTURE/amd64/SUITE/jessie/build-tree-tor/src/test/test-bt-cl+0x7f1ea)
16:59:04
16:59:04 AddressSanitizer can not provide additional info.
16:59:04 SUMMARY: AddressSanitizer: SEGV ../src/test/test_bt_cl.c:39 crash
16:59:04 ==28713==ABORTING
16:59:04 BAD
```Tor: 0.2.9.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/tpo/core/tor/-/issues/18933Several problems with test-network Makefile target2020-06-27T13:59:09ZIsis LovecruftSeveral problems with test-network Makefile targetIn legacy/trac#18240, cypherpunks pointed out that we should use the same `$(EXEEXT)` syntax for finding the appropriate `tor-gencert` and `tor-cov-gencert` in the `test-network` target.
There's a couple other problems with that target:...In legacy/trac#18240, cypherpunks pointed out that we should use the same `$(EXEEXT)` syntax for finding the appropriate `tor-gencert` and `tor-cov-gencert` in the `test-network` target.
There's a couple other problems with that target:
* `NETWORK_FLAVOUR=${NETWORK_FLAVOUR:-"bridges+hs"}`: the "bridges+hs" network template doesn't exist anymore.
* If `$use_coverage_binary` is set when `src/test/test-network.sh` is called, then chutney will still try to use `tor-gencert` instead of `tor-cov-gencert`. (Also the filename extension problem mentioned above applies here also.Tor: unspecifiedcypherpunkscypherpunkshttps://gitlab.torproject.org/tpo/core/chutney/-/issues/18932Re-launching chutney with cached descriptors sometimes fails2020-07-23T20:18:37ZteorRe-launching chutney with cached descriptors sometimes failsA user reports that chutney sometimes fails when relaunched with a previous configuration and cached descriptors.
https://lists.torproject.org/pipermail/tor-dev/2016-April/010854.html
Typically, chutney is run on a newly-configured dir...A user reports that chutney sometimes fails when relaunched with a previous configuration and cached descriptors.
https://lists.torproject.org/pipermail/tor-dev/2016-April/010854.html
Typically, chutney is run on a newly-configured directory every time, so we don't run into this bug very often.https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/18931coding style polishing2020-06-27T14:22:47Ziwakehcoding style polishingRemove most checkstyle complaints:
Priority wishlist:
1. Each variable declaration must be in its own statement. [MultipleVariableDeclarations], b/c this really enhances readability and could trip some IDEs when refactoring variable nam...Remove most checkstyle complaints:
Priority wishlist:
1. Each variable declaration must be in its own statement. [MultipleVariableDeclarations], b/c this really enhances readability and could trip some IDEs when refactoring variable names.
1. '<operator>' should be on a new line. [OperatorWrap]
1. Missing a Javadoc comment. [JavadocMethod]
1. others
It still needs to be verified, if our exceptions from Google-style are reflected in the checks. If not, metrics_checks.xml has to be changed accordingly.CollecTor 1.0.0iwakehiwakehhttps://gitlab.torproject.org/tpo/core/tor/-/issues/18930Segmentation fault: entry->parsed->intro_nodes2020-06-27T13:59:09ZTracSegmentation fault: entry->parsed->intro_nodesI have been running Tor on tor2web mode and now it has started to crash.
It crashes after few minutes of use. Before that it works normally.
```
Program received signal SIGSEGV, Segmentation fault.
0x00005555555c02d6 in rend_client_ge...I have been running Tor on tor2web mode and now it has started to crash.
It crashes after few minutes of use. Before that it works normally.
```
Program received signal SIGSEGV, Segmentation fault.
0x00005555555c02d6 in rend_client_get_random_intro_impl (
entry=0x5555555bf1bf <rend_client_fetch_v2_desc+114>, strict=0,
warnings=0)
at src/or/rendclient.c:1353
1353 smartlist_add_all(usable_nodes, entry->parsed->intro_nodes);
```
Tor version:
Tor 0.2.7.6 (git-605ae665009853bd)
On log:
Apr 29 03:52:05.920 [notice] Tor v0.2.7.6 running on Linux with Libevent 2.0.21-stable, OpenSSL 1.0.1f and Zlib 1.2.8.
...
Apr 29 03:52:18.000 [notice] Tor has successfully opened a circuit. Looks like client functionality is working.
Apr 29 03:52:18.000 [notice] Bootstrapped 100%: Done
(gdb) bt full
```
#0 0x00005555555c02d6 in rend_client_get_random_intro_impl (
entry=0x5555555bf1bf <rend_client_fetch_v2_desc+114>, strict=0, warnings=0)
at src/or/rendclient.c:1353
i = 32767
intro = 0x1
options = 0x555555a74770
usable_nodes = 0x555556944060
n_excluded = 0
__PRETTY_FUNCTION__ = "rend_client_get_random_intro_impl"
__func__ = "rend_client_get_random_intro_impl"
#1 0x00005555555c05de in rend_client_any_intro_points_usable (
entry=0x5555555bf1bf <rend_client_fetch_v2_desc+114>)
at src/or/rendclient.c:1422
extend_info = 0x555556860078
rv = 2054450743
#2 0x00005555555bfea1 in rend_client_desc_trynow (
query=0x5555568ea1f0 "oahmssjdnck7ntzx") at src/or/rendclient.c:1217
base_conn_sl_idx = 45
base_conn_sl_len = 97
base_conn = 0x5555567aef00
conn = 0x5555567aef00
entry = 0x5555555bf1bf <rend_client_fetch_v2_desc+114>
rend_data = 0x5555568661e0
now = 1461908592
conns = 0x555555a5c890
__PRETTY_FUNCTION__ = "rend_client_desc_trynow"
#3 0x00005555555bf366 in rend_client_refetch_v2_renddesc (
rend_query=0x5555568ea1f0) at src/or/rendclient.c:921
ret = 0
e = 0x0
__func__ = "rend_client_refetch_v2_renddesc"
__PRETTY_FUNCTION__ = "rend_client_refetch_v2_renddesc"
#4 0x0000555555699e50 in connection_dir_about_to_close (
dir_conn=0x5555568ee290) at src/or/directory.c:2312
---Type <return> to continue, or q <return> to quit---
conn = 0x5555568ee290
#5 0x0000555555663b87 in connection_about_to_close_connection (
conn=0x5555568ee290) at src/or/connection.c:704
__func__ = "connection_about_to_close_connection"
#6 0x000055555558de1c in connection_unlink (conn=0x5555568ee290)
at src/or/main.c:430
No locals.
#7 0x000055555558f4c6 in conn_close_if_marked (i=48) at src/or/main.c:982
conn = 0x5555568ee290
retval = 1452204688
now = 1461908592
__PRETTY_FUNCTION__ = "conn_close_if_marked"
__func__ = "conn_close_if_marked"
#8 0x000055555558ec09 in close_closeable_connections () at src/or/main.c:760
conn = 0x5555568ee290
i = 0
#9 0x000055555558ed88 in conn_read_callback (fd=-1, event=2,
_conn=0x5555568ee290) at src/or/main.c:795
conn = 0x5555568ee290
__PRETTY_FUNCTION__ = "conn_read_callback"
#10 0x00007ffff7684f24 in event_base_loop ()
from /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5
No symbol table info available.
#11 0x0000555555591da6 in run_main_loop_once () at src/or/main.c:2226
loop_result = 0
__PRETTY_FUNCTION__ = "run_main_loop_once"
#12 0x0000555555591ef6 in run_main_loop_until_done () at src/or/main.c:2267
loop_result = 1
#13 0x0000555555591cbf in do_main_loop () at src/or/main.c:2198
now = 1461907585
__PRETTY_FUNCTION__ = "do_main_loop"
__func__ = "do_main_loop"
#14 0x0000555555595d95 in tor_main (argc=1, argv=0x7fffffffe588)
at src/or/main.c:3294
---Type <return> to continue, or q <return> to quit---
result = 0
__PRETTY_FUNCTION__ = "tor_main"
#15 0x000055555558d4a4 in main (argc=1, argv=0x7fffffffe588)
at src/or/tor_main.c:30
r = 32767
```
**Trac**:
**Username**: juhaAndrea ShepardAndrea Shepard