The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2020-06-30T15:52:42Zhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34265Library selection for WebSocket communication with Tor relay.2020-06-30T15:52:42ZHashikDLibrary selection for WebSocket communication with Tor relay.For WebSocket libraries here are some mentions: \\
https://github.com/Tinder/Scarlet - Designed for Android, hence preferred.\\
https://github.com/TooTallNate/Java-WebSocket - Popular Java lib.\\
https://github.com/facundofarias/awesome-...For WebSocket libraries here are some mentions: \\
https://github.com/Tinder/Scarlet - Designed for Android, hence preferred.\\
https://github.com/TooTallNate/Java-WebSocket - Popular Java lib.\\
https://github.com/facundofarias/awesome-websockets - Curated list of WS.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34264Discussion on using a library for HTTP requests.2020-06-27T13:40:09ZHashikDDiscussion on using a library for HTTP requests.Since we are using POST request in long polling fashion to get the SDP offer from the broker and sending an answer. Since this is only a two-time use, do we need Retrofit library or if OkHttp is suffice. Retrofit uses OkHttp and it is a ...Since we are using POST request in long polling fashion to get the SDP offer from the broker and sending an answer. Since this is only a two-time use, do we need Retrofit library or if OkHttp is suffice. Retrofit uses OkHttp and it is a little bit bloated but feature-rich as compared to OkHttp.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34263Library selection for using WebRTC for the project.2020-06-27T13:40:09ZHashikDLibrary selection for using WebRTC for the project.Selecting a good and resilient library with frequent updates is imperative, these are the libraries available:
\\
Google's official library that we have to compile to use in our project: http://webrtc.github.io/webrtc-org/native-code/an...Selecting a good and resilient library with frequent updates is imperative, these are the libraries available:
\\
Google's official library that we have to compile to use in our project: http://webrtc.github.io/webrtc-org/native-code/android/
\\
~~Ant Server's library: https://github.com/ant-media/Ant-Media-Server/wiki/WebRTC-Android-SDK-Documentation - Here they used "Ant Media Server" as signaling server we can change that.~~
Ant Media Server uses WebRTC library on top of that they added their own functionality to make it work with Ant Media Server. Which is not very useful for our project.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34198Include full broker messaging spec in /doc2020-06-27T13:40:09ZCecylia BocovichInclude full broker messaging spec in /docThis adds information about the broker API, with the messaging protocol and the endpoints used by clients and proxies.
This is a prerequisite for our work to implement a Snowflake proxy on Android.This adds information about the broker API, with the messaging protocol and the endpoints used by clients and proxies.
This is a prerequisite for our work to implement a Snowflake proxy on Android.Cecylia BocovichCecylia Bocovichhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34151Readme needs update2020-06-27T13:40:09ZHashikDReadme needs updateFor testing, according to ReadMe.md...
''Unit testing with Jasmine are available with: npm install npm test
To run locally, start an HTTP server in build/ and navigate to /embed.html''
_npm run build_ needs to be a prerequisite before...For testing, according to ReadMe.md...
''Unit testing with Jasmine are available with: npm install npm test
To run locally, start an HTTP server in build/ and navigate to /embed.html''
_npm run build_ needs to be a prerequisite before starting the server and navigating to /embed.html.HashikDHashikDhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34147Remove redundant languages from snowflake page2021-07-09T18:26:26ZRoger DingledineRemove redundant languages from snowflake pagehttps://snowflake.torproject.org/
offers me en, en_GB, and en_US in the language drop-down menu. We should have one English, not three.
More generally, I bet we have a policy somewhere about which languages we want to be sure to include...https://snowflake.torproject.org/
offers me en, en_GB, and en_US in the language drop-down menu. We should have one English, not three.
More generally, I bet we have a policy somewhere about which languages we want to be sure to include when we have translated something, and we should see if we're missing any of those; and also I hope we have a policy about which languages to *not* include (and ideally we should go back to transifex and remove those from the set that people can translate, to avoid giving people the impression that they will be doing something useful if they e.g. translate en_US to en_GB).
I'm sorry I don't know more -- I bet Emma or Antonela or Gus will know more about whether we have languages policies and habits in place. :)https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34146localize screenshots on snowflake page2020-06-30T16:04:59ZRoger Dingledinelocalize screenshots on snowflake pagehttps://snowflake.torproject.org/?lang=zh_CN
scroll down to the picture of Tor Browser's network settings. That's an English Tor Browser. Should the Chinese version of the page be showing people using a Tor Browser in Chinese?https://snowflake.torproject.org/?lang=zh_CN
scroll down to the picture of Tor Browser's network settings. That's an English Tor Browser. Should the Chinese version of the page be showing people using a Tor Browser in Chinese?https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34140Require semicolons2020-06-27T13:40:09ZArlo BreaultRequire semicolonshttps://eslint.org/docs/rules/semi
From https://github.com/arlolra/snowflake-webext/commit/d0fc6aa10cc6a8cc85b9037d780e53282ae83bea#r38995051https://eslint.org/docs/rules/semi
From https://github.com/arlolra/snowflake-webext/commit/d0fc6aa10cc6a8cc85b9037d780e53282ae83bea#r38995051https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34132Fix running an npm globally installed snowflake2020-06-27T13:40:10ZArlo BreaultFix running an npm globally installed snowflakeSnowflake is now an [npm published package](https://www.npmjs.com/package/snowflake-pt) that can install a global bin with `npm i -g`
It seems to be missing a `#!/usr/bin/env node` at the top of the script thoughSnowflake is now an [npm published package](https://www.npmjs.com/package/snowflake-pt) that can install a global bin with `npm i -g`
It seems to be missing a `#!/usr/bin/env node` at the top of the script thoughhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34128The badge should have a version number discoverable in the source2020-06-27T13:40:10ZArlo BreaultThe badge should have a version number discoverable in the sourceIt's not clear if https://snowflake.torproject.org/embed.html is running `0.3.0`
Was it published after the most recent release?It's not clear if https://snowflake.torproject.org/embed.html is running `0.3.0`
Was it published after the most recent release?https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34127npm publish as part of the release process2020-06-27T13:40:10ZArlo Breaultnpm publish as part of the release processConsider `npm publish`ing when a new release is made.
The patch here makes updating the package.json part of the release process,
https://github.com/arlolra/snowflake-webext/commit/7231928c56ad509419c20ed1bb9be5645373c86cConsider `npm publish`ing when a new release is made.
The patch here makes updating the package.json part of the release process,
https://github.com/arlolra/snowflake-webext/commit/7231928c56ad509419c20ed1bb9be5645373c86chttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34126Handle onicecandidate firing after connection closed2020-06-27T13:40:10ZArlo BreaultHandle onicecandidate firing after connection closedThis may just be an issue with node-webrtc, but `Broker.sendAnswer` fires when waiting on an offer times out.
https://github.com/arlolra/snowflake-webext/commit/529a789bfcb9539176288f6659e7f2a60c2d6271This may just be an issue with node-webrtc, but `Broker.sendAnswer` fires when waiting on an offer times out.
https://github.com/arlolra/snowflake-webext/commit/529a789bfcb9539176288f6659e7f2a60c2d6271https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34124snowflake funktioniert nicht2020-06-27T13:40:10Zcypherpunkssnowflake funktioniert nichtAnzeige: WebRTC-Fähigkeit nicht erkannt.
Was soll ich tun?Anzeige: WebRTC-Fähigkeit nicht erkannt.
Was soll ich tun?https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34092Snowflake no longer working on Google Chrome2020-06-30T15:49:08ZcypherpunksSnowflake no longer working on Google ChromeExtension icon disappeared and cannot enable Snowflake in Google Chrome.Extension icon disappeared and cannot enable Snowflake in Google Chrome.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34053Update version of wrtc packate for web proxies2020-06-27T13:40:11ZCecylia BocovichUpdate version of wrtc packate for web proxiesWe're currently using version `0.0.62`. I tried an update to the current version `0.4.4` and it works. Let's update to make these a bit more secure.We're currently using version `0.0.62`. I tried an update to the current version `0.4.4` and it works. Let's update to make these a bit more secure.Cecylia BocovichCecylia Bocovichhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34050Restore check for nil writePipe in WebRTCPeer.Close2020-06-27T13:40:11ZDavid Fifielddcf@torproject.orgRestore check for nil writePipe in WebRTCPeer.CloseI removed this check in [047d3214bfb46de07e5d9f223e4fb1ba24584c8a](https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=047d3214bfb46de07e5d9f223e4fb1ba24584c8a) because `NewWebRTCPeer` always initializes `writePip...I removed this check in [047d3214bfb46de07e5d9f223e4fb1ba24584c8a](https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=047d3214bfb46de07e5d9f223e4fb1ba24584c8a) because `NewWebRTCPeer` always initializes `writePipe`, and it is never reset to `nil`. However tests used `&WebRTCPeer{}` which bypasses `NewWebRTCPeer` and leaves `writePipe` set to `nil`.
From comment:3:ticket:34049.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.orghttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34049Fix proxy calls to session description serialization utils2020-06-27T13:40:11ZCecylia BocovichFix proxy calls to session description serialization utilsWhoops, the proxy code wasn't updated after legacy/trac#33897Whoops, the proxy code wasn't updated after legacy/trac#33897Cecylia BocovichCecylia Bocovichhttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34042Reduce DataChannelTimeout2020-06-27T13:40:11ZDavid Fifielddcf@torproject.orgReduce DataChannelTimeoutSince legacy/trac#33897 we have separate timeout controls for first establishing the data channel (`DataChannelTimeout`) and deciding a once-working data channel has died (`SnowflakeTimeout`). They are both currently set to 30 s. We can ...Since legacy/trac#33897 we have separate timeout controls for first establishing the data channel (`DataChannelTimeout`) and deciding a once-working data channel has died (`SnowflakeTimeout`). They are both currently set to 30 s. We can lower `DataChannelTimeout` to discard non-working proxies more quickly.https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/34002Remove Snowflake interface, use *WebRTCPeer directly2020-06-27T13:40:11ZDavid Fifielddcf@torproject.orgRemove Snowflake interface, use *WebRTCPeer directlyThe other interfaces in client/lib/interfaces.go exist for the purpose of running tests, but not `Snowflake`. Existing code would not have worked with other types anyway, because it does unchecked `.(*WebRTCPeer)` conversions.The other interfaces in client/lib/interfaces.go exist for the purpose of running tests, but not `Snowflake`. Existing code would not have worked with other types anyway, because it does unchecked `.(*WebRTCPeer)` conversions.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.orghttps://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/33997Don't do a separate check for a short write2020-06-27T13:40:11ZDavid Fifielddcf@torproject.orgDon't do a separate check for a short writeMinor refactoring in the course of doing legacy/trac#33897.Minor refactoring in the course of doing legacy/trac#33897.David Fifielddcf@torproject.orgDavid Fifielddcf@torproject.org