The Tor Project issueshttps://gitlab.torproject.org/groups/tpo/-/issues2023-06-13T18:59:02Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41841Use the new onion-site.svg icon in the onion-location pill2023-06-13T18:59:02ZdonutsUse the new onion-site.svg icon in the onion-location pillThe .onion available pill is using the old onion-glyph in 12.5a7:
![onion-location](/uploads/8a453f0fbef9b2d776f96a1d9ba24994/onion-location.png)
It should use the new onion site icon instead, as per https://gitlab.torproject.org/tpo/a...The .onion available pill is using the old onion-glyph in 12.5a7:
![onion-location](/uploads/8a453f0fbef9b2d776f96a1d9ba24994/onion-location.png)
It should use the new onion site icon instead, as per https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41749.
I think this may have been missed during the onion.svg untangling that happened in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41809, or I caused even more confusion with this reply:
> onion-site.svg should only be used in place of the `security` padlock in the location bar
Which was inaccurate because the original design also included the onion-location pill.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/network-health/metrics/onionperf/-/issues/40063Add option to expose metrics port with a command line switch2023-06-14T11:50:24ZHiroAdd option to expose metrics port with a command line switchAdd a command line option to expose metrics port with a command line switch.Add a command line option to expose metrics port with a command line switch.https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40810Enable Finnish (fi) in alpha builds2023-06-14T14:23:49ZPier Angelo VendrameEnable Finnish (fi) in alpha buildsRecently, the Finnish translator did a great job, and translated a lot.
@emmapeel says that Finnish is now ready for alpha builds, so we should enable it ASAP, to get a few nightly builds translated, and also the next alpha.Recently, the Finnish translator did a great job, and translated a lot.
@emmapeel says that Finnish is now ready for alpha builds, so we should enable it ASAP, to get a few nightly builds translated, and also the next alpha.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/core/arti/-/issues/693Wire together the client handshake logic2023-06-14T15:07:53ZNick MathewsonWire together the client handshake logicOnce #692 is done, we'll have all the handshakes we need to connect to an onion service. As a separate step, we'll want to have the ability to actually make that connection! This means making all the circuits described in #692 as appro...Once #692 is done, we'll have all the handshakes we need to connect to an onion service. As a separate step, we'll want to have the ability to actually make that connection! This means making all the circuits described in #692 as appropriate, sending handshakes as necessary, retrying as necessary, and so on.
The retry logic needs to be rate limited, of course, but that's another ticket.
The goal of this ticket is to implement the code to "connect to a hidden service one time", whose draft API is currently in the `tor-hsclient` crate in !972. It will use the descriptor cache (#689) and the intro point status logic (#695), and support in `tor-circmgr` (#TBD).Arti: Onion service supportIan Jacksoniwj@torproject.orgIan Jacksoniwj@torproject.orghttps://gitlab.torproject.org/tpo/network-health/metrics/descriptorParser/-/issues/20Follow-up from "Resolve "Create tags for nodes""2023-06-14T16:36:46ZGeorg KoppenFollow-up from "Resolve "Create tags for nodes""The following discussion from tagtor!7 should be addressed:
- [ ] @gk started a [discussion](https://gitlab.torproject.org/tpo/network-health/metrics/tagtor/-/merge_requests/7#note_2889880): (+5 comments)
> I just realized that th...The following discussion from tagtor!7 should be addressed:
- [ ] @gk started a [discussion](https://gitlab.torproject.org/tpo/network-health/metrics/tagtor/-/merge_requests/7#note_2889880): (+5 comments)
> I just realized that the `effective_family` field should contain just the fingerprint here (again). That realization is based on the Onionoo output at least.HiroHirohttps://gitlab.torproject.org/tpo/network-health/metrics/descriptorParser/-/issues/36Add missing items to server_status table2023-06-14T16:36:46ZGeorg KoppenAdd missing items to server_status tableWe should add
```
exit_addresses
last_changed_address_or_port
unverified_host_names
unreachable_or_addresses
```
to the table, which we seemed to have forgotten.We should add
```
exit_addresses
last_changed_address_or_port
unverified_host_names
unreachable_or_addresses
```
to the table, which we seemed to have forgotten.HiroHirohttps://gitlab.torproject.org/tpo/network-health/metrics/descriptorParser/-/issues/28Fix issues in network status table2023-06-14T16:36:46ZHiroFix issues in network status tableIn https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2901161 and https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2901227 we went through a few issues with the ne...In https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2901161 and https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2901227 we went through a few issues with the network status tables that should be fixed.
We should also add logic to parse the `m line` for votes (https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2901241)
And check how we are parsing vs hard coding headers in documents. See: https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2901501HiroHirohttps://gitlab.torproject.org/tpo/network-health/metrics/descriptorParser/-/issues/21Clean up descriptorparser code while going over it again2023-06-14T16:36:46ZGeorg KoppenClean up descriptorparser code while going over it againI am double-checking all the tables we have over in collector#40016 and this ticket is for typos etc. I am finding while looking over the code again to get some clean up done.I am double-checking all the tables we have over in collector#40016 and this ticket is for typos etc. I am finding while looking over the code again to get some clean up done.Georg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/network-health/metrics/descriptorParser/-/issues/19Add missing fields to the bandwidth_record table2023-06-14T16:36:47ZGeorg KoppenAdd missing fields to the bandwidth_record tableI was double-checking the [`bandwidth-file-spec`]() making sure we have every item mentioned there accounted for in our table. I think here are the missing ones that still need to get added:
```
rtt
relay_recent_measurement_failure_count...I was double-checking the [`bandwidth-file-spec`]() making sure we have every item mentioned there accounted for in our table. I think here are the missing ones that still need to get added:
```
rtt
relay_recent_measurement_failure_count
relay_recent_measurements_excluded_near_count
relay_recent_measurements_excluded_old_count
relay_recent_measurements_excluded_few_count
under_min_report
unmeasured
vote
xoff_recv
xoff_sent
```HiroHirohttps://gitlab.torproject.org/tpo/network-health/metrics/descriptorParser/-/issues/32Parse directory key certificates2023-06-14T16:36:47ZHiroParse directory key certificatesWe should implement parsing for dir key certificate data. See: https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2900146We should implement parsing for dir key certificate data. See: https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2900146https://gitlab.torproject.org/tpo/network-health/metrics/descriptorParser/-/issues/33Parse router-digest-sha256 from extra info descriptors2023-06-14T16:36:47ZHiroParse router-digest-sha256 from extra info descriptorsWe are missing parsing the router-digest-sha256 field from extra-info descriptors.
See: https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2901077We are missing parsing the router-digest-sha256 field from extra-info descriptors.
See: https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2901077HiroHirohttps://gitlab.torproject.org/tpo/network-health/metrics/descriptorParser/-/issues/31Fix some fields in server descriptors parser2023-06-14T16:36:47ZHiroFix some fields in server descriptors parserThere are some fields that should be removed and some that should be fixed in the server descriptor parser and in the corresponding sql tables
https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2901516There are some fields that should be removed and some that should be fixed in the server descriptor parser and in the corresponding sql tables
https://gitlab.torproject.org/tpo/network-health/metrics/collector/-/issues/40016#note_2901516HiroHirohttps://gitlab.torproject.org/tpo/network-health/metrics/descriptorParser/-/issues/38Writing to VM on metricsdb-012023-06-14T16:36:47ZHiroWriting to VM on metricsdb-01Seems the parser is not writing to victoria metrics on the new deployed VM. We need to find out why.Seems the parser is not writing to victoria metrics on the new deployed VM. We need to find out why.HiroHirohttps://gitlab.torproject.org/tpo/network-health/margot/-/issues/7Create CI tests to check linters2023-06-14T16:41:56ZjugaCreate CI tests to check lintersFor instance, runnming `cargo clippy`. This depends on https://gitlab.torproject.org/tpo/network-health/team/-/issues/264For instance, runnming `cargo clippy`. This depends on https://gitlab.torproject.org/tpo/network-health/team/-/issues/264jugajugahttps://gitlab.torproject.org/tpo/network-health/margot/-/issues/5Replace count --help to print [filters] instead of <filters>?2023-06-14T16:41:56ZjugaReplace count --help to print [filters] instead of <filters>?Since filters seems to be optional. Remove then NOTE from README.md.Since filters seems to be optional. Remove then NOTE from README.md.jugajugahttps://gitlab.torproject.org/tpo/network-health/margot/-/issues/6Replace `test extend --help` command to print print `[filters]` instead of ...2023-06-14T16:41:56ZjugaReplace `test extend --help` command to print print `[filters]` instead of `<filters>...`?Since filters seems to be optional. Remove then NOTE from README.md. Similar issue #5.Since filters seems to be optional. Remove then NOTE from README.md. Similar issue #5.jugajugahttps://gitlab.torproject.org/tpo/network-health/margot/-/issues/9Find exit relays with the same exit policy2023-06-14T16:41:57ZGeorg KoppenFind exit relays with the same exit policyI think it would be useful to find relays with the same exit policy. We could add that to our `find` command. Maybe allowing to specify the accepted ports via command line could be a way to go.I think it would be useful to find relays with the same exit policy. We could add that to our `find` command. Maybe allowing to specify the accepted ports via command line could be a way to go.jugajugahttps://gitlab.torproject.org/tpo/network-health/margot/-/issues/23Support IPv6 for reject rules2023-06-14T16:41:57ZGeorg KoppenSupport IPv6 for reject rulesFrom https://gitlab.torproject.org/tpo/network-health/helper-scripts/-/issues/7:
```
When we generate reject rules in our helper scripts (any), we should also print out the IPv6 if the relay has one for the ORPort.
Note that `AuthDirRej...From https://gitlab.torproject.org/tpo/network-health/helper-scripts/-/issues/7:
```
When we generate reject rules in our helper scripts (any), we should also print out the IPv6 if the relay has one for the ORPort.
Note that `AuthDirReject` and family require the IPv6 to be enclosed in brackets: `[...]`.
```https://gitlab.torproject.org/tpo/network-health/margot/-/issues/11For !badexit rules we do not need to touch bad.conf2023-06-14T16:41:57ZGeorg KoppenFor !badexit rules we do not need to touch bad.confWhen applying badexit rules to relays we do so only per fingerprint and not per IP address nowadays. Thus, we don't need any `AuthDirBadExit` for now/anymore. I think we can outright remove that part for the time being. If, for some reas...When applying badexit rules to relays we do so only per fingerprint and not per IP address nowadays. Thus, we don't need any `AuthDirBadExit` for now/anymore. I think we can outright remove that part for the time being. If, for some reason, we actually want to use `AuthDirBadExit` at some point in the future again we could re-introduce it behind some command-line switch.jugajugahttps://gitlab.torproject.org/tpo/network-health/margot/-/issues/10Add support for !middleonly output2023-06-14T16:41:57ZGeorg KoppenAdd support for !middleonly outputWe do not only have `!badexit` rules or `!reject` rules but use `!middleonly` ones as well nowadays. We need support for that in `margot`, too. It should only affect `approved-routers.conf`. That is: we need only `!middleonly` rules, no ...We do not only have `!badexit` rules or `!reject` rules but use `!middleonly` ones as well nowadays. We need support for that in `margot`, too. It should only affect `approved-routers.conf`. That is: we need only `!middleonly` rules, no `AuthDir`* ones.jugajuga