Commit 89dfec02 authored by Nick Mathewson's avatar Nick Mathewson 🤹
Browse files

r17614@catbus: nickm | 2008-01-14 13:55:25 -0500 

 Add a missing "goto err" when parsing v2 ns docs


svn:r13133
parent d7fb8a34

ChangeLog

+3 −0
Original line number Diff line number Diff line
@@ -47,6 +47,9 @@ Changes in version 0.2.0.16-alpha - 2008-01-?? 
    - Detect more kinds of possible internal error.

    - Avoid possible segfault if key generation fails in

      crypto_pk_hybrid_encrypt. Bugfix on 0.2.0.

    - Avoid segfault in the case where a badly behaved v2 versioning

      directory sends a signed networkstatus with missing client-versions.

      Bugfix on 0.1.2.



  o Minor features (controller):

    - Get NS events working again.  (Patch from tup)

src/or/routerparse.c

+2 −1
Original line number Diff line number Diff line
@@ -1882,7 +1882,8 @@ networkstatus_v2_parse_from_string(const char *s) 


  if (ns->recommends_versions) {

    if (!(tok = find_first_by_keyword(tokens, K_CLIENT_VERSIONS))) {

      log_warn(LD_DIR, "Missing client-versions");

      log_warn(LD_DIR, "Missing client-versions on versioning directory");

      goto err;

    }

    ns->client_versions = tok->args[0];

    tok->args[0] = NULL;