Commit 41a8930f authored by Nick Mathewson's avatar Nick Mathewson 🤹
Browse files

scan-build: check impossible null-pointer case in buffers.c 

When maintaining buffer freelists, we don't skip more than there
are, so (*chp) can't be null to begin with.  scan-build has no way
to know that.
parent 08325b58

src/or/buffers.c

+1 −1
Original line number Diff line number Diff line
@@ -322,7 +322,7 @@ buf_shrink_freelists(int free_all) 
      chunk_t **chp = &freelists[i].head;

      chunk_t *chunk;

      while (n_to_skip) {

        if (! (*chp)->next) {

        if (!(*chp) || ! (*chp)->next) {

          log_warn(LD_BUG, "I wanted to skip %d chunks in the freelist for "

                   "%d-byte chunks, but only found %d. (Length %d)",

                   orig_n_to_skip, (int)freelists[i].alloc_size,