Commit 8bada1ef authored by Nick Mathewson's avatar Nick Mathewson 🦀
Browse files

Add missing break statements for Coverity CIDs #406,407. 

The code for these was super-wrong, but will only break things when we
reset an option on a platform where sizeof(time_t) is different from
sizeof(int).
parent 56048637

src/or/config.c

+2 −0
Original line number Diff line number Diff line
@@ -2225,6 +2225,7 @@ option_clear(config_format_t *fmt, or_options_t *options, config_var_t *var) 
      break;

    case CONFIG_TYPE_ISOTIME:

      *(time_t*)lvalue = 0;

      break;

    case CONFIG_TYPE_INTERVAL:

    case CONFIG_TYPE_UINT:

    case CONFIG_TYPE_BOOL:
@@ -2238,6 +2239,7 @@ option_clear(config_format_t *fmt, or_options_t *options, config_var_t *var) 
        routerset_free(*(routerset_t**)lvalue);

        *(routerset_t**)lvalue = NULL;

      }

      break;

    case CONFIG_TYPE_CSV:

      if (*(smartlist_t**)lvalue) {

        SMARTLIST_FOREACH(*(smartlist_t **)lvalue, char *, cp, tor_free(cp));