GitLab

Scale relays without average or observed bandwidth.
Later it will be check what to do if their values are None or 0

since they are probably due a bug.

for each relay, calculate the filtered mean for all relays and
calculate the filtered ratio for each relay.

using timestamps class.
Also add one more result to the tests data and change the
test accordingly.

in RelayPrioritizer:
- Rename recent_priority_list_count to recent_priority_list when
  there is no counting
- Rename recent_priority_relay_count to recent_priority_relay
  when there is no counting
- Use the timestamps class to manage/count priority lists/relays

in RelayList:
- Rename recent_measurement_attempt_count to recent_measurement_attempt when
  there is no counting
- Use the timestamps class to manage/count measurement attempts

in RelayList:
- Rename consensus_timestamps to recent_consensus
- Rename recent_consensus_count to recent_consensus when there is
  no counting
- Use the timestamps class to manage/count consensuses
- Remove method not needed anymore

Part of #30196

Part of #30196

Part of #30196.

Part of #30196.

by version.

Part of #30196.

- Create new KeyValues constants for the new v1.5.0 KeyValues
- Instanciate State in Header.from_results so that there is no need
  to create new methods for all the header KeyValues that are read
  from the state file
- Add tor_version to the kwargs to initialize the Header
- Write tor_version in the state file when the scanner is started

Closes: #30196.

Replace HEADER_INIT_KEYS constant KeyValues with other constants
created in the previous commit.

Part of #30196.

- Add new KeyValues constants
- Remove HEADER_KEYS_V1X constant, only used once
- Replace HEADER_UNORDERED_KEYS with the new constants

Part of #30196.

to build the list of all keys from it and ensure no key is missing.

After the automatic constants renaming, fix the flake8 errors by
reformatting automatically with `black`, only the lines that had
errors.

Part of #30196

Rename constants to make their names more consistent with each other.
All header constants start now by HEADER_ and all Bandwidth Lines by
BWLINE_.
The constants that are a list of keys are now named KEYS instead of
KEY_VALUE or KEY_VALUE.

These are the substitutions made:

s/BW_KEYVALUE_SEP_V1/BWLINE_KEYVALUES_SEP_V1/
s/BW_KEYVALUES_BASIC/BWLINE_KEYS_V0/
s/BW_KEYVALUES_FILE/BWLINE_KEYS_V1_1/
s/BW_KEYVALUES_EXTRA_BWS/BWLINE_KEYS_V1_2/
s/BANDWIDTH_LINE_KEY_VALUES_MONITOR/BWLINE_KEYS_V1_4/
s/BW_KEYVALUES_EXTRA/BWLINE_KEYS_V1/
s/BW_KEYVALUES_INT/BWLINE_INT_KEYS/
s/BW_KEYVALUES/BWLINE_ALL_KEYS/
s/EXTRA_ARG_KEYVALUES/HEADER_KEYS_V1X/
s/STATS_KEYVALUES/HEADER_KEYS_V1_2/
s/BW_HEADER_KEYVALUES_RECENT_MEASUREMENTS_EXCLUDED/HEADER_RECENT_MEASUREMENTS_EXCLUDED_KEYS/
s/BW_HEADER_KEYVALUES_MONITOR/HEADER_KEYS_V1_4/
s/BANDWIDTH_HEADER_KEY_VALUES_INIT/HEADER_INIT_KEYS/
s/KEYVALUES_INT/HEADER_INT_KEYS/
s/UNORDERED_KEYVALUES/HEADER_UNORDERED_KEYS/
s/ALL_KEYVALUES/HEADER_ALL_KEYS/

Part of #30196

Fixes bug 30747; bugfix on 1.1.0.

Use bytes to compare the sum of scaled bandwidth (in KB) with the
sum of the consensus one (previously converted to Bytes measured.
Also:
- Check that the bandwidth attribute exists, since it was not
  stored in older versions.
- Do not sum the bw=1 as a result of the relays being unmeasured.
- Calculate the percentage difference as two difference values.
- Log which were actually the bandwidth sums.

when setting vote and unmeasured Keys.
It doesn't matter here because there're not operations with the
Keys and they're always converted to string in the bandwidth file,
but it less confusing as integer.

under_min_report KeyValue when the minimum percent is not reached.
Also change list by int the methods that calculate the progress.

Part of #29853.

in the Bandwidth Lines.
When the minimum percent of relays it's not reached, still report
the relays but set KeyValues accordingly so that Tor doesn't vote
on their bandwidth.

Part of #29853.

in the Bandwidth Lines.

Part of #29853.

in the bandwidth file to know why there excluded relays.
The excluded relays' lines do not have the `bw` KeyValue so that
Tor does not parse them nor include them in a vote.

Closes: #28563

to the bandwidth file header.

Closes: #28983.

Part of #28565.

and return reason why the relay was excluded to be able to count
the relays excluded in the header.
Part of #28565.

Part of #28565.

Part of #28565.

and return reason why the relay was excluded to be able to count
the relays excluded in the header.
Part of #28565.

Part of #28565.