juga authored May 17, 2022 and Georg Koppen committed May 19, 2022

Closes #40137

before selecting other exits as helpers.
In #40136 we forgot to consider the corner case in #40041, discovered
thanks to analysis#36.
This was causing that sometimes a CC circuit was built when
bwscanner_cc wasn't equal or greater than 1 or the other way around.

We didn't realize about this cause this part of the code is very
confusing. To don't make it even more confusing, i've changed the
internal API:
- `select_helper_candidates`: split funtion into one to select the
  helper candidates, knowing whether to use the relay as exit or not
  and other function `use_relay_as_entry` to decide whether to use the
  relay as entry or not checking CC params.
  Also pass a new arg `relay_as_entry`.
- `create_path_relay`: rewmove not used `cb` arg, add `candidates` arg
  to stop having to select them again later on. Move the no
  `candidates` condition here instead of checking it in
  `pick_ideal_second_hop`.
- `_pick_ideal_second_hope: remove unneded `dest` and `cont argum...

Closes #40139

And log consensus params items instead of just keys.

before measuring an exit as exit.

Closes #40136

juga authored May 10, 2022 and Georg Koppen committed May 10, 2022

Closes #40135.

Because consensus parameters are strings in stem.

Closes #40134.

Update changelog and change release milestone in CI.

Closes #40131.

Closes #40132

and create methods to check that the consensus implements congestion
control.

Closes: #40125.

juga authored Feb 14, 2022 and Georg Koppen committed Feb 25, 2022

Update changelog and change release milestone in CI.

Closes #40118.

that was long ago released

Remove comment about tor 0.3.5, already EOL and update dates other tor
releases become stable or EOL.
No need to remove tests with tor 0.3.5, since there wasn't anymore.

Also:
- add Python 3.10 as supported version.
- target Python 3.10 in black

because it's already EOL. Also update dates other python releases.

Also:
- remove redundant image variable
- build docs with python 3.9 too
- Add python 3.9 as target-version for black

if both operands are simple. To make CI tests pass with new black
version 22.1 (#2726).

Closes #40123

If a bwauth operator wish to receive (email) alerts, it might be more
convenient to set the log level to error.

Closes #40121

Remove userquery code

Closes #29749

See merge request tpo/network-health/sbws!115

about the difference between the sum of the last consensus weight and
the sum of the reported weight in the just generated Bandwidth File.
Otherwise, when looking at the warnings only, it's not explained what
the percentage is about.

Closes #40115

Because it might happen due fetching "early", "useless" descriptors or
non running relays, so that there aren't too many warnings.

Closes #40116.

sbws doesn't use default logging configuration until it tries to read
configuration files. However it prints to stdout which configuration
file is being used before that.
If an sbws' operator wish to only receive emails on warnings, they'll
still receive emails because of the print line. Therefore stop printing
before configuring logging.

Closes #40110.

fix: test: improve coverage timestamps.py

See merge request tpo/network-health/sbws!110