Commit 86c8e1ee authored by Emilio Cobos Álvarez's avatar Emilio Cobos Álvarez
Browse files

Bug 1644612 - Add a height and cleanup languages listbox styling. a=RyanVM 

The "righter" way to do this is adding a bunch of min-height: 0 to the
grid, the dialog, the content box, etc. But this is more similar to what
other dialogs do.

Original Revision: https://phabricator.services.mozilla.com/D180890
parent 74235a29

browser/components/preferences/dialogs/browserLanguages.xhtml

+1 −8
Original line number Diff line number Diff line
@@ -31,14 +31,7 @@ 


    <description data-l10n-id="browser-languages-description" />



    <box

      flex="1"

      style="

        display: grid;

        grid-template-rows: 1fr auto;

        grid-template-columns: 1fr auto;

      "

    >

    <box class="languages-grid">

      <richlistbox id="selectedLocales" />

      <vbox>

        <button

browser/components/preferences/dialogs/languages.xhtml

+1 −8
Original line number Diff line number Diff line
@@ -50,14 +50,7 @@ 
      data-l10n-id="languages-customize-spoof-english"

      preference="privacy.spoof_english"

    />

    <box

      flex="1"

      style="

        display: grid;

        grid-template-rows: 1fr auto;

        grid-template-columns: 1fr auto;

      "

    >

    <box class="languages-grid">

      <richlistbox

        id="activeLanguages"

        seltype="multiple"

browser/themes/shared/preferences/preferences.css

+13 −0
Original line number Diff line number Diff line
@@ -1143,6 +1143,12 @@ menulist[indicator=true] > menupopup menuitem[indicator=true]:not([image]) > .me 
  margin-inline-end: 4px;

}



#activeLanguages,

#selectedLocales {

  min-height: 15em;

  contain: size;

}



#selectedLocales > richlistitem {

  padding-inline-start: 13px;

}
@@ -1159,6 +1165,13 @@ menulist[indicator=true] > menupopup menuitem[indicator=true]:not([image]) > .me 
  margin-inline-end: 0;

}



.languages-grid {

  flex: 1;

  display: grid;

  grid-template-rows: 1fr auto;

  grid-template-columns: 1fr auto;

}



/* Menulist styles */

.label-item {

  font-size: 0.8em;