Commit 122170c1 authored by Nick Mathewson's avatar Nick Mathewson 🐘
Browse files

Downlgrade tweak, and answer lots of XXX021s. No actual code fixes in this patch. 

svn:r17686
parent 6c6b0283

src/common/address.c

+1 −1
Changes for src/common/address.c: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -995,7 +995,7 @@ get_interface_address6(int severity, sa_family_t family, tor_addr_t *addr) 


/* ======

 * IPv4 helpers

 * XXXX021 IPv6 deprecate some of these.

 * XXXX022 IPv6 deprecate some of these.

 */



/** Return true iff <b>ip</b> (in host order) is an IP reserved to localhost,

src/common/tortls.h

+1 −1
Changes for src/common/tortls.h: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -22,7 +22,7 @@ typedef struct tor_tls_t tor_tls_t; 
/* Possible return values for most tor_tls_* functions. */

#define _MIN_TOR_TLS_ERROR_VAL     -9

#define TOR_TLS_ERROR_MISC         -9

/* Rename to unexpected close or something. XXXX021 */

/* Rename to unexpected close or something. XXXX */

#define TOR_TLS_ERROR_IO           -8

#define TOR_TLS_ERROR_CONNREFUSED  -7

#define TOR_TLS_ERROR_CONNRESET    -6

src/common/util.c

+1 −1
Changes for src/common/util.c: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -1286,7 +1286,7 @@ format_time_interval(char *out, size_t out_len, long interval) 


/* =====

 * Fuzzy time

 * XXXX021 Use this consistently or rip it out.

 * XXXX022 Use this consistently or rip it out.

 * ===== */



/* In a perfect world, everybody would run ntp, and ntp would be perfect, so

src/or/buffers.c

+1 −1
Changes for src/or/buffers.c: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -186,7 +186,7 @@ chunk_new_with_alloc_size(size_t alloc) 
      freelist->lowest_length = freelist->cur_length;

    ++freelist->n_hit;

  } else {

    /* XXXX021 take advantage of tor_malloc_roundup, once we know how that

    /* XXXX take advantage of tor_malloc_roundup, once we know how that

     * affects freelists. */

    if (freelist)

      ++freelist->n_alloc;

src/or/circuitbuild.c

+3 −3
Changes for src/or/circuitbuild.c: 3 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -1688,8 +1688,8 @@ choose_good_entry_server(uint8_t purpose, cpath_build_state_t *state) 
    routerlist_add_family(excluded, r);

  }

  if (firewall_is_fascist_or()) {

    /*XXXX021 This can slow things down a lot; use a smarter implementation */

    /* exclude all ORs that listen on the wrong port */

    /*XXXX This could slow things down a lot; use a smarter implementation */

    /* exclude all ORs that listen on the wrong port, if anybody notices. */

    routerlist_t *rl = router_get_routerlist();

    int i;
@@ -1898,7 +1898,7 @@ build_state_get_exit_nickname(cpath_build_state_t *state) 
 *

 * If it's not usable, set *<b>reason</b> to a static string explaining why.

 */

/*XXXX021 take a routerstatus, not a routerinfo. */

/*XXXX take a routerstatus, not a routerinfo. */

static int

entry_guard_set_status(entry_guard_t *e, routerinfo_t *ri,

                       time_t now, or_options_t *options, const char **reason)