Commit 2bf0e747 authored by Nick Mathewson's avatar Nick Mathewson 🐘
Browse files

Fix assertion in addressmap_clear_excluded_trackexithosts 

Fixes bug 3923; bugfix on 0.2.2.25-alpha; bugfix from 'laruldan' on trac.
parent e0dae644

changes/bug3923

0 → 100644
+5 −0
Changes for changes/bug3923: 5 added lines, 0 removed lines.
Original line number Diff line number Diff line 
  o Major bugfies:

    - Avoid an assertion failure when reloading a configuration with

      TrackExitHosts changes.  Found and fixed by 'laruldan'. Fixes

      bug 3923; bugfix on 0.2.2.25-alpha.

src/or/connection_edge.c

+4 −6
Changes for src/or/connection_edge.c: 4 added lines, 6 removed lines.
Original line number Diff line number Diff line
@@ -842,12 +842,10 @@ addressmap_clear_excluded_trackexithosts(or_options_t *options) 
    if (len < 6)

      continue; /* malformed. */

    dot = target + len - 6; /* dot now points to just before .exit */

    dot = strrchr(dot, '.'); /* dot now points to the . before .exit or NULL */

    if (!dot) {

      nodename = tor_strndup(target, len-5);

    } else {

      nodename = tor_strndup(dot+1, strlen(dot+1)-5);

    }

    while(dot > target && *dot != '.')

	dot--;

    if (*dot == '.') dot++;

    nodename = tor_strndup(dot, len-5-(dot-target));;

    ri = router_get_by_nickname(nodename, 0);

    tor_free(nodename);

    if (!ri ||