Commit 647c076c authored by Nick Mathewson's avatar Nick Mathewson 🐘
Browse files

add a TODO item and some comment changes. 


svn:r2904
parent 3e4f30fb

doc/TODO

+2 −1
Changes for doc/TODO: 2 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -50,7 +50,8 @@ N . Test hibernation a lot. 
Beyond 0.0.9:

   - controller should have 'getinfo' command to query about rephist,

     about rendezvous status, etc.

   - weasel wants to say 50GB rather than 50000000 in config ints.

   - Weasel wants to say 50GB rather than 50000000 in config ints.

   - Nick wants to say "1 hour" instead of 3600 in config ints.

   - Better hibernation flexibility

     - Add hibernation intervals for weeks, days.

     - Start at a time other than 0:00 GMT.

src/or/circuitbuild.c

+1 −2
Changes for src/or/circuitbuild.c: 1 added line, 2 removed lines.
Original line number Diff line number Diff line
@@ -422,8 +422,7 @@ int circuit_send_next_onion_skin(circuit_t *circ) { 
      if(!has_completed_circuit) {

        has_completed_circuit=1;

        log_fn(LOG_NOTICE,"Tor has successfully opened a circuit. Looks like it's working.");

        /* XXX009 put a count of known routers here */

        /* XXXX "Put?" Do you mean log, or something else? -NM */

        /* XXX009 Log a count of known routers here */

      }

      circuit_rep_hist_note_result(circ);

      circuit_has_opened(circ); /* do other actions as necessary */

src/or/hibernate.c

+6 −4
Changes for src/or/hibernate.c: 6 added lines, 4 removed lines.
Original line number Diff line number Diff line
@@ -206,12 +206,14 @@ update_expected_bandwidth(void) 
{

  uint64_t used;

  uint32_t max_configured = (get_options()->BandwidthRateBytes * 60);

  /* XXX max_configured will be false if it exceeds

   * get_options()->AccountingMaxKB*1000, right? -RD

   * XXX Huh? Why? How? -NM

   */



  if (n_seconds_active_in_interval < 1800) {

    /* If we haven't gotten enough data last interval, guess that

     * we'll be used at our maximum capacity.  This is unlikely to be

     * so, but it will give us an okay first estimate, and we'll stay

     * up until we send MaxKB kilobytes.  Next interval, we'll choose

     * our starting time based on how much we sent this interval.

     */

    expected_bandwidth_usage = max_configured;

  } else {

    used = n_bytes_written_in_interval < n_bytes_read_in_interval ?