Commit 7779c63e authored by Nick Mathewson's avatar Nick Mathewson 🐘
Browse files

Accept hs descriptors even if we don't see an HSDir for us 

The old behavior contributed to unreliability when hidden services and
hsdirs had different consensus versions, and so had different opinions
about who should be cacheing hsdir info.

Bugfix on 0.2.0.10-alpha; based on discussions surrounding bug 2732.
parent b47f574c

changes/bug2732-simple

0 → 100644
+7 −0
Changes for changes/bug2732-simple: 7 added lines, 0 removed lines.
Original line number Original line Diff line number Diff line 
  o Minor bugfixes

    - Do not reject hidden service descriptors simply because we don't

      think we have not been assigned the HSDir flag.  Clients and

      hidden services can have a more up-to-date view of the network

      consensus, and if they think that the directory authorities

      list us a HSDir, we might actually be one.  Related to bug 2732;

      bugfix on 0.2.0.10-alpha.

src/or/routerlist.c

+0 −5
Changes for src/or/routerlist.c: 0 added lines, 5 removed lines.
Original line number Original line Diff line number Diff line
@@ -5778,11 +5778,6 @@ hid_serv_acting_as_directory(void) 
             "being a hidden service directory.");

             "being a hidden service directory.");

    return 0;

    return 0;

  }

  }

  if (!rs->is_hs_dir) {

    log_info(LD_REND, "We're not listed as a hidden service directory in "

             "the consensus, so we won't be one.");

    return 0;

  }

  return 1;

  return 1;

}

}