Commit c024928b authored by Roger Dingledine's avatar Roger Dingledine
Browse files

For belt-and-suspenders, relays that don't set Address in their config 

now avoid using begin_dir for all direct connections.


svn:r19296
parent 419d158c

ChangeLog

+6 −5
Changes for ChangeLog: 6 added lines, 5 removed lines.
Original line number Diff line number Diff line
@@ -7,11 +7,12 @@ Changes in version 0.2.1.14-rc - 2009-04-11 


  o Major bugfixes (on 0.2.0):

    - Finally fix the bug where dynamic-IP relays disappear when their

      IP address changes: directory mirrors were mistakenly telling them

      their old address if they asked via begin_dir, so they never got

      an accurate answer about their new address, so they just vanished

      after a day. Should fix bugs 827, 883, and 900 -- but alas, only

      after every directory mirror has upgraded.

      IP address changes: directory mirrors were mistakenly telling

      them their old address if they asked via begin_dir, so they

      never got an accurate answer about their new address, so they

      just vanished after a day. For belt-and-suspenders, relays that

      don't set Address in their config now avoid using begin_dir for

      all direct connections. Should fix bugs 827, 883, and 900.

    - Relays were falling out of the networkstatus consensus for

      part of a day if they changed their local config but the

      authorities discarded their new descriptor as "not sufficiently

src/or/directory.c

+2 −1
Changes for src/or/directory.c: 2 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -681,7 +681,8 @@ directory_command_should_use_begindir(or_options_t *options, 
    return 0; /* We don't know an ORPort -- no chance. */

  if (!anonymized_connection)

    if (!fascist_firewall_allows_address_or(addr, or_port) ||

        directory_fetches_from_authorities(options))

        directory_fetches_from_authorities(options) ||

        (server_mode(options) && !options->Address))

      return 0; /* We're firewalled or are acting like a relay -- also no. */

  if (!options->TunnelDirConns &&

      router_purpose != ROUTER_PURPOSE_BRIDGE)