Commit c4ac4bcb authored by Nick Mathewson's avatar Nick Mathewson 🐘
Browse files

r8696@Kushana: nickm | 2006-08-31 14:43:44 -0400 

 Try to appease some warnings with newer gccs that believe that ignoring a return value is okay, but casting a return value and then ignoring it is a sign of madness.


svn:r8312
parent 21a78803

src/common/crypto.c

+1 −6
Changes for src/common/crypto.c: 1 added line, 6 removed lines.
Original line number Diff line number Diff line
@@ -503,12 +503,7 @@ crypto_pk_write_public_key_to_string(crypto_pk_env_t *env, char **dest, 
  }



  BIO_get_mem_ptr(b, &buf);

  BIO_set_close(b, BIO_NOCLOSE); /* so BIO_free doesn't free buf */

  /* XXX The above line generates a warning on new gcc/openssls:

   * crypto.c:506: warning: value computed is not used

   * Perhaps in new openssls this is a more complex macro and

   * we're no longer calling it quite right? -RD

   */

  (void)BIO_set_close(b, BIO_NOCLOSE); /* so BIO_free doesn't free buf */

  BIO_free(b);



  tor_assert(buf->length >= 0);

src/common/tortls.c

+1 −1
Changes for src/common/tortls.c: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -692,7 +692,7 @@ log_cert_lifetime(X509 *cert, const char *problem) 
  BIO_get_mem_ptr(bio, &buf);

  s1 = tor_strndup(buf->data, buf->length);



  BIO_reset(bio);

  (void)BIO_reset(bio);

  if (!(ASN1_TIME_print(bio, X509_get_notAfter(cert)))) {

    tls_log_errors(LOG_WARN, "printing certificate lifetime");

    goto end;