Commit fd4c6246 authored by Nick Mathewson's avatar Nick Mathewson 🐘
Browse files

Belt *or* suspenders will be sufficient when casting things to unsigned char. 


svn:r3122
parent 524a8bdc

src/common/crypto.c

+2 −3
Changes for src/common/crypto.c: 2 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -974,12 +974,11 @@ int 
crypto_pk_check_fingerprint_syntax(const char *s)

{

  int i;

  const unsigned char *cp = s;

  for (i = 0; i < FINGERPRINT_LEN; ++i) {

    if ((i%5) == 4) {

      if (!TOR_ISSPACE(cp[i])) return 0;

      if (!TOR_ISSPACE(s[i])) return 0;

    } else {

      if (!TOR_ISXDIGIT(cp[i])) return 0;

      if (!TOR_ISXDIGIT(s[i])) return 0;

    }

  }

  if (s[FINGERPRINT_LEN]) return 0;