Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T15:40:08Zhttps://gitlab.torproject.org/legacy/trac/-/issues/29992Update to April GeoIP2 database2020-06-13T15:40:08ZKarsten LoesingUpdate to April GeoIP2 database[My geoip-2019-04-02 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2019-04-02) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other b...[My geoip-2019-04-02 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2019-04-02) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other branches that are still maintained.Tor: 0.2.9.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/29666Update to March GeoIP2 database2020-06-13T15:38:59ZKarsten LoesingUpdate to March GeoIP2 database[My geoip-2019-03-04 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2019-03-04) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other b...[My geoip-2019-03-04 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2019-03-04) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other branches that are still maintained.Tor: 0.2.9.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/29599Test failure due to missing sr_state_free[_all]() in shared-random unit tests2020-06-13T15:38:38ZteorTest failure due to missing sr_state_free[_all]() in shared-random unit testsIt looks like Travis recently upgraded to a clang with a (better) LeakSanitizer.
The following tests have memory leaks:
* shared-random/vote
* shared-random/sr_compute_srv
* shared-random/state_transition
They are missing a call to sr_...It looks like Travis recently upgraded to a clang with a (better) LeakSanitizer.
The following tests have memory leaks:
* shared-random/vote
* shared-random/sr_compute_srv
* shared-random/state_transition
They are missing a call to sr_state_free() in 0.2.9 and later.
But it's spelt sr_state_free_all() in 0.3.3 and later.Tor: 0.2.9.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/29478Update to February GeoIP2 database2020-06-13T15:38:07ZKarsten LoesingUpdate to February GeoIP2 database[My geoip-2019-02-05 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2019-02-05) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other b...[My geoip-2019-02-05 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2019-02-05) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other branches that are still maintained.Tor: 0.2.9.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/29244Travis permissions error: failed to write Cargo.lock2020-06-13T15:37:39ZteorTravis permissions error: failed to write Cargo.lockLet's monitor this error, and see if it happens again.
From https://trac.torproject.org/projects/tor/ticket/23576?replyto=24#comment:24
> {{{
> error: failed to write /home/travis/build/torproject/tor/tor-0.4.0.1-alpha-dev/src/rust/Car...Let's monitor this error, and see if it happens again.
From https://trac.torproject.org/projects/tor/ticket/23576?replyto=24#comment:24
> {{{
> error: failed to write /home/travis/build/torproject/tor/tor-0.4.0.1-alpha-dev/src/rust/Cargo.lock
>
> Caused by:
> failed to open: /home/travis/build/torproject/tor/tor-0.4.0.1-alpha-dev/src/rust/Cargo.lock
>
> Caused by:
> Permission denied (os error 13)
> }}}
> https://travis-ci.org/torproject/tor/jobs/486721901#L3634Tor: 0.3.3.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/29145Fix a compiler warning on OpenBSD in test-memwipe.c2020-06-13T15:37:06ZTracFix a compiler warning on OpenBSD in test-memwipe.cIn test-memwipe.c, `malloc_options` needs to be declared extern:
```
src/test/test-memwipe.c:50:13: warning: no previous extern declaration for non-static variable 'malloc_options' [-Wmissing-variable-declarations]
const char *malloc_op...In test-memwipe.c, `malloc_options` needs to be declared extern:
```
src/test/test-memwipe.c:50:13: warning: no previous extern declaration for non-static variable 'malloc_options' [-Wmissing-variable-declarations]
const char *malloc_options="sufjj";
```
(`malloc_options` is only used on OpenBSD)
PR to follow.
**Trac**:
**Username**: kjakTor: 0.3.5.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/29029Make "tried to establish rendezvous on non-OR circuit" into a protocol warning2020-06-13T15:36:32ZteorMake "tried to establish rendezvous on non-OR circuit" into a protocol warningThere's nothing that relay operators can do to fix it.There's nothing that relay operators can do to fix it.Tor: 0.2.9.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/29026OpenSSL will not compile without engine support2020-06-13T15:36:30ZTracOpenSSL will not compile without engine supportTor currently disables its engine support for Android only. This breaks compilation on other platforms that lack engine support.
This patch changes the check to check for OPENSSL_NO_ENGINE, which should work everywhere.
**Trac**:
**U...Tor currently disables its engine support for Android only. This breaks compilation on other platforms that lack engine support.
This patch changes the check to check for OPENSSL_NO_ENGINE, which should work everywhere.
**Trac**:
**Username**: MangixTor: 0.3.5.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/29012Update to January GeoIP2 database2020-06-13T15:36:24ZKarsten LoesingUpdate to January GeoIP2 database[My geoip-2019-01-03 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2019-01-03) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other b...[My geoip-2019-01-03 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2019-01-03) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other branches that are still maintained.Tor: 0.2.9.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/28973Disable TLS1.3 when openssl bug 7712 is present2020-06-13T15:37:38ZNick MathewsonDisable TLS1.3 when openssl bug 7712 is presentSee #28616 for the impact of the bug in tor; see https://github.com/openssl/openssl/issues/7712 for the openssl issue.See #28616 for the impact of the bug in tor; see https://github.com/openssl/openssl/issues/7712 for the openssl issue.Tor: 0.3.3.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/28744Update to December GeoIP2 database2020-06-13T15:35:17ZKarsten LoesingUpdate to December GeoIP2 database[My geoip-2018-12-05 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2018-12-05) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other b...[My geoip-2018-12-05 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2018-12-05) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other branches that are still maintained.Tor: 0.2.9.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/28619hs-v3: Do not close RP circuits when deleting an ephemeral service2020-06-13T15:34:39ZDavid Gouletdgoulet@torproject.orghs-v3: Do not close RP circuits when deleting an ephemeral serviceRelated to the OnionShare issue with v3:
https://lists.torproject.org/pipermail/tor-dev/2018-November/013556.html
The v2 subsystem doesn't close the RP circuits so our best move here is to do the same. The fix is trivial.Related to the OnionShare issue with v3:
https://lists.torproject.org/pipermail/tor-dev/2018-November/013556.html
The v2 subsystem doesn't close the RP circuits so our best move here is to do the same. The fix is trivial.Tor: 0.3.3.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/28574Appveyor: OpenSSL unit test fails with header and library version mismatch2020-06-13T15:52:21ZteorAppveyor: OpenSSL unit test fails with header and library version mismatchI'm guessing that 1.1.1a and 1.1.1 are compatible, though?
```
crypto/openssl_version: [forking]
FAIL ../src/test/test_crypto.c:238: OpenSSL library version 1.1.1 did not begin with header version 1.1.1a.
[openssl_version FAILED]
``...I'm guessing that 1.1.1a and 1.1.1 are compatible, though?
```
crypto/openssl_version: [forking]
FAIL ../src/test/test_crypto.c:238: OpenSSL library version 1.1.1 did not begin with header version 1.1.1a.
[openssl_version FAILED]
```
https://ci.appveyor.com/project/torproject/tor/build/1.0.1625/job/gibgc64fp4hxsf2h?fullLog=true#L3064Tor: 0.3.4.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/28413FreeBSD build warning in aes_new_cipher()2020-06-13T15:34:02ZNick MathewsonFreeBSD build warning in aes_new_cipher()Our jenkins freebsd builders are trying again! And they are failing with:
```
18:20:41 ../tor/src/common/aes.c:107:14: error: variable 'c' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
18:20:...Our jenkins freebsd builders are trying again! And they are failing with:
```
18:20:41 ../tor/src/common/aes.c:107:14: error: variable 'c' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
18:20:41 default: tor_assert(0); // LCOV_EXCL_LINE
18:20:41 ^~~~~~~~~~~~~
```
Initializing c to NULL should solve this problem, which is IMO the compiler's fault.Tor: 0.2.9.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/28395Update to November GeoIP2 database2020-06-13T15:33:58ZKarsten LoesingUpdate to November GeoIP2 database[My geoip-2018-11-06 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2018-11-06) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other b...[My geoip-2018-11-06 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2018-11-06) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other branches that are still maintained.Tor: 0.2.9.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/28245Tor nodes with OpenSSL 1.1.1 can't communicate with each other2020-06-13T15:33:30ZGeorge KadianakisTor nodes with OpenSSL 1.1.1 can't communicate with each otherWe seem to have trouble in networks where both clients and relays are running openssl-1.1.1 . In particular, a chutney network on `openssl-1.1.1 (11 sept 2018)` will have its clients fail to bootstrap because they cant communicate any by...We seem to have trouble in networks where both clients and relays are running openssl-1.1.1 . In particular, a chutney network on `openssl-1.1.1 (11 sept 2018)` will have its clients fail to bootstrap because they cant communicate any bytes after the SSL handshake is done.
The problem might be that 1.1.1 is the version that introduces TLS-1.3, so these nodes are trying to do TLS-1.3 with each other.
Thanks to teor, dgoulet, nickm for the debug help.Tor: 0.3.5.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/28202Bad end-of-string check in get_next_token (CID various)2020-06-13T15:33:21ZNick MathewsonBad end-of-string check in get_next_token (CID various)There's a coverity warning about an overflow in test_parsecommmon. I think it is happening because of this code:
```
*s + 16 >= eol
```
That's the wrong way to test for end-of-string, since C says that *s+16 is undefined behavior if t...There's a coverity warning about an overflow in test_parsecommmon. I think it is happening because of this code:
```
*s + 16 >= eol
```
That's the wrong way to test for end-of-string, since C says that *s+16 is undefined behavior if the resulting pointer would be more than 1 off the end of the allocated byte array.Tor: 0.3.5.x-finalNick MathewsonNick Mathewsonhttps://gitlab.torproject.org/legacy/trac/-/issues/28024tell us where that mystery core file came from2020-06-13T15:32:48ZTaylor Yutell us where that mystery core file came fromWhen running `make distcheck`, run `file` on the mystery core file that sometimes appears, so we can better diagnose it.When running `make distcheck`, run `file` on the mystery core file that sometimes appears, so we can better diagnose it.Tor: 0.3.5.x-finalTaylor YuTaylor Yuhttps://gitlab.torproject.org/legacy/trac/-/issues/27991Update to October GeoIP2 database2020-06-13T15:32:34ZKarsten LoesingUpdate to October GeoIP2 database[My geoip-2018-10-09 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2018-10-09) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other b...[My geoip-2018-10-09 branch](https://gitweb.torproject.org/user/karsten/tor.git/log/?h=geoip-2018-10-09) contains the updated `geoip` and `geoip6` files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other branches that are still maintained.Tor: 0.2.9.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/27948Backtrace does not work on NetBSD2020-06-13T15:32:28ZTracBacktrace does not work on NetBSDI've run the self-tests on NetBSD-8.99.25/amd64, and I see two issues:
# TOTAL: 19
# PASS: 12
# SKIP: 5
# XFAIL: 0
# FAIL: 2
# XPASS: 0
# ERROR: 0
... ...I've run the self-tests on NetBSD-8.99.25/amd64, and I see two issues:
# TOTAL: 19
# PASS: 12
# SKIP: 5
# XFAIL: 0
# FAIL: 2
# XPASS: 0
# ERROR: 0
...
FAIL: src/test/test
===================
....
util/thread/conditionvar_timeout: [forking]
FAIL src/test/test_threads.c:285: assert(ti->n_timeouts OP_EQ 2): 1 vs 2Sep 10 14:30:54.789 [err] Error 16 destroying a mutex.
Sep 10 14:30:54.789 [err] tor_assertion_failed_(): Bug: src/common/compat_pthreads.c:172: tor_mutex_uninit: Assertion 0 failed; aborting. (on Tor 0.3.4.8 da95b91355248ad8)
Sep 10 14:30:54.793 [err] Bug: Assertion 0 failed in tor_mutex_uninit at src/common/compat_pthreads.c:172. Stack trace: (on Tor 0.3.4.8 da95b91355248ad8)
Sep 10 14:30:54.793 [err] Bug: 0xefe62985 <log_backtrace+0x4e> at ./src/test/test (on Tor 0.3.4.8 da95b91355248ad8)
Sep 10 14:30:54.793 [err] Bug: 0xefe7d021 <tor_assertion_failed_+0xa0> at ./src/test/test (on Tor 0.3.4.8 da95b91355248ad8)
Sep 10 14:30:54.793 [err] Bug: 0xefe80e3d <tor_mutex_uninit+0xa6> at ./src/test/test (on Tor 0.3.4.8 da95b91355248ad8)
Sep 10 14:30:54.793 [err] Bug: 0xefe693ff <tor_mutex_free_+0x2e> at ./src/test/test (on Tor 0.3.4.8 da95b91355248ad8)
Sep 10 14:30:54.793 [err] Bug: 0xefc92ee2 <test_threads_conditionvar+0xefa001f3> at ./src/test/test (on Tor 0.3.4.8 da95b91355248ad8)
Sep 10 14:30:54.793 [err] Bug: 0xefcedd21 <testcase_run_bare_+0xefa00051> at ./src/test/test (on Tor 0.3.4.8 da95b91355248ad8)
Sep 10 14:30:54.793 [err] Bug: 0xefcedecd <testcase_run_one+0x158> at ./src/test/test (on Tor 0.3.4.8 da95b91355248ad8)
Sep 10 14:30:54.793 [err] Bug: 0xefcee51c <tinytest_main+0x107> at ./src/test/test (on Tor 0.3.4.8 da95b91355248ad8)
Sep 10 14:30:54.793 [err] Bug: 0xefe99621 <main+0x2d1> at ./src/test/test (on Tor 0.3.4.8 da95b91355248ad8)
[Lost connection!]
[conditionvar_timeout FAILED]
util/handle/basic: OK
...
FAIL: src/test/test_bt.sh
=========================
OK
[1] Abort trap "${builddir:-.}/src/test/test-bt-cl" assert 2>&1 |
Done "${PYTHON:-python}" "${abs_top_srcdir:-.}/src/...
BAD
============================================================ T= 1536589911
Tor died: Caught signal 11
0x94a0aa3d <crash_handler+0x94a00043> at ./src/test/test-bt-cl
0x94a0a8cd <crash+0x45> at ./src/test/test-bt-cl
[1] Abort trap "${builddir:-.}/src/test/test-bt-cl" crash 2>&1 |
Done(1) "${PYTHON:-python}" "${abs_top_srcdir:-.}/src/...
-158318
FAIL src/test/test_bt.sh (exit status: 1)
# gdb src/test/test test.core
GNU gdb (GDB) 8.0.1
Copyright (C) 2017 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64--netbsd".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from src/test/test...done.
[New process 1]
[New process 5]
[New process 2]
bCore was generated by `test'.
Program terminated with signal SIGABRT, Aborted.
#0 0x00007500d531eeca in _lwp_kill () from /usr/lib/libc.so.12
[Current thread is 1 (process 1)]
(gdb) bt
#0 0x00007500d531eeca in _lwp_kill () from /usr/lib/libc.so.12
#1 0x00007500d531eb57 in abort () at /usr/src/lib/libc/stdlib/abort.c:74
#2 0x00000000efe80e42 in tor_mutex_uninit (m=m@entry=0x7500d3e0b080) at src/common/compat_pthreads.c:172
#3 0x00000000efe693ff in tor_mutex_free_ (m=0x7500d3e0b080) at src/common/compat_threads.c:55
#4 0x00000000efc92ee2 in cv_testinfo_free (i=0x7500d3e09080) at src/test/test_threads.c:186
#5 test_threads_conditionvar (arg=<optimized out>) at src/test/test_threads.c:290
#6 0x00000000efcedd21 in testcase_run_bare_ (testcase=testcase@entry=0xf0263850 <thread_tests+80>) at src/ext/tinytest.c:106
#7 0x00000000efcedecd in testcase_run_forked_ (group=<optimized out>, testcase=0xf0263850 <thread_tests+80>) at src/ext/tinytest.c:190
#8 testcase_run_one (group=<optimized out>, testcase=0xf0263850 <thread_tests+80>) at src/ext/tinytest.c:248
#9 0x00000000efcee51c in tinytest_main (c=<optimized out>, v=<optimized out>, groups=<optimized out>) at src/ext/tinytest.c:435
#10 0x00000000efe99621 in main (c=1, v=0x7f7fffc611d8) at src/test/testing_common.c:319
**Trac**:
**Username**: wizTor: 0.3.5.x-finalteorteor