Trac issueshttps://gitlab.torproject.org/legacy/trac/-/issues2020-06-13T15:37:39Zhttps://gitlab.torproject.org/legacy/trac/-/issues/29243Fix minor bugs in the HSv3 unit tests2020-06-13T15:37:39ZteorFix minor bugs in the HSv3 unit testsThe tests:
* copy the first 20 characters of a 40-character hex string to a binary fingerprint
* put IPv6 addresses in a variable called "ipv4"
* do a duplicate tt_int_op() to deliberately fail and print a value, without a comment explai...The tests:
* copy the first 20 characters of a 40-character hex string to a binary fingerprint
* put IPv6 addresses in a variable called "ipv4"
* do a duplicate tt_int_op() to deliberately fail and print a value, without a comment explaining the code
Let's review these changes in #23576.Tor: unspecifiedteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/29237Restore IPv6 intro points in the HS client tests2020-06-13T15:37:37ZteorRestore IPv6 intro points in the HS client testsIn #23576, I removed an IPv6-only intro point from the HS client tests. We should put it back in.In #23576, I removed an IPv6-only intro point from the HS client tests. We should put it back in.Tor: 0.4.1.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/27737Manually remove 64.113.32.29 from the generated fallback list2020-06-13T16:06:31ZteorManually remove 64.113.32.29 from the generated fallback listIf 64.113.32.29 hasn't changed to 198.232.165.2 yet, we should manually remove it from the generated fallback list.If 64.113.32.29 hasn't changed to 198.232.165.2 yet, we should manually remove it from the generated fallback list.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/27415All Tor instances should attempt to parse directory documents before uploadin...2020-06-13T16:21:09ZteorAll Tor instances should attempt to parse directory documents before uploading themThis helps us catch bugs like #16858 and #24821.This helps us catch bugs like #16858 and #24821.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/27414Relays should check that their descriptors are UTF-8 before uploading them2020-06-13T16:21:09ZteorRelays should check that their descriptors are UTF-8 before uploading themhttps://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n29https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n29Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/27374Bridge clients should reject non-UTF-8 in descriptors2020-06-13T15:30:26ZteorBridge clients should reject non-UTF-8 in descriptorsSee https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n63See https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n63Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/27370All Tor roles should reject non-ASCII in most directory documents2020-06-13T15:30:24ZteorAll Tor roles should reject non-ASCII in most directory documentsPart of #24033.
Full relay descriptors and the full and ns consensus flavours are an exception to this rule: they allow UTF-8 for contact and platform lines.
Should we really bake this constraint in to all tors, or should we let the au...Part of #24033.
Full relay descriptors and the full and ns consensus flavours are an exception to this rule: they allow UTF-8 for contact and platform lines.
Should we really bake this constraint in to all tors, or should we let the authorities decide?Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/27369All Tor roles should reject non-UTF-8 in all directory documents2020-06-13T15:30:23ZteorAll Tor roles should reject non-UTF-8 in all directory documentsPart of #24033.Part of #24033.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/27368Authorities should reject non-UTF-8 in votes and consensuses2020-06-13T15:30:23ZteorAuthorities should reject non-UTF-8 in votes and consensusesPart of #24033.Part of #24033.Tor: unspecifiedhttps://gitlab.torproject.org/legacy/trac/-/issues/27367Authorities should reject non-UTF-8 in relay descriptors2020-06-13T15:30:22ZteorAuthorities should reject non-UTF-8 in relay descriptorsPart of #24033.
https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n29Part of #24033.
https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n29Tor: 0.4.0.x-finalhttps://gitlab.torproject.org/legacy/trac/-/issues/27251Add single-onion-v23-ipv6-md to make test-network-all2020-06-13T15:29:56ZteorAdd single-onion-v23-ipv6-md to make test-network-allWhen IPv6 single onion services work, we should add the single-onion-v23-ipv6-md to TEST_CHUTNEY_FLAVORS_IPV6in src/test/include.am.
We can also remove single-onion-ipv6-md, because it's redundant.When IPv6 single onion services work, we should add the single-onion-v23-ipv6-md to TEST_CHUTNEY_FLAVORS_IPV6in src/test/include.am.
We can also remove single-onion-ipv6-md, because it's redundant.Tor: 0.4.1.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/27093Consistently use ${abs_top_srcdir:-../../..} in test_rust.sh2020-06-13T15:29:14ZteorConsistently use ${abs_top_srcdir:-../../..} in test_rust.shSometimes we just use ${abs_top_srcdir}Sometimes we just use ${abs_top_srcdir}Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/27090Travis: enable lzma and zstd in configure, if available2020-06-13T15:32:11ZteorTravis: enable lzma and zstd in configure, if availableOtherwise, we can break lzma or zstd detection without knowing it.Otherwise, we can break lzma or zstd detection without knowing it.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/27088Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS2020-06-13T15:29:12ZteorPass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGSOops, it seems we missed this one.Oops, it seems we missed this one.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/27087Run a single asciidoc build in Travis2020-06-13T15:29:12ZteorRun a single asciidoc build in TravisWe --disable-asciidoc on all our builds, and maybe we shouldn'tWe --disable-asciidoc on all our builds, and maybe we shouldn'tTor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/27086Write unit tests for fascist_firewall_choose_address_ls() and hs_get_extend_i...2020-06-13T15:29:11ZteorWrite unit tests for fascist_firewall_choose_address_ls() and hs_get_extend_info_from_lspecs()The branch in #23588 doesn't have unit tests, so we should write some.The branch in #23588 doesn't have unit tests, so we should write some.Tor: unspecifiedNeel Chauhanneel@neelc.orgNeel Chauhanneel@neelc.orghttps://gitlab.torproject.org/legacy/trac/-/issues/26992Add intro point IPv6 address to service descriptors2020-06-13T15:28:55ZteorAdd intro point IPv6 address to service descriptorsImplemented as a consequence of #23576, but I need a ticket number.Implemented as a consequence of #23576, but I need a ticket number.Tor: unspecifiedteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/26853SKIP test_key_expiration.sh on Windows2020-06-13T15:28:18ZteorSKIP test_key_expiration.sh on WindowsIt looks like #26076 also affects test_key_expiration.sh.
So like #26830, let's SKIP test_key_expiration.sh on Windows until the underlying issue is fixed.It looks like #26076 also affects test_key_expiration.sh.
So like #26830, let's SKIP test_key_expiration.sh on Windows until the underlying issue is fixed.Tor: 0.3.5.x-finalteorteorhttps://gitlab.torproject.org/legacy/trac/-/issues/26301dir-spec: update descriptor on bandwidth changes only when uptime is less tha...2020-06-13T15:26:24Zjugadir-spec: update descriptor on bandwidth changes only when uptime is less than a dayAs commented in https://trac.torproject.org/projects/tor/ticket/24104#comment:19, after changes to the code, the spec should be updatedAs commented in https://trac.torproject.org/projects/tor/ticket/24104#comment:19, after changes to the code, the spec should be updatedTor: 0.3.5.x-finaljugajugahttps://gitlab.torproject.org/legacy/trac/-/issues/26152Improve errors on crypto/openssl_version badness2020-06-13T15:25:49ZNick MathewsonImprove errors on crypto/openssl_version badnessWhen these tests fail, they currently do so in an unhelpful way. They should log the offending strings when the version strings don't match.
Extracted from #25549.When these tests fail, they currently do so in an unhelpful way. They should log the offending strings when the version strings don't match.
Extracted from #25549.Tor: 0.3.5.x-finalNick MathewsonNick Mathewson